Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 753602 - media-libs/libplacebo-2.72.0 fails building with dev-util/glslang-10.11.0.0_pre20200924
Summary: media-libs/libplacebo-2.72.0 fails building with dev-util/glslang-10.11.0.0_p...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Niklas Haas
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2020-11-08 21:11 UTC by Johannes Hirte
Modified: 2021-02-02 13:19 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
meson-log.txt (meson-log.txt,26.65 KB, text/plain)
2020-11-08 21:12 UTC, Johannes Hirte
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Johannes Hirte 2020-11-08 21:11:19 UTC
Trying recompiling libplacebo-2.72.0 with glslang-10.11.0.0_pre20200924 results in this error:

Library SPIRV-Tools-opt found: YES

../libplacebo-v2.72.0/src/meson.build:86:2: ERROR: Could not get define 'GLSLANG_PATCH_LEVEL'

A full log can be found at /var/tmp/portage/media-libs/libplacebo-2.72.0/work/libplacebo-v2.72.0-abi_x86_64.amd64/meson-logs/meson-log.txt



Reproducible: Always




emerge --info
Portage 3.0.9 (python 3.6.9-final-0, default/linux/amd64/17.1/systemd, gcc-10.2.0, glibc-2.32-r2, 5.10.0-rc2-00402-g4429f14aeea9 x86_64)
=================================================================
System uname: Linux-5.10.0-rc2-00402-g4429f14aeea9-x86_64-AMD_Ryzen_5_PRO_2500U_w-_Radeon_Vega_Mobile_Gfx-with-gentoo-2.7
KiB Mem:    14252100 total,   2054444 free
KiB Swap:    2097148 total,   2094332 free
Head commit of repository gentoo: 80fd887db26ca17ce6d7f6f55af1bc19a05e825b

Head commit of repository kde: 5596375bc69792df4b86f7159461a84339c54855

Head commit of repository qt: 103492b058a9052d08528df571b35465bae10f98

Head commit of repository x11: afbaafaa912dc09a19fee7ee28ef94c44a134a06

sh bash 5.0_p18
ld GNU ld (Gentoo 2.35.1 p1) 2.35.1
distcc 3.3.3 x86_64-pc-linux-gnu [disabled]
ccache version 4.0 [disabled]
app-shells/bash:          5.0_p18::gentoo
dev-java/java-config:     2.3.1::gentoo
dev-lang/perl:            5.30.3-r1::gentoo
dev-lang/python:          2.7.18-r4::gentoo, 3.7.9::gentoo, 3.8.6::gentoo, 3.9.0::gentoo
dev-util/ccache:          4.0::gentoo
dev-util/cmake:           3.18.4::gentoo
dev-util/pkgconfig:       0.29.2::gentoo
sys-apps/baselayout:      2.7::gentoo
sys-apps/sandbox:         2.20::gentoo
sys-devel/autoconf:       2.13-r1::gentoo, 2.69-r5::gentoo
sys-devel/automake:       1.16.2::gentoo
sys-devel/binutils:       2.35.1::gentoo
sys-devel/gcc:            9.3.0-r2::gentoo, 10.2.0-r3::gentoo
sys-devel/gcc-config:     2.3.2::gentoo
sys-devel/libtool:        2.4.6-r6::gentoo
sys-devel/make:           4.2.1-r4::gentoo
sys-kernel/linux-headers: 5.9::gentoo (virtual/os-headers)
sys-libs/glibc:           2.32-r2::gentoo
Repositories:

gentoo
    location: /var/db/repos/gentoo
    sync-type: git
    sync-uri: https://anongit.gentoo.org/git/repo/gentoo.git
    priority: -1000

kde
    location: /var/db/repos/kde
    sync-type: git
    sync-uri: git://anongit.gentoo.org/proj/kde.git
    masters: gentoo
    priority: 50

local
    location: /var/db/repos/local
    masters: gentoo
    priority: 50

qt
    location: /var/db/repos/qt
    sync-type: git
    sync-uri: git://anongit.gentoo.org/proj/qt.git
    masters: gentoo
    priority: 50

steam-overlay
    location: /var/db/repos/steam-overlay
    masters: gentoo
    priority: 50

x11
    location: /var/db/repos/x11
    sync-type: git
    sync-uri: https://anongit.gentoo.org/git/proj/x11.git
    masters: gentoo
    priority: 50

ACCEPT_KEYWORDS="amd64 ~amd64"
ACCEPT_LICENSE="@FREE"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-O2 -march=znver1 -mtune=znver1 --param l1-cache-size=32 --param l1-cache-line-size=64 --param l2-cache-size=512 -ftree-vectorize -fvect-cost-model -pipe"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/lib64/libreoffice/program/sofficerc /usr/share/config /usr/share/easy-rsa /usr/share/gnupg/qualified.txt"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/php/apache2-php7.4/ext-active/ /etc/php/cgi-php7.4/ext-active/ /etc/php/cli-php7.4/ext-active/ /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c"
CXXFLAGS="-O2 -march=znver1 -mtune=znver1 --param l1-cache-size=32 --param l1-cache-line-size=64 --param l2-cache-size=512 -ftree-vectorize -fvect-cost-model -pipe"
DISTDIR="/var/cache/distfiles"
EMERGE_DEFAULT_OPTS="--with-bdeps=y --quiet-build=n"
ENV_UNSET="CARGO_HOME DBUS_SESSION_BUS_ADDRESS DISPLAY GOBIN GOPATH PERL5LIB PERL5OPT PERLPREFIX PERL_CORE PERL_MB_OPT PERL_MM_OPT XAUTHORITY XDG_CACHE_HOME XDG_CONFIG_HOME XDG_DATA_HOME XDG_RUNTIME_DIR"
FCFLAGS="-O2 -march=znver1 -mtune=znver1 --param l1-cache-size=32 --param l1-cache-line-size=64 --param l2-cache-size=512 -ftree-vectorize -fvect-cost-model -pipe"
FEATURES="assume-digests binpkg-docompress binpkg-dostrip binpkg-logs config-protect-if-modified distlocks ebuild-locks fixlafiles ipc-sandbox merge-sync metadata-transfer multilib-strict network-sandbox news parallel-fetch pid-sandbox preserve-libs qa-unresolved-soname-deps sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr"
FFLAGS="-O2 -march=znver1 -mtune=znver1 --param l1-cache-size=32 --param l1-cache-line-size=64 --param l2-cache-size=512 -ftree-vectorize -fvect-cost-model -pipe"
GENTOO_MIRRORS="http://distfiles.gentoo.org"
LANG="en_US.UTF-8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
LINGUAS="de en"
MAKEOPTS="-j8 -l8"
PKGDIR="/var/cache/binpkgs"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git"
PORTAGE_TMPDIR="/var/tmp"
USE="X a52 aac aacplus acl activities alsa alt-svc amd64 amr amrenc anacron berkdb blake2 bluetooth brotli bzip2 cairo caps celt chm cleartype_hinting cli corefonts crypt cryptsetup cups d3d9 dav1d dbus dell device-mapper djvu dri drm dvd ebook editorconfig efi egl eps epub evdev exif faac fdk ffmpeg fftw flac fontconfig fortran gbm gdbm gif git glamor glslang gmp gold gpg gphoto2 gpm graphviz harfbuzz http2 hwloc iconv icu id3tag io-uring ipv6 ithreads jpeg kate kipi lcms lensfun libaom libatomic libcxx libcxxabi libffi libglvnd libinput libkms libsamplerate libtirpc libunwind libxml2 lm-sensors lz4 lzma lzo mad matroska mjpeg mmap mng mobi modern-top mp3 mpeg mtp multilib mysql ncurses networkmanager nfs nls nptl ogg openal opencv openexr opengl openmp openssl opus pam parted pcre pcre16 pdf png policykit postscript pulseaudio python qml qt5 raw readline rtmp s3tc schroedinger screencast sdl sdl2 seccomp sift smp sndfile sox speex spice split-usr sqlite ssl subversion svg system-jsoncpp system-sqlite system-zlib systemd taglib tcpd tesseract theora threads thumbnail tiff truetype udev uefi unicode urandom usb usbredir user-session v4l vaapi vde vdpau vhosts virgl virt-network virtfs vorbis vpx vte vulkan wavpack wayland webp wmf x264 x265 xattr xcb xcomposite xkb xml xmp xpm xv xvid xxhash zink zip zlib zstd" ABI_X86="64" ADA_TARGET="gnat_2018" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="karbon sheets words" CAMERAS="canon ricoh ricoh_g3" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" CPU_FLAGS_X86="aes avx avx2 f16c fma3 mmx mmxext pclmul popcnt sha sse sse2 sse3 ssse3 sse4_1 sse4_2" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock greis isync itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf skytraq superstar2 timing tsip tripmate tnt ublox ubx" GRUB_PLATFORMS="efi-32 efi-64 pc" INPUT_DEVICES="evdev libinput synaptics" KERNEL="linux" L10N="de en" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" LLVM_TARGETS="AMDGPU BPF NVPTX X86" LUA_SINGLE_TARGET="lua5-1" LUA_TARGETS="lua5-1" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php7-2 php7-3 php7-4" POSTGRES_TARGETS="postgres10 postgres11" PYTHON_SINGLE_TARGET="python3_8" PYTHON_TARGETS="python3_7 python3_8 python3_9 pypy3" QEMU_SOFTMMU_TARGETS="aarch64 arm i386 x86_64" QEMU_USER_TARGETS="aarch64 arm" RUBY_TARGETS="ruby27" USERLAND="GNU" VIDEO_CARDS="amdgpu" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  CC, CPPFLAGS, CTARGET, CXX, INSTALL_MASK, LC_ALL, PORTAGE_BINHOST, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS
Comment 1 Johannes Hirte 2020-11-08 21:12:02 UTC
Created attachment 670508 [details]
meson-log.txt
Comment 2 Ionen Wolkens gentoo-dev 2020-11-09 04:19:37 UTC
Obvious but it's specific to USE=glslang, builds fine with everything else.

Haven't tried but believe fixed upstream by:
https://code.videolan.org/videolan/libplacebo/-/commit/fc1e8dd6c8be5c9bfc0d7387b7ad6d8320f1a9ae
Comment 3 Ionen Wolkens gentoo-dev 2020-11-09 04:23:29 UTC
(In reply to Ionen Wolkens from comment #2)
> Haven't tried
Well, libplacebo-9999[glslang] does work.
Comment 4 Johannes Hirte 2020-11-09 09:32:38 UTC
(In reply to Ionen Wolkens from comment #3)
> (In reply to Ionen Wolkens from comment #2)
> > Haven't tried
> Well, libplacebo-9999[glslang] does work.

but not media-libs/libplacebo-2.72.0:

 * Applying libplacebo-2.72.0-glslang-refactor_version_checks_to_respect_semantic.patch ...
patching file src/glsl/glslang.cc
Hunk #1 succeeded at 29 (offset -1 lines).
Hunk #2 FAILED at 42.
Hunk #3 FAILED at 84.
Hunk #4 FAILED at 206.
Hunk #5 FAILED at 217.
4 out of 5 hunks FAILED -- saving rejects to file src/glsl/glslang.cc.rej
patching file src/meson.build
Hunk #2 FAILED at 87.
Hunk #3 FAILED at 119.
2 out of 3 hunks FAILED -- saving rejects to file src/meson.build.rej                                                                                                                                                          [ !! ]
 * ERROR: media-libs/libplacebo-2.72.0::gentoo failed (prepare phase):
 *   patch -p1  failed with /etc/portage/patches/media-libs/libplacebo-2.72.0/libplacebo-2.72.0-glslang-refactor_version_checks_to_respect_semantic.patch
 * 
 * Call stack:
 *               ebuild.sh, line  125:  Called src_prepare
 *             environment, line 2841:  Called default
 *      phase-functions.sh, line  855:  Called default_src_prepare
 *      phase-functions.sh, line  920:  Called __eapi6_src_prepare
 *             environment, line  248:  Called eapply_user
 *             environment, line 1082:  Called eapply '/etc/portage/patches/media-libs/libplacebo-2.72.0/libplacebo-2.72.0-glslang-refactor_version_checks_to_respect_semantic.patch'
 *             environment, line 1052:  Called _eapply_patch '/etc/portage/patches/media-libs/libplacebo-2.72.0/libplacebo-2.72.0-glslang-refactor_version_checks_to_respect_semantic.patch'
 *             environment, line  990:  Called __helpers_die 'patch -p1  failed with /etc/portage/patches/media-libs/libplacebo-2.72.0/libplacebo-2.72.0-glslang-refactor_version_checks_to_respect_semantic.patch'
 *   isolated-functions.sh, line  112:  Called die
 * The specific snippet of code:
 *              die "$@"
 * 
 * If you need support, post the output of `emerge --info '=media-libs/libplacebo-2.72.0::gentoo'`,
 * the complete build log and the output of `emerge -pqv '=media-libs/libplacebo-2.72.0::gentoo'`.
 * The complete build log is located at '/var/tmp/portage/media-libs/libplacebo-2.72.0/temp/build.log'.
 * The ebuild environment file is located at '/var/tmp/portage/media-libs/libplacebo-2.72.0/temp/environment'.
 * Working directory: '/var/tmp/portage/media-libs/libplacebo-2.72.0/work/libplacebo-v2.72.0'
 * S: '/var/tmp/portage/media-libs/libplacebo-2.72.0/work/libplacebo-v2.72.0'
Comment 5 Ionen Wolkens gentoo-dev 2020-11-09 10:26:36 UTC
(In reply to Johannes Hirte from comment #4)
> but not media-libs/libplacebo-2.72.0:
> 
>  * Applying
> libplacebo-2.72.0-glslang-refactor_version_checks_to_respect_semantic.patch
I didn't mean to say should use that. The commit can't be used as-is given there was other things leading to it.

Anyhow, realizing who the libplacebo maintainer is in gentoo there's no need to be worried. There was actually no need for me to point upstream fixes given already knows very well :)
Comment 6 Larry the Git Cow gentoo-dev 2020-11-18 15:24:48 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=26bf7c7b99912e316a67c7a756f6f8ff343f2932

commit 26bf7c7b99912e316a67c7a756f6f8ff343f2932
Author:     Niklas Haas <gentoo@haasn.xyz>
AuthorDate: 2020-11-10 05:48:55 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2020-11-18 15:24:40 +0000

    media-libs/libplacebo: update to v2.72.2
    
    Simple bug fix release, most notably extending the range of supported
    glslang versions. There's no point in keeping the old version around.
    
    Signed-off-by: Niklas Haas <git@haasn.xyz>
    Closes: https://bugs.gentoo.org/753602
    Closes: https://github.com/gentoo/gentoo/pull/18209
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 media-libs/libplacebo/Manifest                                          | 2 +-
 .../libplacebo/{libplacebo-2.72.0.ebuild => libplacebo-2.72.2.ebuild}   | 0
 2 files changed, 1 insertion(+), 1 deletion(-)