Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 752888 - x11-themes/gtk-engines: migrate to lua eclasses
Summary: x11-themes/gtk-engines: migrate to lua eclasses
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Linux Gnome Desktop Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: slotted-lua
  Show dependency tree
 
Reported: 2020-11-03 15:37 UTC by Marek Szuba
Modified: 2020-12-22 17:32 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Marek Szuba archtester gentoo-dev 2020-11-03 15:37:56 UTC
In order for Gentoo Linux to properly support side-by-side installation of
different versions of Lua (including LuaJIT), please migrate this package as
to lua.eclass (for packages which should support multiple Lua implementations
at the same time, i.e. most likely Lua modules) or lua-single.eclass (for
packages which only have to support one Lua implementation at a time). For
details, consult documentation of respective eclasses as well as
already-migrated ebuilds in the tree.

Please note that since slotted dev-lang/lua is currently masked, your
migrated ebuilds should be masked as well. There is a section of package.mask,
created in September 2020, which you can use for this purpose so that it will
be easier in the future to unmask them all in one go.

Thank you in advance for your effort!
Comment 1 Larry the Git Cow gentoo-dev 2020-12-15 22:10:58 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=9b182d1f3734c2fbf2398510653f202f352faa63

commit 9b182d1f3734c2fbf2398510653f202f352faa63
Author:     Marek Szuba <marecki@gentoo.org>
AuthorDate: 2020-12-15 22:00:42 +0000
Commit:     Marek Szuba <marecki@gentoo.org>
CommitDate: 2020-12-15 22:10:50 +0000

    x11-themes/gtk-engines: migrate to lua-single.eclass
    
    Builds, tests and installs fine even when built against lua5-4 so
    support all PUC Lua versions currently in the tree.
    
    Warning - as the ebuild stands now, USE=lua IS QUIETLY IGNORED for
    non-native ABIs. The dependencies are ready for enabling it there as
    well but since the pkgconfig wrapper lua-single.eclass sets up is not
    multilib-compatible, it is necessary to patch upstream build scripts so
    that they look for the pkgconfig module "${ELUA}" rather than just "lua"
    - and for some reason running eautoreconf following the patching of
    configure.ac resulted in corrupted test Makefiles. Pushing it as-is in
    case the maintainers have got some idea on how to make this work, if not
    will probably end up patching configure directly.
    
    Bug: https://bugs.gentoo.org/752888
    Signed-off-by: Marek Szuba <marecki@gentoo.org>

 profiles/package.mask                              |  1 +
 .../gtk-engines/gtk-engines-2.20.2-r100.ebuild     | 73 ++++++++++++++++++++++
 2 files changed, 74 insertions(+)
Comment 2 Larry the Git Cow gentoo-dev 2020-12-22 17:32:32 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=205b0f865a75f324a828a7c8725f8893b76cecfb

commit 205b0f865a75f324a828a7c8725f8893b76cecfb
Author:     Marek Szuba <marecki@gentoo.org>
AuthorDate: 2020-12-22 17:20:32 +0000
Commit:     Marek Szuba <marecki@gentoo.org>
CommitDate: 2020-12-22 17:32:17 +0000

    x11-themes/gtk-engines-2.20.2-r100: make USE=lua work for non-native ABIs
    
    As predicted, I have ended up simply patching configure.
    
    Closes: https://bugs.gentoo.org/752888
    Signed-off-by: Marek Szuba <marecki@gentoo.org>

 .../gtk-engines/gtk-engines-2.20.2-r100.ebuild       | 20 +++++++-------------
 1 file changed, 7 insertions(+), 13 deletions(-)