Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 752702 - games-rpg/sumwars: migrate to lua eclasses
Summary: games-rpg/sumwars: migrate to lua eclasses
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Games
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: slotted-lua
  Show dependency tree
 
Reported: 2020-11-03 15:36 UTC by Marek Szuba
Modified: 2020-11-30 22:50 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Marek Szuba archtester gentoo-dev 2020-11-03 15:36:43 UTC
In order for Gentoo Linux to properly support side-by-side installation of
different versions of Lua (including LuaJIT), please migrate this package as
to lua.eclass (for packages which should support multiple Lua implementations
at the same time, i.e. most likely Lua modules) or lua-single.eclass (for
packages which only have to support one Lua implementation at a time). For
details, consult documentation of respective eclasses as well as
already-migrated ebuilds in the tree.

Please note that since slotted dev-lang/lua is currently masked, your
migrated ebuilds should be masked as well. There is a section of package.mask,
created in September 2020, which you can use for this purpose so that it will
be easier in the future to unmask them all in one go.

Thank you in advance for your effort!
Comment 1 Larry the Git Cow gentoo-dev 2020-11-30 22:50:59 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=4ee08e4fc5b4df91f99f96f734a00aaeb95c98d5

commit 4ee08e4fc5b4df91f99f96f734a00aaeb95c98d5
Author:     Marek Szuba <marecki@gentoo.org>
AuthorDate: 2020-11-30 22:10:35 +0000
Commit:     Marek Szuba <marecki@gentoo.org>
CommitDate: 2020-11-30 22:50:42 +0000

    games-rpg/sumwars: migrate to lua-single.eclass
    
    Set LUA_COMPAT to lua5-{1..2} because when left to its own devices,
    upstream build scripts select 5.2 at most even when newer versions of
    Lua are present in the system. Builds without errors also when
    forced to use 5.3, then again the bunded data scripts may or may not be
    compatible with that version so let's err on the side of caution.
    
    This version of sumwars does not use the CEGUI Lua-scripting module
    (CEGUILua is mentioned exactly once in the source code, in a
    commented-out #include line) and does not link against the relevant
    CEGUI library. Therefore, the value of LUA_SINGLE_TARGET used during the
    building of dev-games/cegui can safely be disregarded.
    
    Closes: https://bugs.gentoo.org/752702
    Signed-off-by: Marek Szuba <marecki@gentoo.org>

 .../files/sumwars-0.5.8-cmake_lua_version.patch    |  11 +++
 games-rpg/sumwars/sumwars-0.5.8-r100.ebuild        | 101 +++++++++++++++++++++
 profiles/package.mask                              |   1 +
 3 files changed, 113 insertions(+)