Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 752696 - games-roguelike/stone-soup: migrate to lua eclasses
Summary: games-roguelike/stone-soup: migrate to lua eclasses
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Erik Mackdanz
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: slotted-lua
  Show dependency tree
 
Reported: 2020-11-03 15:36 UTC by Marek Szuba
Modified: 2020-11-15 04:01 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Marek Szuba archtester gentoo-dev 2020-11-03 15:36:40 UTC
In order for Gentoo Linux to properly support side-by-side installation of
different versions of Lua (including LuaJIT), please migrate this package as
to lua.eclass (for packages which should support multiple Lua implementations
at the same time, i.e. most likely Lua modules) or lua-single.eclass (for
packages which only have to support one Lua implementation at a time). For
details, consult documentation of respective eclasses as well as
already-migrated ebuilds in the tree.

Please note that since slotted dev-lang/lua is currently masked, your
migrated ebuilds should be masked as well. There is a section of package.mask,
created in September 2020, which you can use for this purpose so that it will
be easier in the future to unmask them all in one go.

Thank you in advance for your effort!
Comment 1 Larry the Git Cow gentoo-dev 2020-11-14 20:56:10 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=83a9b99be74a50b93743b9cdd709d40832a67243

commit 83a9b99be74a50b93743b9cdd709d40832a67243
Author:     Erik Mackdanz <stasibear@gentoo.org>
AuthorDate: 2020-11-14 20:55:53 +0000
Commit:     Erik Mackdanz <stasibear@gentoo.org>
CommitDate: 2020-11-14 20:55:53 +0000

    games-roguelike/stone-soup: Implement lua-single eclass
    
    Signed-off-by: Erik Mackdanz <stasibear@gentoo.org>
    Closes: https://bugs.gentoo.org/752696
    Package-Manager: Portage-3.0.9, Repoman-3.0.2

 .../stone-soup/stone-soup-0.25.1-r100.ebuild       | 155 +++++++++++++++++++++
 1 file changed, 155 insertions(+)
Comment 2 Larry the Git Cow gentoo-dev 2020-11-14 23:37:26 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=addbb017b8495d986a24b1d036414c060f45749d

commit addbb017b8495d986a24b1d036414c060f45749d
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2020-11-14 23:36:14 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2020-11-14 23:37:22 +0000

    profiles/package.mask: mask lua-slotted games-roguelike/stone-soup
    
    We have to mask new lua-single ebuilds for now until the slotted
    Lua ebuilds themselves are unmasked, otherwise tree consistency
    is broken.
    
    Bug: https://bugs.gentoo.org/752696
    Signed-off-by: Sam James <sam@gentoo.org>

 profiles/package.mask | 1 +
 1 file changed, 1 insertion(+)
Comment 3 Erik Mackdanz gentoo-dev 2020-11-15 03:51:29 UTC
Thanks.  I ignored the QA notification because I knew I committed the mask, but 'repoman commit' apparently removed it from the commit.
Comment 4 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2020-11-15 04:01:05 UTC
(In reply to Erik Mackdanz from comment #3)
> Thanks.  I ignored the QA notification because I knew I committed the mask,
> but 'repoman commit' apparently removed it from the commit.

No problem. Yeah, repoman won't handle anything in profiles/. I think it unstages anything not in the current working directory, but not sure.

I know I've had fun with interactions between it and git add -p before...

(Note: If you pushed all at once including a profile change, the CI failure should be a warning sign because it wouldn't have split up the changes).