Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 751850 - net-misc/dahdi-tools-3.1.0 uses -Werror for build
Summary: net-misc/dahdi-tools-3.1.0 uses -Werror for build
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Jaco Kroon
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks: werror
  Show dependency tree
 
Reported: 2020-10-30 08:25 UTC by Agostino Sarubbo
Modified: 2021-01-24 08:09 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2020-10-30 08:25:25 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: net-misc/dahdi-tools-3.1.0 uses -Werror for build.
Discovered on: amd64 (internal ref: tinderbox)

-Werror is not recommended for releases and should always be disabled when encountered in build-logs, because there are numerous cases where this breaks without purpose.
See also: https://devmanual.gentoo.org/ebuild-writing/common-mistakes/index.html

NOTE: If you want to change the summary, to avoid auto-filed duplicates, please at least keep the word '-Werror'
Comment 1 Larry the Git Cow gentoo-dev 2021-01-24 08:09:14 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=835fce99896dd07c86f96193a592108cf846f68b

commit 835fce99896dd07c86f96193a592108cf846f68b
Author:     Jaco Kroon <jaco@uls.co.za>
AuthorDate: 2021-01-08 14:59:51 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2021-01-24 08:09:05 +0000

    net-misc/dahdi-tools: general bug fixes.
    
    Build should not build with -Werror
    Build should not install .a or .la files.
    
    Signed-off-by: Jaco Kroon <jaco@uls.co.za>
    Closes: https://bugs.gentoo.org/751853
    Closes: https://bugs.gentoo.org/751850
    Closes: https://github.com/gentoo/gentoo/pull/18991
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 net-misc/dahdi-tools/dahdi-tools-3.1.0-r1.ebuild | 64 ++++++++++++++++++++++++
 1 file changed, 64 insertions(+)