Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 750512 - games-strategy/s25rttr-0.9.0_pre20200723-r100 uses -Werror for build
Summary: games-strategy/s25rttr-0.9.0_pre20200723-r100 uses -Werror for build
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Games
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: werror
  Show dependency tree
 
Reported: 2020-10-21 05:59 UTC by Agostino Sarubbo
Modified: 2021-09-11 08:38 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2020-10-21 05:59:34 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: games-strategy/s25rttr-0.9.0_pre20200723 uses -Werror for build.
Discovered on: amd64 (internal ref: tinderbox)

-Werror is not recommended for releases and should always be disabled when encountered in build-logs, because there are numerous cases where this breaks without purpose.
See also: https://devmanual.gentoo.org/ebuild-writing/common-mistakes/index.html

NOTE: If you want to change the summary, to avoid auto-filed duplicates, please at least keep the word '-Werror'
Comment 1 Larry the Git Cow gentoo-dev 2021-03-26 19:46:00 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=47e15fc2f692d160bef097e069e41254ef3257c8

commit 47e15fc2f692d160bef097e069e41254ef3257c8
Author:     Conrad Kostecki <conikost@gentoo.org>
AuthorDate: 2021-03-26 18:45:17 +0000
Commit:     Conrad Kostecki <conikost@gentoo.org>
CommitDate: 2021-03-26 19:45:15 +0000

    games-strategy/s25rttr: drop old version
    
    Dropping old version, which does not support slotted lua.
    
    Closes: https://bugs.gentoo.org/750512
    Package-Manager: Portage-3.0.17, Repoman-3.0.2
    Signed-off-by: Conrad Kostecki <conikost@gentoo.org>

 .../s25rttr/s25rttr-0.9.0_pre20200723.ebuild       | 125 ---------------------
 1 file changed, 125 deletions(-)
Comment 2 James Le Cuirot gentoo-dev 2021-03-26 20:54:06 UTC
Okay, I wasn't sure about openra but the Lua change here definitely doesn't fix the -Werror issue.
Comment 3 Conrad Kostecki gentoo-dev 2021-03-26 20:55:10 UTC
(In reply to James Le Cuirot from comment #2)
> Okay, I wasn't sure about openra but the Lua change here definitely doesn't
> fix the -Werror issue.

Okay, changed version here.
Comment 4 Larry the Git Cow gentoo-dev 2021-09-11 08:38:22 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=0b52435579ce5e9941a9f2a6102674bb7ce1b0ad

commit 0b52435579ce5e9941a9f2a6102674bb7ce1b0ad
Author:     James Le Cuirot <chewi@gentoo.org>
AuthorDate: 2021-09-11 08:34:16 +0000
Commit:     James Le Cuirot <chewi@gentoo.org>
CommitDate: 2021-09-11 08:34:16 +0000

    games-strategy/s25rttr: Bump to 0.9.1, EAPI 8
    
    Closes: https://bugs.gentoo.org/750512
    Closes: https://bugs.gentoo.org/778587
    Signed-off-by: James Le Cuirot <chewi@gentoo.org>

 games-strategy/s25rttr/Manifest                    |   1 +
 .../s25rttr/files/s25rttr-0.9.1-cxx-std.patch      |  30 ++++++
 .../files/s25rttr-0.9.1-libsamplerate.patch        |  37 +++++++
 games-strategy/s25rttr/s25rttr-0.9.1.ebuild        | 114 +++++++++++++++++++++
 4 files changed, 182 insertions(+)