Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 744841 - net-misc/spice-gtk-0.38 uses -Werror for build
Summary: net-misc/spice-gtk-0.38 uses -Werror for build
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Virtualization Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: werror
  Show dependency tree
 
Reported: 2020-09-26 15:35 UTC by Agostino Sarubbo
Modified: 2020-12-30 15:32 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2020-09-26 15:35:03 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: net-misc/spice-gtk-0.38 uses -Werror for build.
Discovered on: amd64 (internal ref: tinderbox)

-Werror is not recommended for releases and should always be disabled when encountered in build-logs, because there are numerous cases where this breaks without purpose.
See also: https://devmanual.gentoo.org/ebuild-writing/common-mistakes/index.html

NOTE: If you want to change the summary, to avoid auto-filed duplicates, please at least keep the word '-Werror'
Comment 1 Larry the Git Cow gentoo-dev 2020-12-30 15:32:43 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=93fd19e645c7bc2484cac4c24bb36e244a13ee01

commit 93fd19e645c7bc2484cac4c24bb36e244a13ee01
Author:     Ben Kohler <bkohler@gentoo.org>
AuthorDate: 2020-12-30 15:32:13 +0000
Commit:     Ben Kohler <bkohler@gentoo.org>
CommitDate: 2020-12-30 15:32:36 +0000

    net-misc/spice-gtk: handle python deps & remove -Werror
    
    Simple sed to remove Werror for now, it is already removed in upstream
    git so this fix can be removed for next release.
    
    Closes: https://bugs.gentoo.org/744841
    Closes: https://bugs.gentoo.org/718556
    Package-Manager: Portage-3.0.12, Repoman-3.0.2
    Signed-off-by: Ben Kohler <bkohler@gentoo.org>

 net-misc/spice-gtk/spice-gtk-0.38-r1.ebuild | 126 ++++++++++++++++++++++++++++
 net-misc/spice-gtk/spice-gtk-9999.ebuild    |  16 +++-
 2 files changed, 141 insertions(+), 1 deletion(-)