Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 744616 - media-libs/libavif-0.8.1 uses -Werror for build
Summary: media-libs/libavif-0.8.1 uses -Werror for build
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Joonas Niilola
URL: https://github.com/AOMediaCodec/libav...
Whiteboard:
Keywords:
Depends on:
Blocks: werror
  Show dependency tree
 
Reported: 2020-09-25 10:52 UTC by Agostino Sarubbo
Modified: 2021-03-05 05:38 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2020-09-25 10:52:05 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: media-libs/libavif-0.8.1 uses -Werror for build.
Discovered on: amd64 (internal ref: ci)

-Werror is not recommended for releases and should always be disabled when encountered in build-logs, because there are numerous cases where this breaks without purpose.
See also: https://devmanual.gentoo.org/ebuild-writing/common-mistakes/index.html

NOTE: If you want to change the summary, to avoid auto-filed duplicates, please at least keep the word '-Werror'
Comment 1 Joonas Niilola gentoo-dev 2020-09-25 13:29:01 UTC
https://github.com/AOMediaCodec/libavif/commit/b177cc1e2e8145a2b51c59f33bfb15c25ecc915c this is fixed upstream, I may want to wait for a next release unless it starts to cause more troubles.
Comment 2 Daniel Novomeský 2020-10-04 10:30:30 UTC
Let's use the option to disable -Werror (-DAVIF_ENABLE_WERROR=OFF) for future releases (when they will be available),

but I would leave the live(9999) ebuild as is. If anything pops up there, upstream fixes that ASAP.

libavif-0.8.1 will be obsolete after future release, there are few new breaking changes in libavif API in master.
Comment 3 SpanKY gentoo-dev 2021-03-05 02:27:24 UTC
it's fixed in 0.8.4 in the tree now which is stable on arches
Comment 4 Larry the Git Cow gentoo-dev 2021-03-05 05:38:11 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=8aeef79b128bf3f69e6b62690d089ac249d3a5f9

commit 8aeef79b128bf3f69e6b62690d089ac249d3a5f9
Author:     Joonas Niilola <juippis@gentoo.org>
AuthorDate: 2021-03-05 05:37:02 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2021-03-05 05:37:02 +0000

    dev-libs/efl: depend libavif version restriction
    
     - newer versions don't actually work, but the USE flag is masked for now.
    
    Bug: https://bugs.gentoo.org/744616
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 dev-libs/efl/efl-1.25.1-r10.ebuild | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=2c97f901d62da20b8b33bc122349c0ede428d4e6

commit 2c97f901d62da20b8b33bc122349c0ede428d4e6
Author:     Joonas Niilola <juippis@gentoo.org>
AuthorDate: 2021-03-05 05:35:21 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2021-03-05 05:35:21 +0000

    media-libs/libavif: remove old 0.8.1
    
    Bug: https://bugs.gentoo.org/744616
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 media-libs/libavif/Manifest             |  1 -
 media-libs/libavif/libavif-0.8.1.ebuild | 73 ---------------------------------
 2 files changed, 74 deletions(-)