Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 742935 - dev-java/javatoolkit-0.6.3: class-version-verify.py should ignore module-info.class
Summary: dev-java/javatoolkit-0.6.3: class-version-verify.py should ignore module-info...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Java team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-09-16 11:36 UTC by Miroslav Šulc
Modified: 2021-06-19 17:35 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Miroslav Šulc gentoo-dev 2020-09-16 11:36:18 UTC
imo class-version-verify.py should ignore module-info.class (when target is 1.9 or lower) as this is a feature introduced in java 9, but some packages (one known case atm is www-servers/tomcat-9.0.38), though built with target 1.8, include also module-info.class which can be at least of version 1.9. this file might add some features that are useful or needed for running the app with jdk/jre 9+ but are ignored in java 1.8-.

imo the correct fix might be to just exclude module-info.class from the verification, maybe just in case the target for the package is 1.8 or lower (as for java 9+ the file is valid). tomcat is the first package where i came across this issue so this is atm the only example in the tree.
Comment 1 Larry the Git Cow gentoo-dev 2021-06-19 17:35:56 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/proj/javatoolkit.git/commit/?id=09739b1ae090fc1944a1267ed4c40cf58ce7d049

commit 09739b1ae090fc1944a1267ed4c40cf58ce7d049
Author:     Miroslav Šulc <fordfrog@gentoo.org>
AuthorDate: 2021-06-19 17:34:56 +0000
Commit:     Miroslav Šulc <fordfrog@gentoo.org>
CommitDate: 2021-06-19 17:35:25 +0000

    fixed handling of module-info.class
    
    Closes: https://bugs.gentoo.org/742935
    Signed-off-by: Miroslav Šulc <fordfrog@gentoo.org>

 src/py/class-version-verify.py | 8 +++++---
 src/py/javatoolkit/cvv.py      | 5 ++++-
 2 files changed, 9 insertions(+), 4 deletions(-)