Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 740164 - media-libs/vidstab-1.1.0-r2 fails to compile with sys-devel/clang and FEATURES="test"
Summary: media-libs/vidstab-1.1.0-r2 fails to compile with sys-devel/clang and FEATURE...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Kalin KOZHUHAROV
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2020-09-03 06:43 UTC by Agostino Sarubbo
Modified: 2024-01-16 18:44 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,40.01 KB, text/plain)
2020-09-03 06:43 UTC, Agostino Sarubbo
Details
1-CMakeOutput.log (1-CMakeOutput.log,32.57 KB, text/plain)
2020-09-03 06:43 UTC, Agostino Sarubbo
Details
2-CMakeOutput.log (2-CMakeOutput.log,32.63 KB, text/plain)
2020-09-03 06:43 UTC, Agostino Sarubbo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2020-09-03 06:43:20 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: media-libs/vidstab-1.1.0-r2 fails to compile.
Discovered on: amd64 (internal ref: tinderbox)

NOTE:
This machine uses a clang/LLVM toolchain.
If you think that this issue is strictly related to clang/LLVM please block bug 408963. If you think that this issue is strictly related to the LLD linker, please block bug 731004.
This machine uses also GLIBC-2.32. If you think that this issue is strictly related to GLIBC please block bug 736174.
Comment 1 Agostino Sarubbo gentoo-dev 2020-09-03 06:43:22 UTC
Created attachment 658034 [details]
build.log

build log and emerge --info
Comment 2 Agostino Sarubbo gentoo-dev 2020-09-03 06:43:25 UTC
Created attachment 658036 [details]
1-CMakeOutput.log

1-CMakeOutput.log
Comment 3 Agostino Sarubbo gentoo-dev 2020-09-03 06:43:27 UTC
Created attachment 658038 [details]
2-CMakeOutput.log

2-CMakeOutput.log
Comment 4 Kalin KOZHUHAROV 2020-09-23 21:32:05 UTC
I finally reproduced that on my machine....

bug:
 CC=clang CXX=clang++ FEATURES="test" USE="openmp" emerge -vt media-libs/vidstab

work:
 CC=gcc CXX=g++ FEATURES="-test" USE="openmp" emerge -vt media-libs/vidstab
 CC=gcc CXX=g++ FEATURES="test" USE="openmp" emerge -vt media-libs/vidstab
 CC=clang CXX=clang++ FEATURES="-test" USE="openmp" emerge -vt media-libs/vidstab
 CC=clang CXX=clang++ CFLAGS=-fopenmp FEATURES="test" USE="openmp" emerge -vt media-libs/vidstab
 CC=clang CXX=clang++ CFLAGS=-fopenmp FEATURES="-test" USE="openmp" emerge -vt media-libs/vidstab


Summary: when using sys-devel/clang-10.0.0 we need to add CFLAGS=-fopenmp for USE="openmp" FEATURES="test" case. Any other combination works.

Tracked upstream as https://github.com/georgmartius/vid.stab/issues/65
There is a rework and a PR https://github.com/georgmartius/vid.stab/pull/94 around OpenMP, I'll rather wait for it.

As a workaround in the meantime, for clang compile with FEATURE="-test" ( or with CFLAGS=-fopenmp if you insist on FEATURE="test").
Comment 5 Kalin KOZHUHAROV 2020-09-23 21:36:38 UTC
Sorry, the last sentence should have read:

As a workaround in the meantime, for compilation with sys-devel/clang do set FEATURES="-test" (or do add CFLAGS=-fopenmp).
Comment 6 Kalin KOZHUHAROV 2022-07-02 21:55:01 UTC
Looked at his today, not really much movement upstream.
Comment 7 Larry the Git Cow gentoo-dev 2024-01-15 18:13:28 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=6981b4106613e758228eafcacd42d8cedf9b379c

commit 6981b4106613e758228eafcacd42d8cedf9b379c
Author:     Kalin KOZHUHAROV <me.kalin@gmail.com>
AuthorDate: 2024-01-15 16:42:31 +0000
Commit:     Craig Andrews <candrews@gentoo.org>
CommitDate: 2024-01-15 18:13:25 +0000

    media-libs/vidstab: -fopenmp when testing
    
    Closes: https://bugs.gentoo.org/740164
    Reported-by: Kalin KOZHUHAROV <kalin@thinrope.net>
    Signed-off-by: Kalin KOZHUHAROV <kalin@thinrope.net>
    Bug: https://bugs.gentoo.org/836290
    Closes: https://github.com/gentoo/gentoo/pull/34821
    Signed-off-by: Craig Andrews <candrews@gentoo.org>

 media-libs/vidstab/vidstab-1.1.1.ebuild | 5 +++--
 media-libs/vidstab/vidstab-9999.ebuild  | 5 +++--
 2 files changed, 6 insertions(+), 4 deletions(-)
Comment 8 Larry the Git Cow gentoo-dev 2024-01-16 18:44:41 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ecceb7c836c47fc1d75de1a1f9c5862bb635eecd

commit ecceb7c836c47fc1d75de1a1f9c5862bb635eecd
Author:     Kalin KOZHUHAROV <me.kalin@gmail.com>
AuthorDate: 2024-01-16 08:03:49 +0000
Commit:     Craig Andrews <candrews@gentoo.org>
CommitDate: 2024-01-16 18:44:33 +0000

    media-libs/vidstab: remove erroneous flag-o-matic USE flag
    
    Closes: https://github.com/gentoo/gentoo/pull/34827
    Bug: https://bugs.gentoo.org/740164
    Reported-by: Kalin KOZHUHAROV <kalin@thinrope.net>
    Signed-off-by: Kalin KOZHUHAROV <kalin@thinrope.net>
    Signed-off-by: Craig Andrews <candrews@gentoo.org>

 media-libs/vidstab/vidstab-1.1.1.ebuild | 2 +-
 media-libs/vidstab/vidstab-9999.ebuild  | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=a50969954702c4d7149a955a5add71e930477f7f

commit a50969954702c4d7149a955a5add71e930477f7f
Author:     Kalin KOZHUHAROV <me.kalin@gmail.com>
AuthorDate: 2024-01-15 16:42:31 +0000
Commit:     Craig Andrews <candrews@gentoo.org>
CommitDate: 2024-01-16 18:44:33 +0000

    media-libs/vidstab: fixing BGO #740164
    
    Switching to use flag-o-matic per devmanual and fixing QA issue
    properly.
    
    Bug: https://bugs.gentoo.org/740164
    Reported-by: Kalin KOZHUHAROV <kalin@thinrope.net>
    Signed-off-by: Kalin KOZHUHAROV <kalin@thinrope.net>
    Related: https://bugs.gentoo.org/836290
    Closes: https://github.com/gentoo/gentoo/pull/34827
    Signed-off-by: Craig Andrews <candrews@gentoo.org>

 media-libs/vidstab/vidstab-1.1.1.ebuild | 2 +-
 media-libs/vidstab/vidstab-9999.ebuild  | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)