https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/ Issue: x11-themes/light-themes-19.04 installs files with broken symlink. Discovered on: amd64 (internal ref: ci)
Created attachment 654093 [details] build.log build log and emerge --info
Hi Ago, did you have an earlier version of the package installed? When I do a clean install I get no errors and no dead symlinks. What I get out of the install is this: # qlist light-themes | grep 'assets/\?$' | xargs ls --color=always -ld \ | awk '{print $(NF-2), $(NF-1), $(NF)}' | sort /usr/share/themes/Radiance/gtk-3.0/assets -> ../../Ambiance/gtk-3.0/assets /usr/share/themes/Radiance/gtk-3.20/assets -> ../gtk-3.0/assets /usr/share/themes/Ambiance/gtk-3.20/assets -> ../gtk-3.0/assets # ls -1 /usr/share/themes/Ambiance/gtk-3.0/assets/* | wc -l 541 So I cannot reproduce the issue. Any ideas?
Same here. * QA Notice: Symbolic link /usr/share/themes/Radiance/gtk-3.20/assets points to /usr/share/themes/Radiance/gtk-3.0/assets which does not exist. >>> /usr/share/themes/Radiance/gtk-3.20/assets -> ../gtk-3.0/assets * QA Notice: Symbolic link /usr/share/themes/Ambiance/gtk-3.20/assets points to /usr/share/themes/Ambiance/gtk-3.0/assets which does not exist. >>> /usr/share/themes/Ambiance/gtk-3.20/assets -> ../gtk-3.0/assets PS: Please check if IUSE=gtk3 optional RDEPEND ain't bogus. See also Fedora change in 2015: https://src.fedoraproject.org/rpms/light-themes/c/34781f6bd14d3c81dd3f6a924744b7978ca24398?branch=master
The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d1ffab23257eddf1a82df327d8048471e85d9f2a commit d1ffab23257eddf1a82df327d8048471e85d9f2a Author: Sebastian Pipping <sping@gentoo.org> AuthorDate: 2021-01-25 17:10:10 +0000 Commit: Sebastian Pipping <sping@gentoo.org> CommitDate: 2021-01-25 17:18:10 +0000 x11-themes/light-themes: Drop unico rdepend from 19.04 Bug: https://bugs.gentoo.org/736683 Signed-off-by: Sebastian Pipping <sping@gentoo.org> Package-Manager: Portage-3.0.14, Repoman-3.0.2 x11-themes/light-themes/light-themes-19.04.ebuild | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
(In reply to Andreas Sturmlechner from comment #3) > PS: Please check if IUSE=gtk3 optional RDEPEND ain't bogus. > See also Fedora change in 2015: > https://src.fedoraproject.org/rpms/light-themes/c/ > 34781f6bd14d3c81dd3f6a924744b7978ca24398?branch=master Following you here I have dropped unico from rdepend now because the word unicode doesn't exist in any of the files. I'm still wondering what engine the GTK 3 part is using then though: Didn't find any mention of engine at all. (In reply to Andreas Sturmlechner from comment #3) > Same here. > > * QA Notice: Symbolic link /usr/share/themes/Radiance/gtk-3.20/assets > points to /usr/share/themes/Radiance/gtk-3.0/assets which does not exist. > >>> /usr/share/themes/Radiance/gtk-3.20/assets -> ../gtk-3.0/assets > * QA Notice: Symbolic link /usr/share/themes/Ambiance/gtk-3.20/assets > points to /usr/share/themes/Ambiance/gtk-3.0/assets which does not exist. > >>> /usr/share/themes/Ambiance/gtk-3.20/assets -> ../gtk-3.0/assets Still cannot reproduce so I'm putting it into need-info now. Please feel free to take over if you like.
Bold move 1 day after my message. $ ls -1 /usr/share/themes/Radiance/ gtk-2.0 gtk-3.20 index.theme metacity-1 unity $ ls -1 /usr/share/themes/Ambiance gtk-2.0 gtk-3.20 index.theme metacity-1 unity
(In reply to Andreas Sturmlechner from comment #6) > Bold move 1 day after my message. I didn't pay close attention to the date, I (mis-)remembered this to be older. I don't have any intentions of being bold with you. I tried reproducing it more than once and without success. I am happy about any help I can get from you actually.
(In reply to Andreas Sturmlechner from comment #6) > $ ls -1 /usr/share/themes/Radiance/ > gtk-2.0 > gtk-3.20 > index.theme > metacity-1 > unity > > $ ls -1 /usr/share/themes/Ambiance > gtk-2.0 > gtk-3.20 > index.theme > metacity-1 > unity Please help me see what that output is supposed to make me see, I don't see it. Thanks!
It is actually not that difficult. # emerge --depclean light-themes # USE=gtk3 emerge -1 light-themes Not surprising when the ebuild does the following in src_install(): > use gtk3 || { > rm -R "${D}"/usr/share/themes/*/gtk-3.0 || die > } ...leaving gtk-3.20 behind. I'm questioning the sanity of a default-off gtk3 flag in 2021 anyway; if anything, you could replace it with a (default-enabled) gtk2 flag.
(In reply to Andreas Sturmlechner from comment #9) > # USE=gtk3 emerge -1 light-themes Sorry, should have been USE=-gtk3 of course.
The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=0fe1f7ccc130fb407458970e4cc8ff4fd407c47f commit 0fe1f7ccc130fb407458970e4cc8ff4fd407c47f Author: Sebastian Pipping <sping@gentoo.org> AuthorDate: 2021-01-25 22:25:28 +0000 Commit: Sebastian Pipping <sping@gentoo.org> CommitDate: 2021-01-25 22:27:40 +0000 x11-themes/light-themes: Fix USE=-gtk3 Bug: https://bugs.gentoo.org/736683 Signed-off-by: Sebastian Pipping <sping@gentoo.org> Package-Manager: Portage-3.0.14, Repoman-3.0.2 x11-themes/light-themes/light-themes-19.04.ebuild | 2 +- x11-themes/light-themes/light-themes-20.10.ebuild | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
(In reply to Andreas Sturmlechner from comment #9) > Not surprising when the ebuild does the following in src_install(): > > > use gtk3 || { > > rm -R "${D}"/usr/share/themes/*/gtk-3.0 || die > > } > > ...leaving gtk-3.20 behind. Nice, thank you! > I'm questioning the sanity of a default-off gtk3 > flag in 2021 anyway; if anything, you could replace it with a > (default-enabled) gtk2 flag. I think our options are: a) keep default-off gtk3 as is b) turn gtk3 to default-on c) drop gtk3 and always install those files d) turn default-off gtk3 into default-on gtk2 and have it control gtk2 files e) turn default-off gtk3 into default-off gtk2 and have it control gtk2 files f) turn default-off gtk3 into default-on gtk2 and have it control gtk3 files g) turn default-off gtk3 into default-off gtk2 and have it control gtk3 files If you're suggesting (f) — (f) and (g) are my least favourite, followed by (d) and (e). If there's even something to fix here, can we agree on one of (a), (b) or (c)? I can then apply that or you do, as you like.
The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=21779a470e90990b86631159120da3db9ec1c8b8 commit 21779a470e90990b86631159120da3db9ec1c8b8 Author: Sebastian Pipping <sping@gentoo.org> AuthorDate: 2021-01-25 22:43:58 +0000 Commit: Sebastian Pipping <sping@gentoo.org> CommitDate: 2021-01-25 22:43:58 +0000 x11-themes/light-themes: Go further with fixing USE=-gtk3 Bug: https://bugs.gentoo.org/736683 Signed-off-by: Sebastian Pipping <sping@gentoo.org> Package-Manager: Portage-3.0.14, Repoman-3.0.2 ....04_p20170406-r1.ebuild => light-themes-17.04_p20170406-r2.ebuild} | 4 ++-- .../{light-themes-19.04.ebuild => light-themes-19.04-r1.ebuild} | 0 .../{light-themes-20.10.ebuild => light-themes-20.10-r1.ebuild} | 0 3 files changed, 2 insertions(+), 2 deletions(-)
(In reply to Sebastian Pipping from comment #12) > If you're suggesting (f) — (f) and (g) are my least favourite Well, obviously none of those. My suggestion would have been d) since you want your theme to be working for the majority by default, and gtk+:2 is the one going away (in the very) long-term. However, since there are no dependencies gained or lost, you may also choose to do c).
(In reply to Andreas Sturmlechner from comment #14) > (In reply to Sebastian Pipping from comment #12) > > If you're suggesting (f) — (f) and (g) are my least favourite > Well, obviously none of those. My suggestion would have been d) since you > want your theme to be working for the majority by default, and gtk+:2 is the > one going away (in the very) long-term. However, since there are no > dependencies gained or lost, you may also choose to do c). I'll focus on the part that we are in consent about: I'll apply (c) and drop use flag "gtk3" and always install those files. Give me a minute.
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=da7977beb3852842df4cddb485f2c76cbb64c41b commit da7977beb3852842df4cddb485f2c76cbb64c41b Author: Sebastian Pipping <sping@gentoo.org> AuthorDate: 2021-01-25 23:02:32 +0000 Commit: Sebastian Pipping <sping@gentoo.org> CommitDate: 2021-01-25 23:02:32 +0000 x11-themes/light-themes: Drop flag gtk3 for >=19.04 Closes: https://bugs.gentoo.org/736683 Signed-off-by: Sebastian Pipping <sping@gentoo.org> Package-Manager: Portage-3.0.14, Repoman-3.0.2 .../{light-themes-19.04-r1.ebuild => light-themes-19.04-r2.ebuild} | 6 +----- .../{light-themes-20.10-r1.ebuild => light-themes-20.10-r2.ebuild} | 6 +----- 2 files changed, 2 insertions(+), 10 deletions(-)
Are we read to put CC-ARCHES back into bug #766881?
-read +ready
