Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 73484 - gentoo-dev-sources patches for amd64 compaq R3000 series and alps touchpad driver
Summary: gentoo-dev-sources patches for amd64 compaq R3000 series and alps touchpad dr...
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Unspecified (show other bugs)
Hardware: AMD64 Linux
: High enhancement (vote)
Assignee: Gentoo Kernel Bug Wranglers and Kernel Maintainers
Keywords: Inclusion
Depends on:
Reported: 2004-12-05 14:38 UTC by Mike Doty (RETIRED)
Modified: 2004-12-22 08:21 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---

cardbus patch (cardbus_pci_probe.patch,1.17 KB, patch)
2004-12-05 14:39 UTC, Mike Doty (RETIRED)
Details | Diff
alps patch (alps.patch,17.09 KB, patch)
2004-12-05 14:40 UTC, Mike Doty (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Doty (RETIRED) gentoo-dev 2004-12-05 14:38:14 UTC
amd64 user Brad House <brad [at] mainstreetsoftworks [dot] com> reports:

Cardbus patch for amd64 compaq R3000 series and alps touchpad driver

Cardbus patch from:

alps patch from standard synaptics source tarball, just named
alps.patch, there's also a README.alps in that tarball.

Reproducible: Always
Steps to Reproduce:
Comment 1 Mike Doty (RETIRED) gentoo-dev 2004-12-05 14:39:40 UTC
Created attachment 45344 [details, diff]
cardbus patch

cardbus patch
Comment 2 Mike Doty (RETIRED) gentoo-dev 2004-12-05 14:40:59 UTC
Created attachment 45345 [details, diff]
alps patch

alps patch
Comment 3 Daniel Drake (RETIRED) gentoo-dev 2004-12-05 16:44:19 UTC
Greg, how do these look to you? Neither are in 2.6.10 tree
Comment 4 Greg Kroah-Hartman (RETIRED) gentoo-dev 2004-12-06 09:18:56 UTC
Ick, I say no to both of them.

No to the cardbus patch, as it touch core pci code that all arches run
(why is this patch needed?  Why isn't it submitted to the main people?)

And no to the alps patch, as it too hasn't been submitted to, and we
don't want to have to maintain it in our tree on our own.

Please get the author to submit these patches upstream, and then Gentoo will pick
them up.
Comment 5 Mike Doty (RETIRED) gentoo-dev 2004-12-06 18:44:10 UTC
What do we tell people who have R3000 laptops?  As I understand it, these patches are needed for a working system.  Am I to tell them that they need to manualy patch their kernel?  Many users wouldn't feel very comfortable with that.

I don't understand your "why isn't this sent to" comment.  Do all patches need to be applied upstream before we use them?  please advise.
Comment 6 Greg Kroah-Hartman (RETIRED) gentoo-dev 2004-12-06 19:03:25 UTC
How many users have R3000 laptops?

How many users have been hit by the pci core patch?

How can you verify that this pci core patch does not mess up anyone else (hint, I think it will...)

And yes, it is our policy that patches are submitted upstream before we apply them.   It has been that way for quite some time.  It reduces the effort we (the kernel team) have to spend resolving patches, it helps all users of Linux by 
being good members of the community, and it ensures that we get support from
the upstream developers, which we need.
Comment 7 Larry Sanderson 2004-12-22 05:08:11 UTC
I have an HP zv5000z (same as the R3000), and these patches came in handy for me... can't really speak for others.  I can't imagine anyone having a problem with the alps patch... it's basically a clone of the synaptics patch already accepted into the kernel.

Comment 8 Greg Kroah-Hartman (RETIRED) gentoo-dev 2004-12-22 08:21:40 UTC
The alps patch isn't bad, but it should be in upstream first.