Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 733262 - dev-python/aiohttp-3.6.2: fails TestCookieJarSafe.test_expires test on x86
Summary: dev-python/aiohttp-3.6.2: fails TestCookieJarSafe.test_expires test on x86
Status: CONFIRMED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: x86 Linux
: Normal normal (vote)
Assignee: Zac Medico
URL: https://github.com/aio-libs/aiohttp/i...
Whiteboard:
Keywords: TESTFAILURE
Depends on:
Blocks:
 
Reported: 2020-07-20 02:46 UTC by Sam James
Modified: 2020-10-08 16:40 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (file_733262.txt,468.76 KB, text/plain)
2020-07-20 02:46 UTC, Sam James
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Sam James archtester Gentoo Infrastructure gentoo-dev Security 2020-07-20 02:46:49 UTC
Created attachment 649924 [details]
build.log

====================================================================================== FAILURES =======================================================================================
___________________________________________________________________________ TestCookieJarSafe.test_expires ____________________________________________________________________________

self = <test_cookiejar.TestCookieJarSafe testMethod=test_expires>

    def test_expires(self) -> None:
        ts_before = datetime.datetime(
            1975, 1, 1, tzinfo=datetime.timezone.utc).timestamp()
    
        ts_after = datetime.datetime(
            2115, 1, 1, tzinfo=datetime.timezone.utc).timestamp()
    
        cookies_sent = self.timed_request(
            "http://expirestest.com/", ts_before, ts_before)
    
        self.assertEqual(set(cookies_sent.keys()), {
            "shared-cookie",
            "expires-cookie"
        })
    
        cookies_sent = self.timed_request(
>           "http://expirestest.com/", ts_before, ts_after)

tests/test_cookiejar.py:590: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

self = <test_cookiejar.TestCookieJarSafe testMethod=test_expires>, url = 'http://expirestest.com/', update_time = datetime.datetime(1975, 1, 1, 0, 0), send_time = 4575744000.0

    def timed_request(self, url, update_time, send_time):
        if isinstance(update_time, int):
            update_time = datetime.timedelta(seconds=update_time)
        elif isinstance(update_time, float):
            update_time = datetime.datetime.fromtimestamp(update_time)
        if isinstance(send_time, int):
            send_time = datetime.timedelta(seconds=send_time)
        elif isinstance(send_time, float):
>           send_time = datetime.datetime.fromtimestamp(send_time)
E           OverflowError: timestamp out of range for platform time_t

tests/test_cookiejar.py:383: OverflowError

----
Portage 2.3.99 (python 3.7.8-final-0, default/linux/x86/17.0, gcc-9.3.0, glibc-2.30-r8, 4.19.97-gentoo-x86_64 i686)
=================================================================
System uname: Linux-4.19.97-gentoo-x86_64-i686-Intel-R-_Core-TM-_i9-9880H_CPU_@_2.30GHz-with-gentoo-2.6
KiB Mem:     6180316 total,   1861228 free
KiB Swap:          0 total,         0 free
Timestamp of repository gentoo: Mon, 20 Jul 2020 01:35:24 +0000
sh bash 5.0_p17
ld GNU ld (Gentoo 2.33.1 p2) 2.33.1
app-shells/bash:          5.0_p17::gentoo
dev-java/java-config:     2.3.1::gentoo
dev-lang/perl:            5.30.3::gentoo
dev-lang/python:          2.7.18-r1::gentoo, 3.7.8-r2::gentoo, 3.8.2-r2::gentoo
dev-util/cmake:           3.16.5::gentoo
sys-apps/baselayout:      2.6-r1::gentoo
sys-apps/openrc:          0.42.1::gentoo
sys-apps/sandbox:         2.18::gentoo
sys-devel/autoconf:       2.13-r1::gentoo, 2.69-r4::gentoo
sys-devel/automake:       1.11.6-r3::gentoo, 1.13.4-r2::gentoo, 1.16.1-r1::gentoo
sys-devel/binutils:       2.33.1-r1::gentoo
sys-devel/gcc:            9.3.0::gentoo
sys-devel/gcc-config:     2.3::gentoo
sys-devel/libtool:        2.4.6-r6::gentoo
sys-devel/make:           4.2.1-r4::gentoo
sys-kernel/linux-headers: 5.4-r1::gentoo (virtual/os-headers)
sys-libs/glibc:           2.30-r8::gentoo
Repositories:

gentoo
    location: /bound/portage
    sync-type: rsync
    sync-uri: rsync://rsync.gentoo.org/gentoo-portage
    priority: -1000
    sync-rsync-extra-opts:
    sync-rsync-verify-max-age: 24
    sync-rsync-verify-metamanifest: yes
    sync-rsync-verify-jobs: 1

ACCEPT_KEYWORDS="x86"
ACCEPT_LICENSE="@FREE"
CBUILD="i686-pc-linux-gnu"
CFLAGS="-O2 -march=i686 -pipe -fdiagnostics-show-option -frecord-gcc-switches"
CHOST="i686-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/lib/fax /usr/share/gnupg/qualified.txt /var/spool/fax/etc"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c /var/spool/fax/etc/xferfaxlog"
CXXFLAGS="-O2 -march=i686 -pipe"
DISTDIR="/bound/distfiles"
EMERGE_DEFAULT_OPTS="--keep-going --jobs=3"
ENV_UNSET="DBUS_SESSION_BUS_ADDRESS DISPLAY GOBIN GOPATH PERL5LIB PERL5OPT PERLPREFIX PERL_CORE PERL_MB_OPT PERL_MM_OPT XAUTHORITY XDG_CACHE_HOME XDG_CONFIG_HOME XDG_DATA_HOME XDG_RUNTIME_DIR"
FCFLAGS="-O2 -march=i686 -pipe"
FEATURES="assume-digests binpkg-docompress binpkg-dostrip binpkg-logs cgroup compress-build-logs config-protect-if-modified distlocks ebuild-locks fixlafiles ipc-sandbox merge-sync mount-sandbox multilib-strict network-sandbox news nodoc noinfo noman parallel-fetch parallel-install pid-sandbox preserve-libs protect-owned qa-unresolved-soname-deps sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr"
FFLAGS="-O2 -march=i686 -pipe"
GENTOO_MIRRORS="http://distfiles.gentoo.org"
INSTALL_MASK="/usr/share/doc/*/*.pdf /usr/share/man/*/*"
LANG="C.UTF8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed -Wl,--hash-style=gnu"
LINGUAS="en en_GB"
MAKEOPTS="-j6 -l6"
PKGDIR="/var/cache/binpkgs"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git"
PORTAGE_TMPDIR="/var/tmp"
USE="PIC acl aes avx avx2 berkdb bindist bzip2 caps cli crypt dri elogind f16c fma3 gdbm gmp graphite hardened hunspell iconv ipv6 jit libtirpc mmx mmxext ncurses nptl openmp pam pclmul pcre pie popcnt readline seccomp split-usr sse sse2 sse3 sse4_1 sse4_2 ssl ssse3 system-av1 system-binutils system-boost system-bootstrap system-cairo system-clang system-digest system-ffmpeg system-harfbuzz system-heimdal system-icu system-jpeg system-leveldb system-libevent system-libs system-libvpx system-libyaml system-lz4 system-mitkrb5 system-sqlite system-ssl system-tbb system-uulib system-webp system-zlib tcpd threads unicode x86 xattr zlib" ABI_X86="32" ADA_TARGET="gnat_2018" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1 emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="karbon sheets words" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" CPU_FLAGS_X86="aes avx avx2 f16c fma3 mmx mmxext pclmul popcnt sse sse2 sse3 sse4_1 sse4_2 ssse3" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock greis isync itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf skytraq superstar2 timing tsip tripmate tnt ublox ubx" INPUT_DEVICES="libinput" KERNEL="linux" L10N="en en-GB" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php7-2 php7-3" POSTGRES_TARGETS="postgres10 postgres11" PYTHON_SINGLE_TARGET="python3_7" PYTHON_TARGETS="python2_7 python3_7" RUBY_TARGETS="ruby25" USERLAND="GNU" VIDEO_CARDS="intel" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  CC, CPPFLAGS, CTARGET, CXX, LC_ALL, PORTAGE_BINHOST, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS
Comment 1 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2020-07-20 02:47:16 UTC
This has already been reported upstream for arm: https://github.com/aio-libs/aiohttp/issues/4515.
Comment 2 Zac Medico gentoo-dev 2020-07-20 04:09:05 UTC
Maybe we need to patch the test to use smaller ts_after value. What does datetime.datetime.max.timestamp() report on your arm system? This is what I have on amd64:

> $ python3.8
> Python 3.8.3 (default, Jul  6 2020, 20:21:42) 
> [GCC 9.2.0] on linux
> Type "help", "copyright", "credits" or "license" for more information.
> >>> import datetime
> >>> datetime.datetime.max.timestamp()
> 253402329600.0
> >>> datetime.datetime(2115, 1, 1).timestamp()
> 4575744000.0
Comment 3 Zac Medico gentoo-dev 2020-07-20 16:45:21 UTC
I've just tested in an x86 chroot, and I can see that both dates trigger OverflowError:

> Python 3.6.9 (default, Dec 20 2019, 22:37:39) 
> [GCC 9.2.0] on linux
> Type "help", "copyright", "credits" or "license" for more information.
> >>> import datetime
> >>> datetime.datetime.max.timestamp()
> Traceback (most recent call last):
>   File "<stdin>", line 1, in <module>
> OverflowError: timestamp out of range for platform time_t
> >>> datetime.datetime(2115, 1, 1).timestamp()
> Traceback (most recent call last):
>   File "<stdin>", line 1, in <module>
> OverflowError: timestamp out of range for platform time_t
Comment 4 Zac Medico gentoo-dev 2020-07-22 04:43:28 UTC
For 32-bit python, the maximum datetime unix timestamp is 2147483647:

> Python 3.8.2 (default, May 14 2020, 01:29:56) 
> [GCC 9.3.0] on linux
> Type "help", "copyright", "credits" or "license" for more information.
> >>> import datetime
> >>> datetime.datetime.fromtimestamp(2 ** 31 - 1)
> datetime.datetime(2038, 1, 19, 3, 14, 7)
> >>> datetime.datetime.fromtimestamp(2 ** 31 - 1).timestamp()
> 2147483647.0
Comment 5 Zac Medico gentoo-dev 2020-10-08 16:26:05 UTC
I'm not opposed to disabling this test, since https://github.com/aio-libs/aiohttp/pull/4873 only serves to make the test pass.
Comment 6 Zac Medico gentoo-dev 2020-10-08 16:40:08 UTC
It's possible that the faulty OverflowError handling could break unit tests for dependent packages.