Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 732704 - net-vpn/networkmanager-l2tp: nm-applet GUI only built with gnome USE flag
Summary: net-vpn/networkmanager-l2tp: nm-applet GUI only built with gnome USE flag
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Piotr Karbowski (RETIRED)
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2020-07-15 07:37 UTC by Michael Jones
Modified: 2023-01-24 11:21 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Jones 2020-07-15 07:37:36 UTC
In the network manager GUI, the l2tp configuration does not display the "vpn" panel if the "gnome" use flag is not enabled, instead you're shown the "proxy" panel, which is not applicable.

Reproducible: Always
Comment 1 Piotr Karbowski (RETIRED) gentoo-dev 2020-07-15 16:29:14 UTC
While you're not mistaken that GUI is missing without gnome flag, it still works. You can put the config by hand in /etc/NetworKManager/ and then use `nmcli c up NAME` and it will work. I actually use it like that on few VMs.
Comment 2 Michael Jones 2020-07-15 16:32:08 UTC
Then the use flag is named incorrectly.

"gnome" doesn't tell me anything.
"nm-applet support" would.

The USE description is 

# equery u net-vpn/networkmanager-l2tp
[ Legend : U - final flag setting for installation]
[        : I - package is installed with flag     ]
[ Colors : set, unset                             ]
 * Found these USE flags for net-vpn/networkmanager-l2tp-1.8.2:
 U I
 - - gnome       : Add GNOME support
 - - static-libs : Build static versions of dynamic libraries as well



How is an end-user to know that the "gnome" flag is applicable to their machine if they use e.g. lxqt?
Comment 3 Shiba 2020-12-20 19:45:21 UTC
My personal opinion is that it would be more reasonable to change this FLAG from "gnome" to "gtk", as that's what it actually pertains.
Comment 4 Larry the Git Cow gentoo-dev 2022-09-15 10:30:53 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=922945c527bf1974135f036f6ada5ef77da854ea

commit 922945c527bf1974135f036f6ada5ef77da854ea
Author:     Dmitrii Tochanskii <tochansky@tochlab.net>
AuthorDate: 2022-06-01 09:43:29 +0000
Commit:     Alexey Shvetsov <alexxy@gentoo.org>
CommitDate: 2022-09-15 10:30:48 +0000

    net-vpn/networkmanager-l2tp: Rename use flag gnome to gtk
    
    Bug: https://bugs.gentoo.org/732704
    Signed-off-by: Dmitrii Tochanskii <tochansky@tochlab.net>
    Signed-off-by: Alexey Shvetsov <alexxy@gentoo.org>

 net-vpn/networkmanager-l2tp/networkmanager-l2tp-1.20.4-r1.ebuild | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
Comment 5 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-09-15 10:37:40 UTC
It should probably be USE=gui instead.
Comment 6 Alexander Kurakin 2022-09-20 16:17:53 UTC
Why this has been introduced by the commit?

-	>=net-misc/networkmanager-1.20[ppp]
+	>=net-misc/networkmanager-1.2[ppp]
Comment 7 Alexey Shvetsov archtester gentoo-dev 2022-09-21 13:20:46 UTC
(In reply to Sam James from comment #5)
> It should probably be USE=gui instead.

Not realy. It can be used with gui e.g. with kde-nm plugin. So gtk is good choice
Comment 8 Alexander Kurakin 2022-10-10 18:41:19 UTC
Why this has been introduced by the commit?

-	>=net-misc/networkmanager-1.20[ppp]
+	>=net-misc/networkmanager-1.2[ppp]

And: can we close this bug?