Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 732582 - games-util/springlobby-0.269 : /.../battlelist.h: error: string in namespace std does not name a type
Summary: games-util/springlobby-0.269 : /.../battlelist.h: error: string in namespace ...
Status: CONFIRMED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Thomas Coquelin
URL:
Whiteboard:
Keywords: PullRequest
Depends on: 830588
Blocks:
  Show dependency tree
 
Reported: 2020-07-14 16:49 UTC by Toralf Förster
Modified: 2022-01-04 10:40 UTC (History)
5 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
emerge-info.txt (emerge-info.txt,16.33 KB, text/plain)
2020-07-14 16:49 UTC, Toralf Förster
Details
emerge-history.txt (emerge-history.txt,170.27 KB, text/plain)
2020-07-14 16:49 UTC, Toralf Förster
Details
environment (environment,87.55 KB, text/plain)
2020-07-14 16:49 UTC, Toralf Förster
Details
etc.portage.tbz2 (etc.portage.tbz2,13.72 KB, application/x-bzip)
2020-07-14 16:49 UTC, Toralf Förster
Details
games-util:springlobby-0.269:20200714-163744.log (games-util:springlobby-0.269:20200714-163744.log,900.70 KB, text/plain)
2020-07-14 16:49 UTC, Toralf Förster
Details
logs.tbz2 (logs.tbz2,8.63 KB, application/x-bzip)
2020-07-14 16:49 UTC, Toralf Förster
Details
temp.tbz2 (temp.tbz2,40.78 KB, application/x-bzip)
2020-07-14 16:49 UTC, Toralf Förster
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Toralf Förster gentoo-dev 2020-07-14 16:49:05 UTC
In file included from /var/tmp/portage/games-util/springlobby-0.269/work/springlobby-0.269/src/battlelist.cpp:12:
/var/tmp/portage/games-util/springlobby-0.269/work/springlobby-0.269/src/battlelist.h:36:43: error: ‘string’ in namespace ‘std’ does not name a type
   36 |  battle_id_t BattleFromChannel(const std::string& channelName) const;
      |                                           ^~~~~~
/var/tmp/portage/games-util/springlobby-0.269/work/springlobby-0.269/src/battlelist.h:20:1: note: ‘std::string’ is defined in header ‘<string>’; did you forget to ‘#include <string>’?

  -------------------------------------------------------------------

  This is an unstable amd64 chroot image at a tinderbox (==build bot)
  name: 17.1_desktop_plasma-20200708-161646

  -------------------------------------------------------------------

gcc-config -l:
 [1] x86_64-pc-linux-gnu-10.1.0 *
clang version 10.0.0 
Target: x86_64-pc-linux-gnu
Thread model: posix
InstalledDir: /usr/lib/llvm/10/bin
/usr/lib/llvm/10
10.0.0
Available Python interpreters, in order of preference:
  [1]   python3.7
  [2]   python3.9 (fallback)
  [3]   python3.8 (fallback)
  [4]   python2.7 (fallback)
Available Ruby profiles:
  [1]   ruby25 (with Rubygems) *
Available Rust versions:
  [1]   rust-1.44.1 *
The following VMs are available for generation-2:
*)	IcedTea JDK 3.16.0 [icedtea-bin-8]
Available Java Virtual Machines:
  [1]   icedtea-bin-8  system-vm

The Glorious Glasgow Haskell Compilation System, version 8.0.2

  timestamp(s) of HEAD at this tinderbox image:
/var/db/repos/gentoo	Tue 14 Jul 2020 04:05:34 PM UTC

emerge -qpvO games-util/springlobby
[ebuild  N    ] games-util/springlobby-0.269  USE="libnotify nls sound -debug"
Comment 1 Toralf Förster gentoo-dev 2020-07-14 16:49:07 UTC
Created attachment 649190 [details]
emerge-info.txt
Comment 2 Toralf Förster gentoo-dev 2020-07-14 16:49:10 UTC
Created attachment 649192 [details]
emerge-history.txt
Comment 3 Toralf Förster gentoo-dev 2020-07-14 16:49:13 UTC
Created attachment 649194 [details]
environment
Comment 4 Toralf Förster gentoo-dev 2020-07-14 16:49:16 UTC
Created attachment 649196 [details]
etc.portage.tbz2
Comment 5 Toralf Förster gentoo-dev 2020-07-14 16:49:19 UTC
Created attachment 649198 [details]
games-util:springlobby-0.269:20200714-163744.log
Comment 6 Toralf Förster gentoo-dev 2020-07-14 16:49:22 UTC
Created attachment 649200 [details]
logs.tbz2
Comment 7 Toralf Förster gentoo-dev 2020-07-14 16:49:25 UTC
Created attachment 649202 [details]
temp.tbz2
Comment 8 haarp 2021-12-04 13:47:23 UTC
This is fixed by https://github.com/springlobby/springlobby/pull/958 in newer versions.
Comment 9 mfld.fr 2021-12-21 22:44:12 UTC
Still broken in mainstream, but update to latest version 0.273 available in 'spring' overlay : https://github.com/springlobby/overlay
Comment 10 Fedja Beader 2021-12-23 16:00:00 UTC
Hello, one of proxy maintainers here. Sorry for not paying much attention to SL bug reports as I've temporarily lost interest in springrts.

I don't know if you can do it yourself (without being a proxy maintainer), but I suggest to go ahead and open a new bug for putting 0.273 into Portage and removing old ones.  I could do this myself, but it would probably be rude as you already did most of the work. You can also apply for proxy maintainership.
Comment 11 mfld.fr 2021-12-23 16:54:42 UTC
Hello Fedja, no problem to have no more interest in playing a game, that's how life goes on :-)

The proposal is rather to remove obsolete and not any more proxied 'springlobby' ebuild from mainstream, and focus the effort on the 'Spring RTS' overlay. See https://github.com/springlobby/overlay/issues/25 for the rational.
Comment 12 mfld.fr 2021-12-23 18:47:24 UTC
Suggest to remove (see above comments and https://github.com/gentoo/gentoo/pull/23483 for rationale).
Comment 13 Fedja Beader 2021-12-24 09:19:04 UTC
I cannot accept moving the ebuild to an overlay if your only rationale for doing so is perceived strictness of ebuild reviews. If anything, strictness is good!

Your claim of it being maintained in the overlay is also weak when the last commit was in start of 2019. That is, before you showed up 4 days ago. But if you prefer maintaining it that way...

My initial reason for wanting it in the portage tree is so that emerge -S would work for whoever goes about finding games to play by either asking portage for a list or by browsing the local tree. To that end I wanted to put every single notable spring game into ebuild description, much to the dislike of devs.


PS: I will not engage on any GitHub discussions as I prefer not to do libre and/or free time work on a proprietary platform.
Comment 14 Sam James archtester gentoo-dev Security 2021-12-24 09:36:30 UTC
Bit confused to be honest.

That thread starts with an essentially defamatory and certainly outdated statement: "Nevertheless I want to disable that auto-downloading until it can be done securely, despite Gentoo leadership not caring about security." 

Anyway, I'm happy to carry on proxying things. I don't see a clear description of the problem in 2021. It seems more like it was decided a while ago to use the overlay and so nobody wanted/attempted to update the version in Gentoo, but anyone is free to?
Comment 15 mfld.fr 2022-01-03 21:16:40 UTC
Hello, some background (and sad) information in https://github.com/gentoo/gentoo/pull/23483#issuecomment-1004363556 in response to Sam James.