Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 732316 - dev-libs/jemalloc-5.3.0: re-keyword
Summary: dev-libs/jemalloc-5.3.0: re-keyword
Status: IN_PROGRESS
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Keywording (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Mozilla Gentoo Team
URL:
Whiteboard:
Keywords: CC-ARCHES, PullRequest
Depends on: 856061
Blocks:
  Show dependency tree
 
Reported: 2020-07-12 08:56 UTC by Sergei Trofimovich (RETIRED)
Modified: 2022-07-03 17:09 UTC (History)
5 users (show)

See Also:
Package list:
dev-libs/jemalloc-5.3.0 ~amd64 ~arm ~arm64 ~hppa ~ppc ~ppc64 ~x86 ~ia64 ~riscv ~s390 ~alpha ~m68k ~mips
Runtime testing required: ---
nattka: sanity-check+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sergei Trofimovich (RETIRED) gentoo-dev 2020-07-12 08:56:02 UTC
Keywords for dev-libs/jemalloc:
      |                             |   u     |
      | a   a     p s     a   r     |   n     |
      | m   r h   p p   s l i i m m | e u s   | r
      | d a m p p c a x 3 p a s 6 i | a s l   | e
      | 6 r 6 p p 6 r 8 9 h 6 c 8 p | p e o   | p
      | 4 m 4 a c 4 c 6 0 a 4 v k s | i d t   | o
------+-----------------------------+---------+-------
3.6.0 | + + + + + + ~ + + ~ ~ o ~ ~ | 5 o 0   | gentoo
------+-----------------------------+---------+-------
4.4.0 | ~ ~ ~ ~ ~ ~ o ~ ~ ~ ~ o o o | 6 # 0/2 | gentoo
4.5.0 | ~ ~ ~ ~ ~ ~ o ~ ~ ~ ~ o o o | 6 #     | gentoo
5.0.1 | ~ ~ ~ ~ ~ ~ o ~ ~ ~ ~ o o o | 6 #     | gentoo
5.1.0 | ~ ~ ~ ~ ~ ~ o ~ ~ ~ ~ o o o | 6 #     | gentoo
5.2.0 | ~ ~ ~ ~ ~ ~ o ~ ~ ~ ~ o o o | 7 #     | gentoo
5.2.1 | + + + + + + o + + ~ ~ o o o | 7 o     | gentoo
Comment 1 Rolf Eike Beer archtester 2020-09-12 08:13:57 UTC
Possibly related:

/var/tmp/portage/dev-libs/jemalloc-5.2.1/work/jemalloc-5.2.1/include/jemalloc/internal/quantum.h:65:6: error: #error "Unknown minimum alignment for architecture; specify via "
   65 | #    error "Unknown minimum alignment for architecture; specify via "
      |      ^~~~~

This is on sparc32.
Comment 2 James Le Cuirot gentoo-dev 2021-09-20 22:33:22 UTC
I've now keyworded this for ~m68k.

2 tests fail with USE=prof where it was expecting a larger backtrace count, but this isn't surprising.
Comment 3 matoro archtester 2022-04-29 03:18:34 UTC
Looks good on sparc64.
Comment 4 Jakov Smolić archtester gentoo-dev 2022-05-28 20:42:06 UTC
sparc done
Comment 5 Joonas Niilola gentoo-dev 2022-06-30 05:39:10 UTC
Let's start over here.

Keywords for dev-libs/jemalloc:
            |                               |   u     |  
            | a   a     p s     r   a l     |   n     |  
            | m   r h   p p   i i s l o m m | e u s   | r
            | d a m p p c a x a s 3 p o 6 i | a s l   | e
            | 6 r 6 p p 6 r 8 6 c 9 h n 8 p | p e o   | p
            | 4 m 4 a c 4 c 6 4 v 0 a g k s | i d t   | o
------------+-------------------------------+---------+-------
[I]5.2.1-r1 | + + + + + + o + ~ ~ ~ ~ o ~ o | 7 o 0/2 | gentoo
   5.3.0    | o o o o o o ~ o o o o o ~ o o | 8 o     | gentoo

After testing jemalloc on amd64 & x86 (and some random rdeps on both) I'd have no problems just keywording everything to 5.3.0. But... since the AT teams are much more efficient nowadays we can do it properly too.
Comment 6 Joonas Niilola gentoo-dev 2022-06-30 05:40:12 UTC
CMP: dev-libs/jemalloc-5.2.1-r1/image with dev-libs/jemalloc-5.3.0/image
   ABI: libjemalloc.so.2(32) func(+10)
   ABI: libjemalloc.so.2(64) func(+10)
  SIZE: 5.08MiB -> 7.91MiB, 13 -> 13 files
------> ABI(+20) SIZE(+55.58%)

could be worth a subslot bump though...
Comment 7 Larry the Git Cow gentoo-dev 2022-06-30 05:55:14 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c35c6ebdb309e11471606e91c00d8b623daab2e2

commit c35c6ebdb309e11471606e91c00d8b623daab2e2
Author:     Joonas Niilola <juippis@gentoo.org>
AuthorDate: 2022-06-30 05:54:10 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2022-06-30 05:54:10 +0000

    dev-libs/jemalloc: keyword 5.3.0 for ~x86
    
    Bug: https://bugs.gentoo.org/732316
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 dev-libs/jemalloc/jemalloc-5.3.0.ebuild | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=4b06025cb56aa2105b4e6a0580573fa7ed35f301

commit 4b06025cb56aa2105b4e6a0580573fa7ed35f301
Author:     Joonas Niilola <juippis@gentoo.org>
AuthorDate: 2022-06-30 05:53:55 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2022-06-30 05:53:55 +0000

    dev-libs/jemalloc: keyword 5.3.0 for ~amd64
    
    Bug: https://bugs.gentoo.org/732316
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 dev-libs/jemalloc/jemalloc-5.3.0.ebuild | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 8 Yixun Lan archtester gentoo-dev 2022-06-30 22:12:28 UTC
riscv done
Comment 9 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-06-30 22:15:44 UTC
(In reply to Joonas Niilola from comment #6)
> CMP: dev-libs/jemalloc-5.2.1-r1/image with dev-libs/jemalloc-5.3.0/image
>    ABI: libjemalloc.so.2(32) func(+10)
>    ABI: libjemalloc.so.2(64) func(+10)
>   SIZE: 5.08MiB -> 7.91MiB, 13 -> 13 files
> ------> ABI(+20) SIZE(+55.58%)
> 
> could be worth a subslot bump though...

Only an ABI break "going backwards". Introducing new functions in a new version is okay (happens all the time - there's nothing to break), but dropping them isn't (because built binaries may depend on them), nor is changing structs, function signatures, ...

That's why if you downgraded libjemalloc now after building pkgs against the new versoin, those pkgs may well be broken, but we turn a blind eye to it because backwards compatibility (or forwards, whatever you want to call it) is kind of impossible to support properly.

(If we were to worry about that, we'd have to handle a LOT more packages.)

TL:DR: all fine b/c just added symbols, not modified or dropped.
Comment 10 matoro archtester 2022-06-30 22:47:02 UTC
arm64 done
Comment 11 Arthur Zamarin archtester gentoo-dev 2022-07-01 05:18:10 UTC
s390 done
Comment 12 Arthur Zamarin archtester gentoo-dev 2022-07-01 06:10:27 UTC
hppa done
Comment 13 Arthur Zamarin archtester gentoo-dev 2022-07-01 06:10:28 UTC
ppc done
Comment 14 Arthur Zamarin archtester gentoo-dev 2022-07-01 06:16:14 UTC
arm done
Comment 15 Jakov Smolić archtester gentoo-dev 2022-07-02 07:02:37 UTC
ppc64 done
Comment 16 James Le Cuirot gentoo-dev 2022-07-03 17:09:09 UTC
m68k done