Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 728864 - net-print/hplip-3.20.{5,6}: fails to build with musl libc - missing #include's
Summary: net-print/hplip-3.20.{5,6}: fails to build with musl libc - missing #include's
Status: CONFIRMED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Michael 'veremitz' Everitt
URL:
Whiteboard:
Keywords: NeedPatch
Depends on:
Blocks:
 
Reported: 2020-06-20 06:04 UTC by Michael 'veremitz' Everitt
Modified: 2020-09-06 19:40 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michael 'veremitz' Everitt 2020-06-20 06:04:53 UTC
I was preparing to install hplip-3.20.6 in order to test hplip-plugin-3.20.6, but unfortunately we don't presently have the patch(es) needed to build any of the 3.20.x versions of hplip for musl libc in ::gentoo yet (nor ::musl FTR).

As agreed with @billie, happy to submit the required patches for him to include, as they shouldn't affect [normal] glibc installations.

Alpine linux has a full set of patches for 3.20.5 at https://git.alpinelinux.org/aports/tree/testing/hplip but these need sync'ing with our own, which I'm happy to do & test.

Assigning to self, as need to log some Z's presently, but making notes to revisit asap. @Chewi will know I've promised him a PR for hplip-plugin once tested :P

Will update as I make progress.
Comment 1 Daniel Pielmeier gentoo-dev 2020-06-20 13:32:20 UTC
No problem with including musl patches. Two things however:

First please make sure that upstream is aware of these patches. At a quick glance I found nothing there.

Second you may look also at the OpenWrt Project [1] and The Void Linux distribution [2] which also support musl and hplip.

Btw. hplip is at 3.20.6 now.

[1] https://github.com/openwrt/packages/tree/master/utils/hplip/patches
[2] https://github.com/void-linux/void-packages/tree/master/srcpkgs/hplip/patches
Comment 2 Michael 'veremitz' Everitt 2020-06-20 18:20:50 UTC
Thanks Daniel!

Usually I do check in with void too, as it can be a slow process for musl distros to keep track of upstream releases!

I'll do my best to push necessary patches upstream, I do believe they are receptive to changes and PR, although I'm not 100% at present what their preferred method is.

Thanks for doing the 3.20.6 bump .. for some reason I've lost the email notification I had about the update! I see you've also picked up a dbus issue in another bug too!
Comment 3 tt_1 2020-09-06 11:16:54 UTC
I found an upstream bug for musl support with three patches: https://bugs.launchpad.net/hplip/+bug/1886527
Comment 4 Michael 'veremitz' Everitt 2020-09-06 19:12:08 UTC
(In reply to tt_1 from comment #3)
> I found an upstream bug for musl support with three patches:
> https://bugs.launchpad.net/hplip/+bug/1886527

Thanks for this, just what we need. Hopefully if these are accepted we can stop carrying downstream patches.

I'm overdue testing the new releases on my musl boxes, but will endeavour to PR these over the next week or so.
Comment 5 tt_1 2020-09-06 19:26:45 UTC
how is the situation with the hplip-plugins package? Does it tolerate a musl libc.so?
Comment 6 James Le Cuirot gentoo-dev 2020-09-06 19:33:21 UTC
(In reply to tt_1 from comment #5)
> how is the situation with the hplip-plugins package? Does it tolerate a musl
> libc.so?

I haven't tried but I think it does, with the exception of bb_orblite.so.
Comment 7 tt_1 2020-09-06 19:40:03 UTC
well, and it seems that hplip-plugins just got a useflag to filter these out, happy days! :)