Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 728426 - app-editors/scite-4.3.3 calls 'ar', 'ranlib' and 'c++' directly
Summary: app-editors/scite-4.3.3 calls 'ar', 'ranlib' and 'c++' directly
Status: CONFIRMED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Ervin Peters
URL:
Whiteboard:
Keywords: PATCH, PullRequest
Depends on:
Blocks: tc-directly
  Show dependency tree
 
Reported: 2020-06-15 22:20 UTC by Sergei Trofimovich
Modified: 2020-08-21 07:15 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sergei Trofimovich gentoo-dev 2020-06-15 22:20:40 UTC
Noticed on sys-devel/gcc-config[-native-symlinks] / sys-devel/binutils-config[-native-symlinks] system as a built failure:

"""
>>> Compiling source in /tmp/portage/app-editors/scite-4.3.3/work/scite/gtk ...
make --jobs=4 -C /tmp/portage/app-editors/scite-4.3.3/work/scintilla/gtk GTK3=1 NO_LUA=1
make: Entering directory '/tmp/portage/app-editors/scite-4.3.3/work/scintilla/gtk'
c++ -DGTK -DSCI_LEXER -DNDEBUG -I ./../include -I ./../src -I ./../lexlib --std=c++17 -fPIC -Wpedantic -Wall  -pthread -I/usr/include/gtk-3.0 -I/usr/include/at-spi2-atk/2.0 -I/usr/include/at-spi-2.0 -I/usr/include/dbus-1.0 -I/usr/lib64/dbus-1.0/include -I/usr/include/gtk-3.0 -I/usr/include/gio-unix-2.0 -I/usr/include/cairo -I/usr/include/pango-1.0 -I/usr/include/harfbuzz -I/usr/include/pango-1.0 -I/usr/include/fribidi -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pixman-1 -I/usr/include/uuid -I/usr/include/freetype2 -I/usr/include/libpng16 -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/libmount -I/usr/include/blkid -I/usr/lib64/libffi/include -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -march=sandybridge -mtune=sandybridge -maes --param=l1-cache-size=32 --param=l1-cache-line-size=64 --param=l2-cache-size=8192 -O2 -pipe -fdiagnostics-show-option -frecord-gcc-switches -Wall -Wextra -Wstack-protector -frecord-gcc-switches -frecord-gcc-switches -c ./../src/AutoComplete.cxx
make: c++: No such file or directory
make: *** [makefile:92: AutoComplete.o] Error 127
make: Leaving directory '/tmp/portage/app-editors/scite-4.3.3/work/scintilla/gtk'
 * ERROR: app-editors/scite-4.3.3::gentoo failed (compile phase):
 *   emake failed
"""

This looks like a typo in sed. The following patch fixes it for me (and fixes AR/RANLIB direct use):

--- scite-4.3.3.ebuild	2020-05-17 19:01:30.000000000 +0100
+++ scite-4.3.3-r1.ebuild	2020-06-15 23:17:14.000000000 +0100
@@ -49,20 +49,22 @@
 	fi
 }

 src_prepare() {
+	tc-export AR CC CXX RANLIB
+
 	# remove hardcoded CC, Optimizations and clang unknown flags
 	sed -i "${WORKDIR}/scintilla/gtk/makefile" \
 	-e "s#^CC = gcc#CC = ${CC}#" \
 	-e "s#^CC = clang#CC = ${CC}#" \
-	-e "s#^CXX = clang++#CC = ${CXX}#" \
+	-e "s#^CXX = clang++#CXX = ${CXX}#" \
 	-e "s#-Os##" \
 	-e "s#-Wno-misleading-indentation##" \
 	|| die "error patching /scintilla/gtk/makefile"

 	sed -i "${S}/makefile" \
 	-e "s#^CC = clang#CC = ${CC}#" \
-	-e "s#^CXX = clang++#CC = ${CXX}#" \
+	-e "s#^CXX = clang++#CXX = ${CXX}#" \
 	-e "s#-rdynamic#-rdynamic ${LDFLAGS}#" \
 	-e "s#-Os##" \
 	|| die "error patching gtk/makefile"
Comment 1 Ervin Peters 2020-06-21 18:10:52 UTC
applied in Version bump 4.4.3 PR #16062:

https://github.com/gentoo/gentoo/pull/16062
Comment 2 Larry the Git Cow gentoo-dev 2020-08-21 07:15:04 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=dbe0cbd3f6fd845bd57ab2e41d006f24f5be1e6f

commit dbe0cbd3f6fd845bd57ab2e41d006f24f5be1e6f
Author:     Ervin Peters <coder@ervnet.de>
AuthorDate: 2020-08-11 13:29:56 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2020-08-21 07:14:44 +0000

    app-editors/scite: sed fixes
    
    fixed makefile CXX var errors
    
    Bug: https://bugs.gentoo.org/728426
    CLOSES: https://bugs.gentoo.org/728426
    Signed-off-by: Ervin Peters <coder@ervnet.de>
    Package-Manager: Portage-2.3.103, Repoman-2.3.23
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 app-editors/scite/scite-4.2.1.ebuild | 8 +++++---
 app-editors/scite/scite-4.3.3.ebuild | 8 +++++---
 2 files changed, 10 insertions(+), 6 deletions(-)