Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 728240 - app-text/sigil-1.2.1 compatibility problems with qtwebengine-5.15.0
Summary: app-text/sigil-1.2.1 compatibility problems with qtwebengine-5.15.0
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Arthur Zamarin
URL: https://www.mobileread.com/forums/sho...
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks: qt-5.15
  Show dependency tree
 
Reported: 2020-06-14 14:31 UTC by trasgu
Modified: 2020-06-16 19:02 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description trasgu 2020-06-14 14:31:47 UTC
app-text/sigil is almost useless after dev-qt/qtwebengine upgrade from 5.14.2 to 5.15.0. There are NO compiling problems, just important broken features using this application (i.e. WYSIWYG with no previsualisation...)

Althought Sigil's developers are working to fix the problem, it'll take "some time" until a new version is ready. Current Sigil Github repository version works fine to me after downloading/compiling myself. More info on the Sigil's support forum:

https://www.mobileread.com/forums/showthread.php?t=330486


Consequently:

a) app-text/sigil(<=1.2.1) requires dev-qt/qtwebengine(<=5.14.2)

or 

b) app-text/sigil needs to be compiled from latest Github repository (wich works OK with qtwebengine 5.15.0)

Thx.
Comment 1 Andreas Sturmlechner gentoo-dev 2020-06-15 17:52:13 UTC
(In reply to trasgu from comment #0)
> b) app-text/sigil needs to be compiled from latest Github repository (wich
> works OK with qtwebengine 5.15.0)
Did they not point at a specific commit for 5.15 compatibility?
Comment 2 Arthur Zamarin archtester Gentoo Infrastructure gentoo-dev Security 2020-06-16 05:07:28 UTC
First of all, I'm not sure what the problem is. I did find that images were not shown, but are there more problems?

Based on the comments in the forums link you have given me, and the comments there, the problem was fixed upstream.

After some trying, I have found https://github.com/Sigil-Ebook/Sigil/commit/50280fae48717e76d56685bf0fda19783c8904e1 . I tried to apply it, and I think it fixed it (images are showing now).

Could I ask you to run this commands and then rebuild sigil?
mkdir -p /etc/portage/patches/app-text/sigil
curl 'https://github.com/Sigil-Ebook/Sigil/commit/50280fae48717e76d56685bf0fda19783c8904e1.patch' > /etc/portage/patches/app-text/sigil/qt5.15.patch

Those commands will download the patch, and during rebuilding will apply the patch. Please check if the problem is fixed. If it is, we will apply it in the ebuild correctly.

In my tests, the patch was applied and fixed to those versions: 1.0.0 , 1.1.0 , 1.2.1 - so we can fix old version also (or drop them? ).
Comment 3 trasgu 2020-06-16 17:26:29 UTC
Hi!

The patch + rebuild Sigil (1.2.1) works perfectly, and it's way better solution than recompiling qtwebengine again (wich is a pain in ....).
  
The problems with qt5.15 were everything about previsualization (no images, no formatting texts, no typography, margins.... i.e. useless).  Sigil is a WYSIWYG editor, btw  ;-)


Thank you all, guys, for this fast response.
Comment 4 Arthur Zamarin archtester Gentoo Infrastructure gentoo-dev Security 2020-06-16 17:58:55 UTC
Thanks for your report and fast reply.

I have posted a pull request (sorry, I'm a proxy-maintainer so I can't push the changes myself).

Do note, that after the PR is merged, you must delete the patch you downloaded by my commands, as it will try to apply it twice (and fail of course).
Comment 5 Larry the Git Cow gentoo-dev 2020-06-16 19:00:06 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ebd2cc940f853c1d6aa9e0b20ef8970b75e51253

commit ebd2cc940f853c1d6aa9e0b20ef8970b75e51253
Author:     Zamarin Arthur <arthurzam@gmail.com>
AuthorDate: 2020-06-16 17:49:23 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2020-06-16 18:59:36 +0000

    app-text/sigil: fix compatibility with qtwebengine-5.15.0
    
    use upstream patch which fixes compatibility problems with qtwebengine-5.15.0
    
    Closes: https://bugs.gentoo.org/728240
    Package-Manager: Portage-2.3.101, Repoman-2.3.22
    Signed-off-by: Zamarin Arthur <arthurzam@gmail.com>
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 app-text/sigil/files/sigil-1.2.1-qt5.15-fix.patch  | 22 ++++++++++++++++++++++
 .../{sigil-1.2.1.ebuild => sigil-1.2.1-r1.ebuild}  |  2 ++
 2 files changed, 24 insertions(+)