Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 727478 - dev-python/grpcio calls cc directly
Summary: dev-python/grpcio calls cc directly
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Georgy Yakovlev
URL: https://github.com/grpc/grpc/pull/23159
Whiteboard:
Keywords:
Depends on:
Blocks: tc-directly
  Show dependency tree
 
Reported: 2020-06-08 06:08 UTC by Agostino Sarubbo
Modified: 2020-10-09 21:45 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,8.28 KB, text/plain)
2020-06-08 06:08 UTC, Agostino Sarubbo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2020-06-08 06:08:40 UTC
@@This is an auto-filed bug@@
If you think that a different summary clarifies the issue better, feel free to change it.

Issue: dev-python/grpcio calls cc directly.
Discovered on: amd64

NOTE:
If you think it doesn't make sense fix these type of issues, I'd like to point out that won't be possible use a different CC implementation (like clang) by setting the CC variable. So this issue has been reproduced by setting the CC variable to x86_64-pc-linux-gnu-gcc and by removing the /usr/bin/cc - /usr/bin/gcc binaries.
Comment 1 Agostino Sarubbo gentoo-dev 2020-06-08 06:08:45 UTC
Created attachment 643888 [details]
build.log

build log and emerge --info
Comment 2 Georgy Yakovlev gentoo-dev 2020-06-08 06:23:52 UTC
def check_linker_need_libatomic():
  """Test if linker on system needs libatomic."""
  code_test = (b'#include <atomic>\n' +
               b'int main() { return std::atomic<int64_t>{}; }')                                                   
  cc_test = subprocess.Popen(['cc', '-x', 'c++', '-std=c++11', '-'],                                               
                             stdin=PIPE,
                             stdout=PIPE,
                             stderr=PIPE)
  cc_test.communicate(input=code_test)
  return cc_test.returncode != 0


compilation itself uses full path, it's just check above fails.
Comment 3 Larry the Git Cow gentoo-dev 2020-06-08 07:05:09 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=4e00d0a56ca1dd9be9d99a3d80a12d2f0b6b1cfc

commit 4e00d0a56ca1dd9be9d99a3d80a12d2f0b6b1cfc
Author:     Georgy Yakovlev <gyakovlev@gentoo.org>
AuthorDate: 2020-06-08 06:56:16 +0000
Commit:     Georgy Yakovlev <gyakovlev@gentoo.org>
CommitDate: 2020-06-08 07:04:49 +0000

    dev-python/grpcio: respect CC in setup.py
    
    Upstream-PR: https://github.com/grpc/grpc/pull/23159
    Bug: https://bugs.gentoo.org/727478
    Package-Manager: Portage-2.3.100, Repoman-2.3.22
    Signed-off-by: Georgy Yakovlev <gyakovlev@gentoo.org>

 dev-python/grpcio/files/setup.py-respect-cc.patch | 33 +++++++++++++++++++++++
 dev-python/grpcio/grpcio-1.28.1.ebuild            |  2 ++
 2 files changed, 35 insertions(+)
Comment 4 Larry the Git Cow gentoo-dev 2020-06-08 07:14:49 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f27de769b375f53f4e2b0383c653b1be81538795

commit f27de769b375f53f4e2b0383c653b1be81538795
Author:     Georgy Yakovlev <gyakovlev@gentoo.org>
AuthorDate: 2020-06-08 07:14:21 +0000
Commit:     Georgy Yakovlev <gyakovlev@gentoo.org>
CommitDate: 2020-06-08 07:14:21 +0000

    dev-python/grpcio-tools: respect CC in setup.py
    
    Upstream-PR: https://github.com/grpc/grpc/pull/23159
    Bug: https://bugs.gentoo.org/727478
    Package-Manager: Portage-2.3.100, Repoman-2.3.22
    Signed-off-by: Georgy Yakovlev <gyakovlev@gentoo.org>

 dev-python/grpcio-tools/files/setup.py-respect-cc.patch | 14 ++++++++++++++
 dev-python/grpcio-tools/grpcio-tools-1.28.1.ebuild      |  2 ++
 2 files changed, 16 insertions(+)
Comment 5 Georgy Yakovlev gentoo-dev 2020-10-09 21:45:53 UTC
all versions are patched, closing.