Bug 725678 – media-sound/clementine-1.4.0_rc1 w/ dev-qt/qtgui-5.15.0: src/widgets/osdpretty.cpp:209:16: error: aggregate ‘QPainterPath background_path’ has incomplete type and cannot be defined

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Nick Andrade 2020-05-28 04:56:36 UTC]

Clementine 1.4.0_rc1 is failing on various files with the error: aggregate ‘QPainterPath background_path’ has incomplete type and cannot be defined

I haven't tried older versions of QtGui, but this is definitely the case on 5.15.0.

Reproducible: Always

Steps to Reproduce:
1. emerge =media-sound/clementine-1.4.0_rc1 
Actual Results:  
AILED: src/CMakeFiles/clementine_lib.dir/widgets/osdpretty.cpp.o 
/usr/lib/ccache/bin/x86_64-pc-linux-gnu-g++ -DBOOST_BIND_NO_PLACEHOLDERS -DBUILD_QXT_CORE -DBUILD_QXT_GUI -DQT_CONCURRENT_LIB -DQT_CORE_LIB -DQT_DBUS_LIB -DQT_GUI_LIB -DQT_NETWORK_LIB -DQT_NO_CAST_TO_ASCII -DQT_NO_DEBUG -DQT_NO_URL_CAST_FROM_STRING -DQT_OPENGL_LIB -DQT_SQL_LIB -DQT_STRICT_ITERATORS -DQT_USE_QSTRINGBUILDER -DQT_WIDGETS_LIB -DQT_X11EXTRAS_LIB -DQT_XML_LIB -DQXT_STATIC -I/usr/include/taglib -I/usr/include/gstreamer-1.0 -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/lib64/libffi/include -I/usr/include/orc-0.4 -I/usr/include/libxml2 -I/var/tmp/portage/media-sound/clementine-1.4.0_rc1/work/clementine-1.4.0rc1/3rdparty/qsqlite -I/var/tmp/portage/media-sound/clementine-1.4.0_rc1/work/clementine-1.4.0rc1 -Isrc -I/var/tmp/portage/media-sound/clementine-1.4.0_rc1/work/clementine-1.4.0rc1/src -I/var/tmp/portage/media-sound/clementine-1.4.0_rc1/work/clementine-1.4.0rc1/src/../3rdparty/gmock/gtest/include -I. -I/var/tmp/portage/media-sound/clementine-1.4.0_rc1/work/clementine-1.4.0rc1/3rdparty/qtsingleapplication -I/var/tmp/portage/media-sound/clementine-1.4.0_rc1/work/clementine-1.4.0rc1/3rdparty/qtiocompressor -I/var/tmp/portage/media-sound/clementine-1.4.0_rc1/work/clementine-1.4.0rc1/3rdparty/qxt -I/usr/include/mygpo-qt5 -I/var/tmp/portage/media-sound/clementine-1.4.0_rc1/work/clementine-1.4.0rc1/ext/libclementine-common -I/var/tmp/portage/media-sound/clementine-1.4.0_rc1/work/clementine-1.4.0rc1/ext/libclementine-tagreader -Iext/libclementine-tagreader -I/var/tmp/portage/media-sound/clementine-1.4.0_rc1/work/clementine-1.4.0rc1/ext/libclementine-remote -Iext/libclementine-remote -I/var/tmp/portage/media-sound/clementine-1.4.0_rc1/work/clementine-1.4.0rc1/ext/libclementine-spotifyblob -Iext/libclementine-spotifyblob -I/usr/include/gpod-1.0 -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/libusb-1.0 -isystem /usr/include/qt5/QtCore -isystem /usr/include/qt5 -isystem /usr/include/qt5/QtNetwork -isystem /usr/lib64/qt5/mkspecs/linux-g++ -isystem /usr/include/qt5/QtConcurrent -isystem /usr/include/qt5/QtWidgets -isystem /usr/include/qt5/QtGui -isystem /usr/include/qt5/QtSql -isystem /usr/include/qt5/QtXml -isystem /usr/include/qt5/QtOpenGL -isystem /usr/include/qt5/QtDBus -isystem /usr/include/qt5/QtX11Extras  -DQT_NO_DEBUG_OUTPUT -march=native -O2 -pipe -Woverloaded-virtual -Wall -Wno-sign-compare -Wno-deprecated-declarations -Wno-unused-local-typedefs -Wno-unused-private-field -Wno-unknown-warning-option --std=c++0x -U__STRICT_ANSI__   -fPIC -MD -MT src/CMakeFiles/clementine_lib.dir/widgets/osdpretty.cpp.o -MF src/CMakeFiles/clementine_lib.dir/widgets/osdpretty.cpp.o.d -o src/CMakeFiles/clementine_lib.dir/widgets/osdpretty.cpp.o -c /var/tmp/portage/media-sound/clementine-1.4.0_rc1/work/clementine-1.4.0rc1/src/widgets/osdpretty.cpp
/var/tmp/portage/media-sound/clementine-1.4.0_rc1/work/clementine-1.4.0rc1/src/widgets/osdpretty.cpp: In member function ‘virtual void OSDPretty::paintEvent(QPaintEvent*)’:
/var/tmp/portage/media-sound/clementine-1.4.0_rc1/work/clementine-1.4.0rc1/src/widgets/osdpretty.cpp:209:16: error: aggregate ‘QPainterPath background_path’ has incomplete type and cannot be defined
  209 |   QPainterPath background_path;

Exact file which fails may depend on -j settings.

Expected Results:  
Successful build.

Attached is a patch which seems to resolve the issue (tested with QtGui 5.15.0 on ~amd64).

[Comment 1 Nick Andrade 2020-05-28 04:58:32 UTC]

Created attachment 642136 [details, diff]
Adds #include <QPainterPath> where necessary

Tested with epatch_user, resolves the issue for me.

[Comment 2 Larry the Git Cow 2020-05-28 08:56:17 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=922013719ab545531b37dcb72a743c3b98db38be

commit 922013719ab545531b37dcb72a743c3b98db38be
Author:     Lars Wendler <[e-mail]>
AuthorDate: 2020-05-28 08:37:37 +0000
Commit:     Lars Wendler <[e-mail]>
CommitDate: 2020-05-28 08:56:11 +0000

    media-sound/clementine: Fixed build with qt-5.15
    
    Thanks-to: Nick Andrade <[e-mail]>
    Closes: https://bugs.gentoo.org/725678
    Package-Manager: Portage-2.3.100, Repoman-2.3.22
    Signed-off-by: Lars Wendler <[e-mail]>

 media-sound/clementine/clementine-1.4.0_rc1.ebuild |  4 ++
 ...clementine-1.4.0_rc1-QPainterPath_include.patch | 50 ++++++++++++++++++++++
 2 files changed, 54 insertions(+)

[Comment 3 Andreas Sturmlechner 2020-05-28 08:57:38 UTC]

Please submit this patch upstream.

[Comment 4 Nick Andrade 2020-05-28 16:09:04 UTC]

FYI, I submitted the fix upstream after filing this bug; the patch has been accepted and merged: https://github.com/clementine-player/Clementine/issues/6701