gtkpod 0.85 now supports mp3gain tag reading. from change log: IMPROVEMENT: Volume normalizing: when importing mp3 the replay gain is read and the soundcheck field set accordingly. Use the "soundcheck" feature of the iPod to have the volume normalized during playback. If no replay gain tag is set, use the "Normalize" as usual to have mp3gain write a replay gain tag. This needs mp3gain (in portage) to be installed. The gtkpod ebuild doesn't do this. I could attach a new ebuild but I'm not sure if it should be a dependancy (run time) or a USE flag. I'd guess it's a run time dep. Reproducible: Always Steps to Reproduce:
actually, more testing indicates this is not a major problem since gtkpod has a "setting/option" to enter the path to a GAIN program. So if the user wants gain functions i guess they can emerge mp3gain again
why again? Just installing mp3gain isnt enough?
sorry I made a typo, I meant, if the user wants mp3gain functions, they can a) emerge mp3gain since the path to mp3gain can be set within gtkpod. So this bug can be closed. Sorry for any inconvinence.
ok, that's what I though
mp3gain use is a default and often-used functionality within gtkpod, so I think it should be added as an RDEPEND.
well, its not a dependency.. you can just install it separately and it will use it. this is a bit like adding xterm as a dep to xorg-server since they often are used together...
xterm _is_ a dep of xinit, because xinit's fallback calls xterm. It's exactly the same as that, except not even a fallback. Calling a binary makes it a dependency, not an optional add-on.
mp3gain is at best an optional dep.. and I always tought it was silly to have a use flag that just installs a package
(In reply to comment #8) > mp3gain is at best an optional dep.. and I always tought it was silly to have a > use flag that just installs a package It may be optional, but it's the default mp3gain executable called by gtkpod. You're not just installing a package, you're installing a runtime dependency. gtkpod produces lots of errors when using a standard menu item without this program, thus it's a true dep. So unless you'd like to create a list of "|| ( mp3gain mp3gain-substitute )" etc., I think adding mp3gain to RDEPEND is the best solution.
