Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 72335 - gtkpod-0.85.0 ebuild has no support for mp3gain
Summary: gtkpod-0.85.0 ebuild has no support for mp3gain
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High minor (vote)
Assignee: Olivier Crete (RETIRED)
Depends on:
Reported: 2004-11-24 03:55 UTC by Surakshan Mendis
Modified: 2005-11-20 14:40 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Note You need to log in before you can comment on or make changes to this bug.
Description Surakshan Mendis 2004-11-24 03:55:32 UTC
gtkpod 0.85 now supports mp3gain tag reading.

from change log:

	IMPROVEMENT: Volume normalizing: when importing mp3 the replay
	gain is read and the soundcheck field set accordingly. Use
	the "soundcheck" feature of the iPod to have the volume
	normalized during playback.
	If no replay gain tag is set, use the "Normalize" as usual to
	have mp3gain write a replay gain tag.

This needs mp3gain (in portage) to be installed. The gtkpod ebuild doesn't do this. I could attach a new ebuild but I'm not sure if it should be a dependancy (run time) or a USE flag. I'd guess it's a run time dep.

Reproducible: Always
Steps to Reproduce:
Comment 1 Surakshan Mendis 2004-11-24 16:01:58 UTC
actually, more testing indicates this is not a major problem since gtkpod has a "setting/option" to enter the path to a GAIN program. So if the user wants gain functions i guess they can emerge mp3gain again
Comment 2 Olivier Crete (RETIRED) gentoo-dev 2004-11-24 16:42:06 UTC
why again? Just installing mp3gain isnt enough?
Comment 3 Surakshan Mendis 2004-11-24 17:24:48 UTC
sorry I made a typo,

I meant, if the user wants mp3gain functions, they can

a) emerge mp3gain
since the path to mp3gain can be set within gtkpod.

So this bug can be closed.
Sorry for any inconvinence.
Comment 4 Olivier Crete (RETIRED) gentoo-dev 2004-11-24 17:33:50 UTC
ok, that's what I though
Comment 5 Donnie Berkholz (RETIRED) gentoo-dev 2005-11-19 19:09:04 UTC
mp3gain use is a default and often-used functionality within gtkpod, so I think
it should be added as an RDEPEND.
Comment 6 Olivier Crete (RETIRED) gentoo-dev 2005-11-20 01:10:30 UTC
well, its not a dependency.. you can just install it separately and it will use
it. this is a bit like adding xterm as a dep to xorg-server since they often are
used together... 
Comment 7 Donnie Berkholz (RETIRED) gentoo-dev 2005-11-20 11:29:29 UTC
xterm _is_ a dep of xinit, because xinit's fallback calls xterm. It's exactly
the same as that, except not even a fallback.

Calling a binary makes it a dependency, not an optional add-on.
Comment 8 Olivier Crete (RETIRED) gentoo-dev 2005-11-20 12:08:01 UTC
mp3gain is at best an optional dep.. and I always tought it was silly to have a
use flag that just installs a package 
Comment 9 Donnie Berkholz (RETIRED) gentoo-dev 2005-11-20 14:40:35 UTC
(In reply to comment #8)
> mp3gain is at best an optional dep.. and I always tought it was silly to have a
> use flag that just installs a package 

It may be optional, but it's the default mp3gain executable called by gtkpod.
You're not just installing a package, you're installing a runtime dependency.
gtkpod produces lots of errors when using a standard menu item without this
program, thus it's a true dep.

So unless you'd like to create a list of "|| ( mp3gain mp3gain-substitute )"
etc., I think adding mp3gain to RDEPEND is the best solution.