Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 722002 - sys-fs/bcache-tools-1.0.8_p20140220-r1 : bcache-super-show.c:(.text.startup+<snip>): undefined reference to crc64
Summary: sys-fs/bcache-tools-1.0.8_p20140220-r1 : bcache-super-show.c:(.text.startup+<...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal with 3 votes (vote)
Assignee: No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2020-05-10 07:56 UTC by Toralf Förster
Modified: 2020-09-25 22:28 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
emerge-info.txt (emerge-info.txt,17.37 KB, text/plain)
2020-05-10 07:56 UTC, Toralf Förster
Details
emerge-history.txt (emerge-history.txt,284.20 KB, text/plain)
2020-05-10 07:56 UTC, Toralf Förster
Details
environment (environment,132.55 KB, text/plain)
2020-05-10 07:56 UTC, Toralf Förster
Details
etc.portage.tbz2 (etc.portage.tbz2,24.93 KB, application/x-bzip)
2020-05-10 07:56 UTC, Toralf Förster
Details
sys-fs:bcache-tools-1.0.8_p20140220-r1:20200510-042339.log (sys-fs:bcache-tools-1.0.8_p20140220-r1:20200510-042339.log,3.66 KB, text/plain)
2020-05-10 07:56 UTC, Toralf Förster
Details
temp.tbz2 (temp.tbz2,28.89 KB, application/x-bzip)
2020-05-10 07:56 UTC, Toralf Förster
Details
/etc/portage/patches/sys-fs/bcache-tools-1.0.8_p20140220-r1/gcc10.patch (file_722002.txt,382 bytes, patch)
2020-07-14 13:20 UTC, strites
Details | Diff
/etc/portage/env/sys-fs/bcache-tools-1.0.8_p20140220-r1 (file_722002.txt,334 bytes, text/plain)
2020-07-14 13:21 UTC, strites
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Toralf Förster gentoo-dev 2020-05-10 07:56:10 UTC
x86_64-pc-linux-gnu-gcc -O2 -pipe -march=native  -fno-common -Wformat -Werror=format-security -Wall -std=gnu99 -std=gnu99  -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -Wl,-O1 -Wl,--as-needed -Wl,--defsym=__gentoo_check_ldflags__=0  bcache-super-show.c bcache.o  pkg-config --libs uuid -o bcache-super-show
/usr/lib/gcc/x86_64-pc-linux-gnu/10.1.0/../../../../x86_64-pc-linux-gnu/bin/ld: /var/tmp/portage/sys-fs/bcache-tools-1.0.8_p20140220-r1/temp/ccwlEr5I.o: in function main:
bcache-super-show.c:(.text.startup+0x13e): undefined reference to crc64
collect2: error: ld returned 1 exit status
make: *** [<builtin>: bcache-super-show] Error 1
 * ERROR: sys-fs/bcache-tools-1.0.8_p20140220-r1::gentoo failed (compile phase):

  -------------------------------------------------------------------

  This is an unstable amd64 chroot image at a tinderbox (==build bot)
  name: 17.1_no-multilib_hardened-libressl-20200502-233152

  -------------------------------------------------------------------

gcc-config -l:
 [1] x86_64-pc-linux-gnu-10.1.0 *
clang version 10.0.0 
Target: x86_64-pc-linux-gnu
Thread model: posix
InstalledDir: /usr/lib/llvm/10/bin
/usr/lib/llvm/10
10.0.0
Available Python interpreters, in order of preference:
  [1]   python3.6
  [2]   python3.8 (fallback)
  [3]   python3.7 (fallback)
  [4]   python2.7 (fallback)
Available Ruby profiles:
  [1]   ruby24 (with Rubygems)
  [2]   ruby25 (with Rubygems) *
Available Rust versions:
  [1]   rust-1.43.0 *
  [2]   rust-bin-1.43.1
The following VMs are available for generation-2:
*)	AdoptOpenJDK 8.252_p09 [openjdk-bin-8]
Available Java Virtual Machines:
  [1]   openjdk-bin-8  system-vm

The Glorious Glasgow Haskell Compilation System, version 8.0.2

  timestamp(s) of HEAD at this tinderbox image:
/var/db/repos/gentoo	Sun 10 May 2020 03:05:14 AM UTC
/var/db/repos/libressl	Sat 11 Apr 2020 05:02:25 AM UTC

emerge -qpvO sys-fs/bcache-tools
[ebuild  N    ] sys-fs/bcache-tools-1.0.8_p20140220-r1  PYTHON_TARGETS="python3_7 -python3_6 -python3_8"
Comment 1 Toralf Förster gentoo-dev 2020-05-10 07:56:13 UTC
Created attachment 637352 [details]
emerge-info.txt
Comment 2 Toralf Förster gentoo-dev 2020-05-10 07:56:16 UTC
Created attachment 637354 [details]
emerge-history.txt
Comment 3 Toralf Förster gentoo-dev 2020-05-10 07:56:19 UTC
Created attachment 637356 [details]
environment
Comment 4 Toralf Förster gentoo-dev 2020-05-10 07:56:21 UTC
Created attachment 637358 [details]
etc.portage.tbz2
Comment 5 Toralf Förster gentoo-dev 2020-05-10 07:56:24 UTC
Created attachment 637360 [details]
sys-fs:bcache-tools-1.0.8_p20140220-r1:20200510-042339.log
Comment 6 Toralf Förster gentoo-dev 2020-05-10 07:56:28 UTC
Created attachment 637362 [details]
temp.tbz2
Comment 7 Jan Psota 2020-07-08 20:38:23 UTC
Same here :-(
Comment 8 Alec Moskvin 2020-07-08 22:40:58 UTC
(In reply to Jan Psota from comment #7)
> Same here :-(

It works with gcc-9
Comment 9 Jan Psota 2020-07-09 07:00:19 UTC
> It works with gcc-9
Thank you! :-)
...but it is only @preserved-rebuild :-D
Comment 10 strites 2020-07-14 13:20:30 UTC
Created attachment 649160 [details, diff]
/etc/portage/patches/sys-fs/bcache-tools-1.0.8_p20140220-r1/gcc10.patch

patch compiled (need to create a separate env file for EAPI=5

patch replicates this
https://github.com/g2p/bcache-tools/pull/24/commits/881cbd282edad30ce8ff395aedbe35a8bd145915
Comment 11 strites 2020-07-14 13:21:11 UTC
Created attachment 649162 [details]
/etc/portage/env/sys-fs/bcache-tools-1.0.8_p20140220-r1

env file (put in the named path)
Comment 12 Rafal Kupiec 2020-07-22 14:20:13 UTC
Same here, does not build with GCC 10.
Can this be finally fixed?
Comment 13 strites 2020-08-05 09:47:23 UTC
Rafal you can use my 2 files to have it compile under gcc10
Comment 14 Alec Moskvin 2020-09-25 00:58:26 UTC
Toralf, could you please make this block Bug 706426 (gcc-10)?
Comment 15 Kai Krakow 2020-09-25 19:41:34 UTC
Also fails in gcc-9.3 for me with the same problem, so it's maybe not a gcc-10 issue?
Comment 16 Sergei Trofimovich (RETIRED) gentoo-dev 2020-09-25 21:47:19 UTC
bcache ebuild should probably stop setting old c standard via '/^CFLAGS/s:-g:-std=gnu99:' and should define out-of-line crc64() version with 'extern inline' declaration: https://en.cppreference.com/w/c/language/inline (it's somewhat done upstream, but it could be improved slighly).

gcc-10's fault here is probably only due to slight inliner change. gcc-9 and older are probably also affected on slightly different optimization flags.
Comment 17 Alec Moskvin 2020-09-25 22:06:23 UTC
Or, maybe someone could bump it to 1.1 and we have to worry about how to fix this six year old snapshot (I have a PR for it :)
Comment 18 Sergei Trofimovich (RETIRED) gentoo-dev 2020-09-25 22:22:01 UTC
Ah, i didn't realize -9999 points to unmaintained tree. Yeah, https://git.kernel.org/pub/scm/linux/kernel/git/colyli/bcache-tools.git/ fixes inline annotations for crc64().
Comment 19 Larry the Git Cow gentoo-dev 2020-09-25 22:28:29 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c1d32d59c7cb7d8ef7351e1c64575ac780e8d1b7

commit c1d32d59c7cb7d8ef7351e1c64575ac780e8d1b7
Author:     Alec Moskvin <alecm@gmx.com>
AuthorDate: 2020-09-12 16:26:11 +0000
Commit:     Sergei Trofimovich <slyfox@gentoo.org>
CommitDate: 2020-09-25 22:28:23 +0000

    sys-fs/bcache-tools: version bump to 1.1
    
    Closes: https://bugs.gentoo.org/722002
    Closes: https://bugs.gentoo.org/656884
    Signed-off-by: Alec Moskvin <alecm@gmx.com>
    Closes: https://github.com/gentoo/gentoo/pull/17510
    Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>

 sys-fs/bcache-tools/Manifest                       |   1 +
 sys-fs/bcache-tools/bcache-tools-1.1.ebuild        |  70 ++++
 .../files/1.1/bcache-tools-add-bcache-status.patch | 381 +++++++++++++++++++++
 ...bcache-tools-add-man-page-bcache-status.8.patch |  69 ++++
 4 files changed, 521 insertions(+)