x86_64-pc-linux-gnu-gcc -o brushlib/mypaint-brush.os -c -O2 -pipe -march=native -Wformat -Werror=format-security -std=c99 -D_POSIX_C_SOURCE=200809L -fopenmp -O3 -O2 -pipe -march=native -Wformat -Werror=format-security -Wall -g -fPIC -DHAVE_JSON_C -DHAVE_GETTEXT -Ibrushlib -I/usr/include/json-c brushlib/mypaint-brush.c brushlib/mypaint-brush.c: In function mypaint_brush_new: brushlib/mypaint-brush.c:126:26: error: FALSE undeclared (first use in this function) 126 | self->print_inputs = FALSE; | ^~~~~ brushlib/mypaint-brush.c:126:26: note: each undeclared identifier is reported only once for each function it appears in ------------------------------------------------------------------- This is an unstable amd64 chroot image at a tinderbox (==build bot) name: 17.1_desktop_gnome_systemd-libressl-20200430-031932 ------------------------------------------------------------------- gcc-config -l: [1] x86_64-pc-linux-gnu-9.3.0 * clang version 10.0.0 Target: x86_64-pc-linux-gnu Thread model: posix InstalledDir: /usr/lib/llvm/10/bin /usr/lib/llvm/10 10.0.0 Available Python interpreters, in order of preference: [1] python3.6 [2] python3.8 [3] python3.7 (fallback) [4] python2.7 (fallback) Available Ruby profiles: [1] ruby24 (with Rubygems) [2] ruby25 (with Rubygems) * Available Rust versions: [1] rust-bin-1.43.0 * The following VMs are available for generation-2: *) AdoptOpenJDK 8.252_p09 [openjdk-bin-8] Available Java Virtual Machines: [1] openjdk-bin-8 system-vm timestamp(s) of HEAD at this tinderbox image: /var/db/repos/gentoo Thu 07 May 2020 02:05:15 AM UTC /var/db/repos/libressl Sat 11 Apr 2020 05:02:25 AM UTC emerge -qpvO media-gfx/mypaint [ebuild N ] media-gfx/mypaint-1.2.1-r5 PYTHON_SINGLE_TARGET="python2_7"
Created attachment 636632 [details] emerge-info.txt
Created attachment 636634 [details] emerge-history.txt
Created attachment 636636 [details] environment
Created attachment 636638 [details] etc.portage.tbz2
Created attachment 636640 [details] media-gfx:mypaint-1.2.1-r5:20200507-023705.log
Created attachment 636642 [details] temp.tbz2
This has to do with the json-c version you are compiling against. mypaint built just fine on my system, until I switched to json-c 0.14-r2 See also this bug report on cryptsetup: Bug 723232 I've confirmed this by downgrading json-c to 0.13.1-r1 after which mypaint compiled just fine again. You might want to update the title of your bug report.
Created attachment 639330 [details, diff] Patch that fixes the build failure caused by missing boolean definitions I have created a patch, by taking a commit from the libmypaint repository that addresses this issue and modified it for the mypaint ebuild. I tested this patch by adding it to: /etc/portage/patches/media-gfx/mypaint-1.2.1-r5/ Now mypaint builds with both the old and new json-c versions. (admittedly, this ebuild is way behind the current state of mypaint, but as you've indicated yourself, apparently this project is in need of a maintainer)
(In reply to Bas Weelinck from comment #8) > Created attachment 639330 [details, diff] [details, diff] > Patch that fixes the build failure caused by missing boolean definitions > > I have created a patch, by taking a commit from the libmypaint repository > that addresses this issue and modified it for the mypaint ebuild. > > I tested this patch by adding it to: > /etc/portage/patches/media-gfx/mypaint-1.2.1-r5/ > > Now mypaint builds with both the old and new json-c versions. I confirm that on my system. Can we get the patch into Gentoo, please?
Bas, thanks for providing the patch here. I submitted a pull request for adding this in the repository.
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c7e9406d31735f3eebac889d3326fa96f690317f commit c7e9406d31735f3eebac889d3326fa96f690317f Author: Jakov Smolic <jakov.smolic@sartura.hr> AuthorDate: 2020-05-25 08:09:56 +0000 Commit: Joonas Niilola <juippis@gentoo.org> CommitDate: 2020-06-17 17:00:25 +0000 media-gfx/mypaint: fix build failure The added patch fixes build failure caused by missing boolean definition when building with new json-c versions. Closes: https://bugs.gentoo.org/721388 Package-Manager: Portage-2.3.99, Repoman-2.3.22 Signed-off-by: Jakov Smolic <jakov.smolic@sartura.hr> Closes: https://github.com/gentoo/gentoo/pull/15959 Signed-off-by: Joonas Niilola <juippis@gentoo.org> .../files/mypaint-1.2.1-json-c-boolean-defs.patch | 34 ++++++++++++++++++++++ media-gfx/mypaint/mypaint-1.2.1-r5.ebuild | 3 ++ 2 files changed, 37 insertions(+)
