Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 720150 - [TRACKER] x11-libs/libXxf86misc removal
Summary: [TRACKER] x11-libs/libXxf86misc removal
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo X packagers
URL:
Whiteboard:
Keywords: PMASKED, Tracker
Depends on: 720152 720154 720156 720158
Blocks:
  Show dependency tree
 
Reported: 2020-04-30 17:46 UTC by Matt Turner
Modified: 2020-06-08 17:29 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Turner gentoo-dev 2020-04-30 17:46:57 UTC
Xserver support has been gone for 10+ years. This package should be removed. Fortunately there are only a few reverse dependencies.
Comment 1 Larry the Git Cow gentoo-dev 2020-05-08 05:34:00 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=34d6bc41a9e5fb8417b3a63f9391057717406a23

commit 34d6bc41a9e5fb8417b3a63f9391057717406a23
Author:     Matt Turner <mattst88@gentoo.org>
AuthorDate: 2020-05-08 05:32:50 +0000
Commit:     Matt Turner <mattst88@gentoo.org>
CommitDate: 2020-05-08 05:32:50 +0000

    profile: Mask x11-libs/libXxf86misc for removal
    
    Bug: https://bugs.gentoo.org/720150
    Signed-off-by: Matt Turner <mattst88@gentoo.org>

 profiles/package.mask | 5 +++++
 1 file changed, 5 insertions(+)
Comment 2 Sophie Hamilton 2020-05-10 16:01:30 UTC
Given this change and the subsequent patch added in =x11-misc/xscreensaver-5.43-r3, am I right in thinking that this would re-allow an attack like https://who-t.blogspot.com/2012/01/xkb-breaking-grabs-cve-2012-0064.html for users running xscreensaver?

I mean, I know that general security wisdom is that if anyone has physical access to your box then you've lost anyway, but if there an alternative screensaver that would stop these keys, or is it not worth trying to defend against?
Comment 3 Matt Turner gentoo-dev 2020-05-10 17:59:37 UTC
(In reply to Sophie Hamilton from comment #2)
> Given this change and the subsequent patch added in
> =x11-misc/xscreensaver-5.43-r3, am I right in thinking that this would
> re-allow an attack like
> https://who-t.blogspot.com/2012/01/xkb-breaking-grabs-cve-2012-0064.html for
> users running xscreensaver?
> 
> I mean, I know that general security wisdom is that if anyone has physical
> access to your box then you've lost anyway, but if there an alternative
> screensaver that would stop these keys, or is it not worth trying to defend
> against?

Support for the XF86MISC extension was removed from the Xserver in version 1.6.0, released February 2009. The libXxf86misc library is the client-side library for talking that protocol. Without server-side support, the client-side library cannot be useful.

I don't know the specifics of that bug, but I don't think it's possible that removing a client-side library without server-side support could do anything, much less reintroduce a security vulnerability.

FWIW, I just looked through the patches Fedora has for xscreensaver (since they stopped building xscreensaver against libXxf86misc in F31) to see if they had anything that looked security-related. I didn't see anything but regular old bug fixes (https://src.fedoraproject.org/rpms/xscreensaver/tree/master).
Comment 4 Larry the Git Cow gentoo-dev 2020-06-08 17:29:16 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ba5e02f695749d59f23840ce6602cdc52ec7c720

commit ba5e02f695749d59f23840ce6602cdc52ec7c720
Author:     Matt Turner <mattst88@gentoo.org>
AuthorDate: 2020-06-08 17:28:10 +0000
Commit:     Matt Turner <mattst88@gentoo.org>
CommitDate: 2020-06-08 17:28:58 +0000

    x11-libs/libXxf86misc: Remove
    
    Closes: https://bugs.gentoo.org/720150
    Signed-off-by: Matt Turner <mattst88@gentoo.org>

 profiles/package.mask                           |  5 -----
 x11-libs/libXxf86misc/Manifest                  |  1 -
 x11-libs/libXxf86misc/libXxf86misc-1.0.4.ebuild | 15 ---------------
 x11-libs/libXxf86misc/metadata.xml              |  8 --------
 4 files changed, 29 deletions(-)