Due to a bug in the upstream CMakeLists.txt, USE="-threads" doesn't actually makes libvncserver to be compiled without pthreads support. Reproducible: Always Steps to Reproduce: 1.emerge with USE="-threads" Actual Results: The library will be built with pthreads support regardless of the USE flag as long as C library will have pthreads support. Namely: - /usr/include/rfb/rfbconfig.h will contain: #define LIBVNCSERVER_HAVE_LIBPTHREAD 1 and /usr/lib/libvncserver.so will be linked against libpthreads Expected Results: net-libs/libvncserver should have no pthreads support Upstream already fixed the issue: https://github.com/LibVNC/libvncserver/commit/48c3ce30dfd7761c6d1718f0c021a0c5cdbbc494 See also #715964
Created attachment 629244 [details, diff] Suggested patch Note that the patch requires #715964[1] to be fix first, otherwise it might result in build failures or runtime issues. [1]: https://bugs.gentoo.org/715964
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=0220c0523306b9f439f4a2a2dd27d81b1a55ebcb commit 0220c0523306b9f439f4a2a2dd27d81b1a55ebcb Author: Alexander Tsoy <alexander@tsoy.me> AuthorDate: 2020-06-14 22:19:48 +0000 Commit: Thomas Deutschmann <whissi@gentoo.org> CommitDate: 2020-06-20 20:30:49 +0000 net-libs/libvncserver: Version bump to 0.9.13 Closes: https://bugs.gentoo.org/715964 Closes: https://bugs.gentoo.org/715968 Bug: https://bugs.gentoo.org/728594 Signed-off-by: Alexander Tsoy <alexander@tsoy.me> Closes: https://github.com/gentoo/gentoo/pull/16245 Signed-off-by: Thomas Deutschmann <whissi@gentoo.org> net-libs/libvncserver/Manifest | 1 + net-libs/libvncserver/libvncserver-0.9.13.ebuild | 71 ++++++++++++++++++++++++ net-libs/libvncserver/metadata.xml | 3 +- 3 files changed, 74 insertions(+), 1 deletion(-)
