Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 715964 - net-libs/libvncserver-0.9.12-r5: missing USE flags for WITH_SDL, WITH_TIGHTVNC_FILETRANSFER, WITH_WEBSOCKETS
Summary: net-libs/libvncserver-0.9.12-r5: missing USE flags for WITH_SDL, WITH_TIGHTVN...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Alexander Tsoy
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2020-04-03 01:58 UTC by Fat-Zer
Modified: 2020-06-20 20:31 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Fat-Zer 2020-04-03 01:58:07 UTC
subj; All the features are enabled by default.

 - WITH_SDL=ON results in an automagical dependency upon media-libs/libsdl2.
 - WITH_TIGHTVNC_FILETRANSFER=ON should require USE="threads"

Reproducible: Always
Comment 1 Alexander Tsoy 2020-04-03 07:25:16 UTC
WITH_SDL: we don't build examples, so WITH_SDL do nothing.
Comment 2 Fat-Zer 2020-04-03 07:57:37 UTC
(In reply to Alexander Tsoy from comment #1)
> WITH_SDL: we don't build examples, so WITH_SDL do nothing.

Good catch, but it would be nice to add -DWITH_SDL=OFF to the ebuild anyway to prevent searching for it and to avoid confusion...

And actually we do build examples, we just don't install them, I was going to report it too, but didn't want to nag about unnecessary excessive compilation ;) 
Although as far as you brougt it up, you might want to add `EXCLUDE_FROM_ALL` to the apropriate `add_executable` statements or whatever...
Comment 3 Alexander Tsoy 2020-06-14 23:18:23 UTC
(In reply to Fat-Zer from comment #2)
> And actually we do build examples, we just don't install them, I was going
> to report it too, but didn't want to nag about unnecessary excessive
> compilation ;) 
Thanks! Good catch. I will look into it later, or maybe just report it upstream.
Comment 4 Larry the Git Cow gentoo-dev 2020-06-20 20:31:01 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=0220c0523306b9f439f4a2a2dd27d81b1a55ebcb

commit 0220c0523306b9f439f4a2a2dd27d81b1a55ebcb
Author:     Alexander Tsoy <alexander@tsoy.me>
AuthorDate: 2020-06-14 22:19:48 +0000
Commit:     Thomas Deutschmann <whissi@gentoo.org>
CommitDate: 2020-06-20 20:30:49 +0000

    net-libs/libvncserver: Version bump to 0.9.13
    
    Closes: https://bugs.gentoo.org/715964
    Closes: https://bugs.gentoo.org/715968
    Bug: https://bugs.gentoo.org/728594
    Signed-off-by: Alexander Tsoy <alexander@tsoy.me>
    Closes: https://github.com/gentoo/gentoo/pull/16245
    Signed-off-by: Thomas Deutschmann <whissi@gentoo.org>

 net-libs/libvncserver/Manifest                   |  1 +
 net-libs/libvncserver/libvncserver-0.9.13.ebuild | 71 ++++++++++++++++++++++++
 net-libs/libvncserver/metadata.xml               |  3 +-
 3 files changed, 74 insertions(+), 1 deletion(-)