Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 713976 - net-fs/davfs2-1.5.6 : cache.c: fatal error: error.h: No such file or directory
Summary: net-fs/davfs2-1.5.6 : cache.c: fatal error: error.h: No such file or directory
Status: CONFIRMED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo musl team
URL: https://savannah.nongnu.org/bugs/?58100
Whiteboard:
Keywords: PATCH
Depends on:
Blocks: missing-musl-includes
  Show dependency tree
 
Reported: 2020-03-22 12:46 UTC by Toralf Förster
Modified: 2020-11-24 21:54 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
emerge-info.txt (emerge-info.txt,17.13 KB, text/plain)
2020-03-22 12:46 UTC, Toralf Förster
Details
emerge-history.txt (emerge-history.txt,269.29 KB, text/plain)
2020-03-22 12:46 UTC, Toralf Förster
Details
environment (environment,21.52 KB, text/plain)
2020-03-22 12:47 UTC, Toralf Förster
Details
etc.portage.tbz2 (etc.portage.tbz2,20.72 KB, application/x-bzip)
2020-03-22 12:47 UTC, Toralf Förster
Details
logs.tbz2 (logs.tbz2,10.47 KB, application/x-bzip)
2020-03-22 12:47 UTC, Toralf Förster
Details
net-fs:davfs2-1.5.6:20200322-104552.log (net-fs:davfs2-1.5.6:20200322-104552.log,14.36 KB, text/plain)
2020-03-22 12:47 UTC, Toralf Förster
Details
temp.tbz2 (temp.tbz2,10.01 KB, application/x-bzip)
2020-03-22 12:47 UTC, Toralf Förster
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Toralf Förster gentoo-dev 2020-03-22 12:46:54 UTC
make[2]: Entering directory /var/tmp/portage/net-fs/davfs2-1.5.6/work/davfs2-1.5.6/src
x86_64-gentoo-linux-musl-gcc -DPROGRAM_NAME=\mount.davfs\ -DDAV_SYS_CONF_DIR=\/etc/davfs2\ -DDAV_LOCALSTATE_DIR=\/var/run\ -DDAV_SYS_RUN=\/var/run/mount.davfs\ -DDAV_SYS_CACHE=\/var/cache/davfs2\ -DDAV_SECRETS=\secrets\ -DDAV_CONFIG=\davfs2.conf\ -DDAV_CERTS_DIR=\certs\ -DDAV_CLICERTS_DIR=\private\ -DDAV_DATA_DIR=\/usr/share/davfs2\ -DLOCALEDIR=\/usr/share/locale\ -DDAV_USER=\davfs2\ -DDAV_GROUP=\davfs2\ -D_FORTIFY_SOURCE=2 -DHAVE_CONFIG_H -I. -I..    -Wall -Werror=format-security -fstack-protector-strong --param=ssp-buffer-size=4 -O2 -pipe -march=native -fno-common -falign-functions=32:25:16 -I/usr/include/neon -c -o cache.o cache.c
cache.c:27:10: fatal error: error.h: No such file or directory
   27 | #include <error.h>
      |          ^~~~~~~~~
compilation terminated.

  -------------------------------------------------------------------

  This is an unstable amd64 chroot image at a tinderbox (==build bot)
  name: 17.0_musl-20200316-165821

  -------------------------------------------------------------------

  Please see the tracker bug for details.

gcc-config -l:
 [1] x86_64-gentoo-linux-musl-9.3.0 *
clang version 10.0.0 
Target: x86_64-gentoo-linux-musl
Thread model: posix
InstalledDir: /usr/lib/llvm/10/bin
/usr/lib/llvm/10
10.0.0
Available Python interpreters, in order of preference:
  [1]   python3.8
  [2]   python3.7
  [3]   python3.6
  [4]   python2.7 (fallback)
Available Ruby profiles:
  [1]   ruby24 (with Rubygems)
  [2]   ruby25 (with Rubygems) *
Available Rust versions:
  [1]   rust-1.41.1 *

timestamp of HEAD at this tinderbox image:
/var/db/repos/gentoo	Sun Mar 22 09:14:19 UTC 2020
/var/db/repos/musl	Sun Mar 22 03:12:57 UTC 2020

emerge -qpvO net-fs/davfs2
[ebuild  N    ] net-fs/davfs2-1.5.6  USE="nls"
Comment 1 Toralf Förster gentoo-dev 2020-03-22 12:46:57 UTC
Created attachment 624398 [details]
emerge-info.txt
Comment 2 Toralf Förster gentoo-dev 2020-03-22 12:46:59 UTC
Created attachment 624400 [details]
emerge-history.txt
Comment 3 Toralf Förster gentoo-dev 2020-03-22 12:47:03 UTC
Created attachment 624402 [details]
environment
Comment 4 Toralf Förster gentoo-dev 2020-03-22 12:47:06 UTC
Created attachment 624404 [details]
etc.portage.tbz2
Comment 5 Toralf Förster gentoo-dev 2020-03-22 12:47:08 UTC
Created attachment 624406 [details]
logs.tbz2
Comment 6 Toralf Förster gentoo-dev 2020-03-22 12:47:11 UTC
Created attachment 624408 [details]
net-fs:davfs2-1.5.6:20200322-104552.log
Comment 7 Toralf Förster gentoo-dev 2020-03-22 12:47:14 UTC
Created attachment 624410 [details]
temp.tbz2
Comment 9 Göktürk Yüksek archtester gentoo-dev 2020-11-24 21:54:14 UTC
(In reply to Sam James from comment #8)
> https://git.alpinelinux.org/aports/tree/community/davfs2/100-musl-compat.
> patch
> 
I'm a little reluctant to take this patch. For the most part it looks OK but I don't fully grasp the security implications of it. On my system, _PATH_MOUNTED is defined as "/etc/mtab", which itself is a symlink for "/proc/self/mounts". The patch sets _PATH_MOUNTED to "/proc/mounts". I'm not sure if that makes a difference with user namespaces etc.

Also, just to emulate canonicalize_file_name, it allocates a whole page and calls realpath on it. I don't think this code is on the hot path, so maybe it's not a big deal but there are about 5 references to canonicalize_file_name, why not just fix those?

> non-musl(?):
> https://git.alpinelinux.org/aports/tree/community/davfs2/010-main_code_fix.
> patch
This patch doesn't accurately implement rpmatch. There is a package called rpmatch-standalone, so this is not a big issue.

Someone already dropped these patches upstream (https://savannah.nongnu.org/bugs/?58100). I'd rather wait for the upstream to merge it because it looks like he has concerns too.