Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 712114 - dev-vcs/{hg{subversion,svn,view},mercurial-server,tortoisehg}: need py3 port
Summary: dev-vcs/{hg{subversion,svn,view},mercurial-server,tortoisehg}: need py3 port
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Deadline: 2020-04-10
Assignee: No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it
URL:
Whiteboard:
Keywords: PMASKED
: 712116 712118 (view as bug list)
Depends on:
Blocks: py3-tracker, python-3-incompatible
  Show dependency tree
 
Reported: 2020-03-11 06:25 UTC by Michał Górny
Modified: 2020-04-19 07:15 UTC (History)
5 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
ebuild for tortoisehg 5.3.1 (tortoisehg-5.3.1.ebuild,1.99 KB, text/plain)
2020-03-20 19:41 UTC, yarma
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2020-03-11 06:25:15 UTC
Please port to py3 or lastrite.
Comment 1 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2020-03-11 06:29:26 UTC
*** Bug 712116 has been marked as a duplicate of this bug. ***
Comment 2 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2020-03-11 06:29:31 UTC
*** Bug 712118 has been marked as a duplicate of this bug. ***
Comment 3 Larry the Git Cow gentoo-dev 2020-03-11 06:35:32 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=797388f33ffb34b32c2d7e70efd58b00093e4cdc

commit 797388f33ffb34b32c2d7e70efd58b00093e4cdc
Author:     Michał Górny <mgorny@gentoo.org>
AuthorDate: 2020-03-11 06:32:39 +0000
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: 2020-03-11 06:35:26 +0000

    package.mask: Last rite m-needed dev-vcs/{*hg*,mercurial-server}
    
    Bug: https://bugs.gentoo.org/712114
    Signed-off-by: Michał Górny <mgorny@gentoo.org>

 profiles/package.mask | 10 ++++++++++
 1 file changed, 10 insertions(+)
Comment 4 Reva Denis 2020-03-13 12:48:30 UTC
Hi! I'm ready to be Gentoo maintainer, but I can't port ones to python 3, it depends on upstream.
I'm using that package.
Comment 5 Reva Denis 2020-03-13 12:52:43 UTC
Ok, it seems that current upstream is close to getting python3 support
https://bitbucket.org/tortoisehg/thg/commits/
But I can't find source code archives, only commits.
Comment 6 Reva Denis 2020-03-13 12:54:23 UTC
Found new source code storage https://bitbucket.org/tortoisehg/targz/downloads/
Comment 7 yarma 2020-03-20 19:41:42 UTC
Created attachment 623410 [details]
ebuild for tortoisehg 5.3.1

I made some changes in the tortoisehg-5.0.2.ebuild so it can now build with the new 5.3.1 revision (working with python 3)
Comment 8 Thomas Capricelli 2020-03-28 01:10:39 UTC
I tried the attached ebuild, but modified with PYTHON_COMPAT=( python3_6 python3_7 ) (as i'm still on 3.6)

It fails at the end with this. It doesn't seem to be related to 3.6/3.7. For information,

ls -l /var/tmp/portage/dev-vcs/tortoisehg-5.3.1/image/usr/lib:
totale 0
drwxr-xr-x 3 root root 60 28 mar 02.01 python-exec



copying icons/16x16/mimetypes/text-x-generic.png -> /var/tmp/portage/dev-vcs/tortoisehg-5.3.1/image/_python3.6/usr/share/pixmaps/tortoisehg/icons/16x16/mimetypes
creating /var/tmp/portage/dev-vcs/tortoisehg-5.3.1/image/_python3.6/usr/share/nautilus-python
creating /var/tmp/portage/dev-vcs/tortoisehg-5.3.1/image/_python3.6/usr/share/nautilus-python/extensions
copying contrib/nautilus-thg.py -> /var/tmp/portage/dev-vcs/tortoisehg-5.3.1/image/_python3.6/usr/share/nautilus-python/extensions
running install_egg_info
Writing /var/tmp/portage/dev-vcs/tortoisehg-5.3.1/image/_python3.6/usr/lib64/python3.6/site-packages/tortoisehg-5.3.1-py3.6.egg-info
 * Using python3.6 in global scope
 * python3_6: running distutils-r1_run_phase python_install_all
rm: impossibile rimuovere '/var/tmp/portage/dev-vcs/tortoisehg-5.3.1/image/usr/lib/python3.6/site-packages/hgext3rd/__init__.py*': File o directory non esistente
 * ERROR: dev-vcs/tortoisehg-5.3.1::freehackers failed (install phase):
 *   (no error message)
 *
Comment 9 Mantas 2020-03-29 15:47:09 UTC
For me attached ebuild works with python3.7
Comment 10 Bill Binder 2020-04-05 18:39:01 UTC
(In reply to Thomas Capricelli from comment #8)

I also got the error when I added python3_6 to PYTHON_COMPAT.

 * Using python3.6 in global scope
 * python3_6: running distutils-r1_run_phase python_install_all
rm: cannot remove '/var/tmp/portage/dev-vcs/tortoisehg-5.3.1/image/usr/lib/python3.6/site-packages/hgext3rd/__init__.py*': No such file or directory

The python_install_all function in the ebuild tries to remove two paths which don't exist: 

    # Remove file that collides with >=mercurial-4.0 (bug #599266).
    rm "${ED}"/usr/lib/${EPYTHON}/site-packages/hgext3rd/__init__.py* \
        || die
    rm -rf "${ED}"/usr/lib/${EPYTHON}/site-packages/hgext3rd/__pycache__ \
        || die

Tried without the rm and it reported collisions with dev-vcs/mercurial-5.3.1: 

   * Detected file collision(s):
   * 
   *      /usr/lib64/python3.6/site-packages/hgext3rd/__init__.py
   *      /usr/lib64/python3.6/site-packages/hgext3rd/__pycache__/__init__.cpython-36.opt-2.pyc
   *      /usr/lib64/python3.6/site-packages/hgext3rd/__pycache__/__init__.cpython-36.opt-1.pyc
   *      /usr/lib64/python3.6/site-packages/hgext3rd/__pycache__/__init__.cpython-36.pyc

Problem is that the rm commands are assuming the location of the site-packages and its different 
- python3.6 : /usr/lib64/python3.6/site-packages
- python3.7 : /usr/lib64/python3.7/site-packages

so it works for python 3.7, but is wrong for 3.6. This worked for python 3.6 when I changed the ebuild to delete from lib64.

Is there a sane way to figure out where mercurial's site-packages dir is?
Comment 11 Bill Binder 2020-04-05 18:41:15 UTC
Sorry, copy/paste strikes again - I meant:
- python3.6 : /usr/lib64/python3.6/site-packages
- python3.7 : /usr/lib/python3.7/site-packages
Comment 12 Thomas Capricelli 2020-04-07 19:50:21 UTC
I have no idea. Is that 'normal' (expected) that python 3.6 and 3.7 use different paths on Gentoo ?

Seems weird to me.

I'm switching to python 3.7 as that seems the fastest way for met to get lot of mercurial stuff back.
Comment 13 Sergey Torokhov 2020-04-10 07:55:04 UTC
There is pull request [1] to version bump dev-vcs/tortoisehg-5.3.1 (python3 support) with new maintainer (via proxy-mantainer project).

[1] https://github.com/gentoo/gentoo/pull/14943
Comment 14 Larry the Git Cow gentoo-dev 2020-04-19 07:15:13 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b21a2ee9bc0b6beb200b75cedfde5f1ec1c301ef

commit b21a2ee9bc0b6beb200b75cedfde5f1ec1c301ef
Author:     Michał Górny <mgorny@gentoo.org>
AuthorDate: 2020-04-19 07:14:18 +0000
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: 2020-04-19 07:14:18 +0000

    dev-vcs/hgsubversion: Remove last-rited pkg
    
    Closes: https://bugs.gentoo.org/712114
    Signed-off-by: Michał Górny <mgorny@gentoo.org>

 dev-vcs/hgsubversion/Manifest                  |  1 -
 dev-vcs/hgsubversion/hgsubversion-1.9.2.ebuild | 33 --------------------------
 dev-vcs/hgsubversion/metadata.xml              |  9 -------
 profiles/package.mask                          |  1 -
 4 files changed, 44 deletions(-)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=90963adbb05c351e34a70901af59f2baa5687529

commit 90963adbb05c351e34a70901af59f2baa5687529
Author:     Michał Górny <mgorny@gentoo.org>
AuthorDate: 2020-04-19 07:13:45 +0000
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: 2020-04-19 07:13:45 +0000

    dev-vcs/hgsvn: Remove last-rited pkg
    
    Closes: https://bugs.gentoo.org/712114
    Signed-off-by: Michał Górny <mgorny@gentoo.org>

 dev-vcs/hgsvn/Manifest              |  1 -
 dev-vcs/hgsvn/hgsvn-0.2.3-r2.ebuild | 43 -------------------------------------
 dev-vcs/hgsvn/metadata.xml          |  9 --------
 profiles/package.mask               |  1 -
 4 files changed, 54 deletions(-)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=5a99ad4eb4614d7dcda841b3b5a98866fc158ac9

commit 5a99ad4eb4614d7dcda841b3b5a98866fc158ac9
Author:     Michał Górny <mgorny@gentoo.org>
AuthorDate: 2020-04-19 07:13:15 +0000
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: 2020-04-19 07:13:23 +0000

    dev-vcs/hgview: Remove last-rited pkg
    
    Closes: https://bugs.gentoo.org/712114
    Signed-off-by: Michał Górny <mgorny@gentoo.org>

 dev-vcs/hgview/Manifest               |  1 -
 dev-vcs/hgview/hgview-1.9.0-r1.ebuild | 52 -----------------------------------
 dev-vcs/hgview/metadata.xml           |  8 ------
 profiles/package.mask                 |  1 -
 4 files changed, 62 deletions(-)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c1e2593dc5e8de4db3a98e955ef913c27e447328

commit c1e2593dc5e8de4db3a98e955ef913c27e447328
Author:     Michał Górny <mgorny@gentoo.org>
AuthorDate: 2020-04-19 07:12:24 +0000
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: 2020-04-19 07:12:24 +0000

    dev-vcs/mercurial-server: Remove last-rited pkg
    
    Closes: https://bugs.gentoo.org/712114
    Signed-off-by: Michał Górny <mgorny@gentoo.org>

 dev-vcs/mercurial-server/Manifest                  |  1 -
 .../mercurial-server-1.2-r1.ebuild                 | 82 ----------------------
 .../mercurial-server/mercurial-server-9999.ebuild  | 82 ----------------------
 dev-vcs/mercurial-server/metadata.xml              | 10 ---
 profiles/package.mask                              |  1 -
 5 files changed, 176 deletions(-)