Created attachment 616918 [details] emerge --info PASS: test_check_nofork_teardown.sh PASS: test_check_nofork.sh PASS: test_xml_output.sh PASS: test_log_output.sh PASS: test_set_max_msg_size.sh PASS: test_tap_output.sh PASS: test_output.sh XPASS: check_check_export XPASS: check_check
Created attachment 616920 [details] test-suite.log
Created attachment 616922 [details] build.log
Same on sparc.
The reason for the emerge failure is that the test suite (tests/Makefile.am) is patched by the Gentoo maintainer to mark the tests `check_check` and `check_check_export` as XFAIL. This means, if the test succeed, they are counted as failures. Maybe this was a mistake and the Gentoo maintainer meant to mark the test as "test can fail and if so ignore the failure, if it succeeds thats ok, too". However, the automake manual [0] states that the success state is inverted, i.e. if `check_check` now succeeds the test suite fails. And that is what happens here. There is an old upstream issue [1], which mentions that the two tests check_check and check_check_export are quite resource heavy and thus are thrown to fail due to timeouts. However, there are no indicator that on today's "normal" hardware (whatever that means) this is an issue. I suggest to remove the patch and not mark the tests as XFAIL as this is the upstreams default. Instead I would issue a warning that these test can fail due to timeout and heavy load. Alternatively, if they are a problem for many machines, the test could be marked as skipped or removed completely. Workaround: You can workaround this by *not* applying the patch check-0.14-xfail-tests.patch in the ebuild (e.g. in a local overlay). [0] https://www.gnu.org/software/automake/manual/html_node/Scripts_002dbased-Testsuites.html [1] https://github.com/libcheck/check/issues/157
(In reply to gentoo_usr from comment #4) > The reason for the emerge failure is that the test suite (tests/Makefile.am) > is patched by the Gentoo maintainer to mark the tests `check_check` and > `check_check_export` as XFAIL. This means, if the test succeed, they are > counted as failures. > > Maybe this was a mistake and the Gentoo maintainer meant to mark the test as > "test can fail and if so ignore the failure, if it succeeds thats ok, too". > However, the automake manual [0] states that the success state is inverted, > i.e. if `check_check` now succeeds the test suite fails. And that is what > happens here. That's it, however the tests apparently then always failed for me, because I can't emerge this without the patch. And with the patch, it always "succeeds". Thus I haven't been able to reproduce this error. > > Workaround: > First I ended up just removing them with a patch, --- a/Makefile.am 2020-03-21 08:30:03.571251087 +0200 +++ b/Makefile.am 2020-03-21 08:30:53.400877511 +0200 @@ -1,8 +1,6 @@ ## Process this file with automake to produce Makefile.in TESTS = \ - check_check_export \ - check_check \ test_output.sh \ test_check_nofork.sh \ test_check_nofork_teardown.sh \ But now I rewrote the whole ebuild using CMake, since upstream has been moving towards building with CMake anyway. Tests pass for me when using CMake so I'm gonna push it and see what happens.
The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=6c5026b88f869f521d85d6a130982c2e92f63e75 commit 6c5026b88f869f521d85d6a130982c2e92f63e75 Author: Joonas Niilola <juippis@gentoo.org> AuthorDate: 2020-03-21 08:52:58 +0000 Commit: Joonas Niilola <juippis@gentoo.org> CommitDate: 2020-03-21 08:53:30 +0000 dev-libs/check: migrate to CMake, "fix" tests, revbump 0.14.0 Bug: https://bugs.gentoo.org/711390 Signed-off-by: Joonas Niilola <juippis@gentoo.org> dev-libs/check/check-0.14.0-r1.ebuild | 50 ++++++++++++++++++++++ .../check-0.14.0-r1-disable-automagic-dep.patch | 23 ++++++++++ 2 files changed, 73 insertions(+)
Thanks Joonas for acting so quickly and for your efforts converting the ebuild to use CMake. I've tested the new ebuild and it works fine on my platform (and all tests pass). I have two small remarks: * According to the option description of CHECK_ENABLE_TESTS (in CMakeLists.txt) that option is deprecated and BUILD_TESTING should be used instead. * The patch introducing the conditional dependency on subunit has non-matching if-then-else expressions. (The expression in parenthesis must match exactly the one used in the if-part). This seems strange for the else part as the if-condition is repeated, but that's how it is. You can can make that slightly less unpleasing by omitting the 'EQUALS 1' in the expression. I've attached both suggestions as a diff/patch series.
Created attachment 624150 [details, diff] [PATCH 1/3] dev-libs/check-0.14.0-r1: Do not use deprecated testing option
Created attachment 624152 [details, diff] [PATCH 2/3] dev-libs/check-0.14.0-r1: Fix warning in patched CMakeLists.txt
Created attachment 624154 [details, diff] [PATCH 3/3] dev-libs/check-0.14.0-r1: Streamline subunit-check
(In reply to gentoo_usr from comment #7) > > * According to the option description of CHECK_ENABLE_TESTS (in > CMakeLists.txt) that option is deprecated and BUILD_TESTING should be used > instead. Yeaa I saw it but got lazy to change after first one worked. CHECK_ENABLE_TESTS gets removed in 0.15.0 by upstream so it needed to be updated soon anyway. Thanks for the patches, I applied each one. Couldn't author you but I have feeling you don't mind... :)
The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=06d2b112fde3faca9767a93835c07009ada5b177 commit 06d2b112fde3faca9767a93835c07009ada5b177 Author: Joonas Niilola <juippis@gentoo.org> AuthorDate: 2020-03-23 13:12:07 +0000 Commit: Joonas Niilola <juippis@gentoo.org> CommitDate: 2020-03-23 13:13:50 +0000 dev-libs/check: update subunit logic, fix pkgconfig file - subunit & doc handling patches from #711390 - .pc libdir issue when using multilib #714058 Bug: https://bugs.gentoo.org/711390 Closes: https://bugs.gentoo.org/714058 Signed-off-by: Joonas Niilola <juippis@gentoo.org> dev-libs/check/check-0.14.0-r2.ebuild | 58 ++++++++++++++++++++++ .../check-0.14.0-r2-disable-automagic-dep.patch | 23 +++++++++ 2 files changed, 81 insertions(+)
Created attachment 638582 [details] 528233887.log build log on ppc64
Created attachment 638588 [details] LastTest.log LastTest.log on ppc64
