Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 710382 - sci-libs/ipopt-3.12.12 einstalldocs may not behave as intended
Summary: sci-libs/ipopt-3.12.12 einstalldocs may not behave as intended
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Science Related Packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-02-21 09:32 UTC by Ulrich Müller
Modified: 2022-07-29 10:12 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ulrich Müller gentoo-dev 2020-02-21 09:32:56 UTC
The ebuild has this in src_install:

	local HTML_DOCS DOCS
	use doc && HTML_DOCS=("${S}/doxydoc/html/.")
	use examples && DOCS+=( examples )
	einstalldocs

Looking at PMS algorithm 12.4, https://projects.gentoo.org/pms/7/pms.html#x1-135003r4, einstalldocs will install the default set of files "if the DOCS variable is unset". So the above may not behave as intended and install some files with USE="-examples".

I'd suggest to replace the snippet above by explicit calls to dodoc:

	use doc && dodoc -r doxydoc/html
	use examples && dodoc -r examples
Comment 1 Larry the Git Cow gentoo-dev 2022-01-11 14:37:42 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b918eb1a1f6e50a4a81d1400416486e2e9fd5ea7

commit b918eb1a1f6e50a4a81d1400416486e2e9fd5ea7
Author:     Andrew Ammerlaan <andrewammerlaan@gentoo.org>
AuthorDate: 2022-01-11 14:37:27 +0000
Commit:     Andrew Ammerlaan <andrewammerlaan@gentoo.org>
CommitDate: 2022-01-11 14:37:38 +0000

    sci-libs/ipopt: add version 3.14.4
    
    Closes: https://bugs.gentoo.org/804130
    Bug: https://bugs.gentoo.org/710382
    Package-Manager: Portage-3.0.30, Repoman-3.0.3
    Signed-off-by: Andrew Ammerlaan <andrewammerlaan@gentoo.org>

 sci-libs/ipopt/Manifest            |  1 +
 sci-libs/ipopt/ipopt-3.14.4.ebuild | 76 ++++++++++++++++++++++++++++++++++++++
 sci-libs/ipopt/metadata.xml        | 26 +++++++------
 3 files changed, 92 insertions(+), 11 deletions(-)
Comment 2 Andrew Ammerlaan gentoo-dev 2022-01-11 14:39:13 UTC
Version 3.14.4: Replaced the doc hacks with docs.eclass, installed the examples unconditionally since there is no reason not to.
Comment 3 Ulrich Müller gentoo-dev 2022-07-29 09:15:09 UTC
(In reply to Andrew Ammerlaan from comment #2)
> Version 3.14.4: Replaced the doc hacks with docs.eclass, installed the
> examples unconditionally since there is no reason not to.

Can this bug be closed then?
Comment 4 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-07-29 09:18:47 UTC
(In reply to Ulrich Müller from comment #3)
> (In reply to Andrew Ammerlaan from comment #2)
> > Version 3.14.4: Replaced the doc hacks with docs.eclass, installed the
> > examples unconditionally since there is no reason not to.
> 
> Can this bug be closed then?

A broken version is still in tree, so it's up to you as the reporter, I guess. Feel free to cleanup if depgraph allows.