Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 708098 - media-gfx/cropgui depends on dev-python/pygtk
Summary: media-gfx/cropgui depends on dev-python/pygtk
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Mikle Kolyada (RETIRED)
URL: https://github.com/jepler/cropgui/iss...
Whiteboard:
Keywords: PMASKED
Depends on:
Blocks: py3-tracker, python-3-incompatible pygtk-removal
  Show dependency tree
 
Reported: 2020-02-03 20:06 UTC by Andreas Sturmlechner
Modified: 2020-03-23 14:34 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
cropgui-0.4.ebuild (cropgui-0.4.ebuild,1.08 KB, text/plain)
2020-03-05 07:56 UTC, Hanno Böck
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Sturmlechner gentoo-dev 2020-02-03 20:06:48 UTC
It appears that git master is already ported to python-3, but a question about a new release is left unanswered for 2 months now.

Maybe it is time to checkout master and evaluate it for a snapshot?

(why is the latest version not stable?)
Comment 1 Andreas Sturmlechner gentoo-dev 2020-02-19 14:40:03 UTC
ping
Comment 2 Hanno Böck gentoo-dev 2020-03-05 07:56:09 UTC
Created attachment 617146 [details]
cropgui-0.4.ebuild

A proposal for an updated ebuild.

Replaced pygtk/pygobject deps with python 3 pygobject, updated EAPI, add desktop cache updating.

There was an undocumented sed command for the desktop file which was unclear to me what it was supposed to do, it caused a warning that the desktop file wasn't validating. I removed it for now.
The make_wrapper / python_newexe stuff looks strange to me, too (wonder why this isn't just python_newexe on cropgtk.py itself).

Python 3.8 causes a warning, so I only added 3.6/3.7 for now, sent a patch upstream [1].

Maybe not perfect, but should allow us to keep this package.

[1] https://github.com/jepler/cropgui/pull/64
Comment 3 Massimo Burcheri 2020-03-13 09:14:36 UTC
Compiled and working. Is this going to be released?
As of 0.4 please add this important integer scaling patch that was fixed after releasing 0.4:
https://github.com/jepler/cropgui/issues/68#issuecomment-597200719
https://github.com/jepler/cropgui/commit/d7eaf1fea625fe7fecd06edadaef1338202038ef
Comment 4 Larry the Git Cow gentoo-dev 2020-03-22 06:12:57 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c5bb261dd6dbbfaae42c7a0b413a40dbe0bb79c4

commit c5bb261dd6dbbfaae42c7a0b413a40dbe0bb79c4
Author:     Michał Górny <mgorny@gentoo.org>
AuthorDate: 2020-03-22 06:11:14 +0000
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: 2020-03-22 06:11:31 +0000

    media-gfx/cropgui: Remove last-rited pkg
    
    Closes: https://bugs.gentoo.org/708098
    Signed-off-by: Michał Górny <mgorny@gentoo.org>

 media-gfx/cropgui/Manifest                        |  2 -
 media-gfx/cropgui/cropgui-0.2-r1.ebuild           | 53 -----------------------
 media-gfx/cropgui/cropgui-0.3.ebuild              | 49 ---------------------
 media-gfx/cropgui/cropgui-9999.ebuild             | 39 -----------------
 media-gfx/cropgui/files/cropgui-0.2-PIL.patch     | 26 -----------
 media-gfx/cropgui/files/cropgui-0.2-tobytes.patch | 40 -----------------
 media-gfx/cropgui/metadata.xml                    | 11 -----
 profiles/package.mask                             |  6 ---
 8 files changed, 226 deletions(-)
Comment 5 Patrice Levesque 2020-03-22 06:17:50 UTC
Please consider re-adding cropgui; at version 0.4, it does not depend on dev-python/pygtk anymore.  New ebuild is attached to this bug and there is a community of users.
Comment 6 Hanno Böck gentoo-dev 2020-03-22 06:27:12 UTC
cropgui 0.4 has a few severe bugs and is basically not working (choosing the wrong picture area). I'm waiting for a new upstream 0.5 and will add it once it's ready.
Comment 7 Patrice Levesque 2020-03-22 06:46:56 UTC
(In reply to Hanno Böck from comment #6)
> cropgui 0.4 has a few severe bugs and is basically not working (choosing the
> wrong picture area). I'm waiting for a new upstream 0.5 and will add it once
> it's ready.

With patch from comment #3 I see no obvious issue after some usage.  You may prefer waiting for 0.5, that's your call, but may I suggest a masked -9999 version that's tied to github's master, since 0.5 will likely happen later than sooner?

Providing only a -9999 version seems acceptable for gentoo, as there are more than 100 packages in portage that only have a -9999 version (most of app-leechcraft/* is that way), and the main issue for media-gfx/cropgui removal (dev-python/pygtk) is now moot.
Comment 8 Larry the Git Cow gentoo-dev 2020-03-23 06:39:40 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b3360574b336c1e20185c43441170d170d59e877

commit b3360574b336c1e20185c43441170d170d59e877
Author:     Hanno Böck <hanno@gentoo.org>
AuthorDate: 2020-03-23 06:39:27 +0000
Commit:     Hanno Böck <hanno@gentoo.org>
CommitDate: 2020-03-23 06:39:27 +0000

    media-gfx/cropgui: Re-add cropgui.
    
    This version is python 3 compatible.
    
    Bug: https://bugs.gentoo.org/708098
    Signed-off-by: Hanno Böck <hanno@gentoo.org>
    Package-Manager: Portage-2.3.94, Repoman-2.3.21

 media-gfx/cropgui/Manifest             |  1 +
 media-gfx/cropgui/cropgui-0.4.1.ebuild | 45 ++++++++++++++++++++++++++++++++++
 media-gfx/cropgui/metadata.xml         | 11 +++++++++
 3 files changed, 57 insertions(+)
Comment 9 Hanno Böck gentoo-dev 2020-03-23 06:41:21 UTC
I asked upstream for a new release and it didn't take very long :-)
Comment 10 Patrice Levesque 2020-03-23 14:34:25 UTC
(In reply to Hanno Böck from comment #9)
> I asked upstream for a new release and it didn't take very long :-)

Awesome.  Thanks a lot for your efforts towards keeping cropgui alive in gentoo.