Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 707668 - media-libs/codec2-0.8.1 : fails to build with -fno-common or gcc-10
Summary: media-libs/codec2-0.8.1 : fails to build with -fno-common or gcc-10
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Sound Team
URL: https://github.com/drowe67/codec2/
Whiteboard:
Keywords: EBUILD, PullRequest
Depends on:
Blocks: -fno-common
  Show dependency tree
 
Reported: 2020-01-31 20:38 UTC by Toralf Förster
Modified: 2021-01-05 19:49 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
emerge-info.txt (emerge-info.txt,16.89 KB, text/plain)
2020-01-31 20:38 UTC, Toralf Förster
Details
emerge-history.txt (emerge-history.txt,228.59 KB, text/plain)
2020-01-31 20:38 UTC, Toralf Förster
Details
environment (environment,103.17 KB, text/plain)
2020-01-31 20:38 UTC, Toralf Förster
Details
etc.portage.tbz2 (etc.portage.tbz2,15.37 KB, application/x-bzip)
2020-01-31 20:38 UTC, Toralf Förster
Details
logs.tbz2 (logs.tbz2,4.52 KB, application/x-bzip)
2020-01-31 20:38 UTC, Toralf Förster
Details
media-libs:codec2-0.8.1:20200131-201809.log (media-libs:codec2-0.8.1:20200131-201809.log,65.56 KB, text/plain)
2020-01-31 20:38 UTC, Toralf Förster
Details
temp.tbz2 (temp.tbz2,30.82 KB, application/x-bzip)
2020-01-31 20:38 UTC, Toralf Förster
Details
codec2-0.9.2.ebuild (codec2-0.9.2.ebuild,630 bytes, text/plain)
2020-04-22 06:31 UTC, Jeroen Roovers (RETIRED)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Toralf Förster gentoo-dev 2020-01-31 20:38:30 UTC
FAILED: src/libcodec2.so.0.8 
: && /usr/bin/x86_64-pc-linux-gnu-gcc -fPIC -O2 -pipe -march=native -fno-common -Wall -g -O3 -fPIC  -Wl,-O1 -Wl,--as-needed -shared -Wl,-soname,libcodec2.so.0.8 -o src/libcodec2.so.0.8 src/CMakeFiles/codec2.dir/dump.c.o src/CMakeFiles/codec2.dir/lpc.c.o src/CMakeFiles/codec2.dir/nlp.c.o src/CMakeFiles/codec2.dir/postfilter.c.o src/CMakeFiles/codec2.dir/sine.c.o src/CMakeFiles/codec2.dir/codec2.c.o src/CMakeFiles/codec2.dir/codec2_fft.c.o src/CMakeFiles/codec2.dir/cohpsk.c.o src/CMakeFiles/codec2.dir/fifo.c.o src/CMakeFiles/codec2.dir/fdmdv.c.o src/CMakeFiles/codec2.dir/fm.c.o src/CMakeFiles/codec2.dir/fsk.c.o src/CMakeFiles/codec2.dir/fmfsk.c.o src/CMakeFiles/codec2.dir/tdma.c.o src/CMakeFiles/codec2.dir/kiss_fft.c.o src/CMakeFiles/codec2.dir/kiss_fftr.c.o src/CMakeFiles/codec2.dir/linreg.c.o src/CMakeFiles/codec2.dir/interp.c.o src/CMakeFiles/codec2.dir/lsp.c.o src/CMakeFiles/codec2.dir/mbest.c.o src/CMakeFiles/codec2.dir/newamp1.c.o src/CMakeFiles/codec2.dir/ofdm.c.o src/CMakeFiles/codec2.dir/phase.c.o src/CMakeFiles/codec2.dir/quantise.c.o src/CMakeFiles/codec2.dir/pack.c.o src/CMakeFiles/codec2.dir/codebook.c.o src/CMakeFiles/codec2.dir/codebookd.c.o src/CMakeFiles/codec2.dir/codebookjvm.c.o src/CMakeFiles/codec2.dir/codebookmel.c.o src/CMakeFiles/codec2.dir/codebooklspmelvq.c.o src/CMakeFiles/codec2.dir/codebookge.c.o src/CMakeFiles/codec2.dir/codebooknewamp1.c.o src/CMakeFiles/codec2.dir/codebooknewamp1_energy.c.o src/CMakeFiles/codec2.dir/golay23.c.o src/CMakeFiles/codec2.dir/freedv_api.c.o src/CMakeFiles/codec2.dir/freedv_vhf_framing.c.o src/CMakeFiles/codec2.dir/freedv_data_channel.c.o src/CMakeFiles/codec2.dir/varicode.c.o src/CMakeFiles/codec2.dir/modem_stats.c.o src/CMakeFiles/codec2.dir/c2wideband.c.o src/CMakeFiles/codec2.dir/dct2.c.o src/CMakeFiles/codec2.dir/mpdecode_core.c.o src/CMakeFiles/codec2.dir/gp_interleaver.c.o src/CMakeFiles/codec2.dir/interldpc.c.o  -lm && :
/usr/lib/gcc/x86_64-pc-linux-gnu/9.2.0/../../../../x86_64-pc-linux-gnu/bin/ld: src/CMakeFiles/codec2.dir/freedv_api.c.o:/var/tmp/portage/media-libs/codec2-0.8.1/work/codec2-0.8.1/src/codec2_ofdm.h:54: multiple definition of `OFDM_CONFIG_700D'; src/CMakeFiles/codec2.dir/ofdm.c.o:/var/tmp/portage/media-libs/codec2-0.8.1/work/codec2-0.8.1/src/codec2_ofdm.h:54: first defined here
/usr/lib/gcc/x86_64-pc-linux-gnu/9.2.0/../../../../x86_64-pc-linux-gnu/bin/ld: src/CMakeFiles/codec2.dir/interldpc.c.o:/var/tmp/portage/media-libs/codec2-0.8.1/work/codec2-0.8.1/src/codec2_ofdm.h:54: multiple definition of `OFDM_CONFIG_700D'; src/CMakeFiles/codec2.dir/ofdm.c.o:/var/tmp/portage/media-libs/codec2-0.8.1/work/codec2-0.8.1/src/codec2_ofdm.h:54: first defined here

  -------------------------------------------------------------------

  This is an unstable amd64 chroot image at a tinderbox (==build bot)
  name: 17.1_systemd-20200126-201521

  -------------------------------------------------------------------

  Please see the tracker bug for details.

gcc-config -l:
 [1] x86_64-pc-linux-gnu-9.2.0 *

clang:
clang version 9.0.1 
Target: x86_64-pc-linux-gnu
Thread model: posix
InstalledDir: /usr/lib/llvm/9/bin
llvm:
9.0.1
Available Python interpreters, in order of preference:
  [1]   python3.8
  [2]   python3.6
  [3]   python3.7 (fallback)
  [4]   python2.7 (fallback)
Available Ruby profiles:
  [1]   ruby24 (with Rubygems)
  [2]   ruby25 (with Rubygems) *
Available Rust versions:
  [1]   rust-1.40.0 *
java-config:
The following VMs are available for generation-2:
*)	AdoptOpenJDK 8.242_p08 [openjdk-bin-8]
Available Java Virtual Machines:
  [1]   openjdk-bin-8  system-vm
ghc:
The Glorious Glasgow Haskell Compilation System, version 8.0.2

repository:
==> /var/db/repos/gentoo/metadata/timestamp.chk <==
Fri, 31 Jan 2020 19:27:54 +0000

emerge -qpvO media-libs/codec2
[ebuild  N    ] media-libs/codec2-0.8.1  USE="-examples" ABI_X86="(64) -32 (-x32)"
Comment 1 Toralf Förster gentoo-dev 2020-01-31 20:38:33 UTC
Created attachment 610006 [details]
emerge-info.txt
Comment 2 Toralf Förster gentoo-dev 2020-01-31 20:38:36 UTC
Created attachment 610008 [details]
emerge-history.txt
Comment 3 Toralf Förster gentoo-dev 2020-01-31 20:38:39 UTC
Created attachment 610010 [details]
environment
Comment 4 Toralf Förster gentoo-dev 2020-01-31 20:38:42 UTC
Created attachment 610012 [details]
etc.portage.tbz2
Comment 5 Toralf Förster gentoo-dev 2020-01-31 20:38:45 UTC
Created attachment 610014 [details]
logs.tbz2
Comment 6 Toralf Förster gentoo-dev 2020-01-31 20:38:47 UTC
Created attachment 610016 [details]
media-libs:codec2-0.8.1:20200131-201809.log
Comment 7 Toralf Förster gentoo-dev 2020-01-31 20:38:50 UTC
Created attachment 610018 [details]
temp.tbz2
Comment 8 Jeroen Roovers (RETIRED) gentoo-dev 2020-04-22 06:30:54 UTC
.../ld: src/CMakeFiles/codec2.dir/freedv_api.c.o:/var/tmp/portage/media-libs/codec2-0.8.1/work/codec2-0.8.1/src/codec2_ofdm.h:54: multiple definition of `OFDM_CONFIG_700D'; src/CMakeFiles/codec2.dir/ofdm.c.o:/var/tmp/portage/media-libs/codec2-0.8.1/work/codec2-0.8.1/src/codec2_ofdm.h:54: first defined here

This is already fixed upstream through the removal of the OFDM_CONFIG_700D variable in subsequent releases. The latest release is 0.9.2.

HOMEPAGE refers to the [URL] these days.
Comment 9 Jeroen Roovers (RETIRED) gentoo-dev 2020-04-22 06:31:39 UTC
Created attachment 634042 [details]
codec2-0.9.2.ebuild
Comment 10 Azamat H. Hackimov 2020-07-02 21:13:14 UTC
src_install() can be entirely removed, they made -DINSTALL_EXAMPLES= option in CMake.

See my PR for other improvements https://github.com/gentoo/gentoo/pull/16551
Comment 11 Larry the Git Cow gentoo-dev 2020-08-08 16:55:27 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c9843a298647c9fd076a4fb54320cdf8a47466ae

commit c9843a298647c9fd076a4fb54320cdf8a47466ae
Author:     David Seifert <soap@gentoo.org>
AuthorDate: 2020-08-08 16:54:17 +0000
Commit:     David Seifert <soap@gentoo.org>
CommitDate: 2020-08-08 16:54:17 +0000

    media-libs/codec2: Fix building under -fno-common
    
    Closes: https://bugs.gentoo.org/707668
    Package-Manager: Portage-3.0.1, Repoman-2.3.23
    Signed-off-by: David Seifert <soap@gentoo.org>

 media-libs/codec2/codec2-0.8.1.ebuild                 |  5 ++++-
 media-libs/codec2/files/codec2-0.8.1-fno-common.patch | 11 +++++++++++
 2 files changed, 15 insertions(+), 1 deletion(-)
Comment 12 Larry the Git Cow gentoo-dev 2020-08-23 14:44:05 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ed1cb52a4622f1a2696a551149972bf786f9fb67

commit ed1cb52a4622f1a2696a551149972bf786f9fb67
Author:     Azamat H. Hackimov <azamat.hackimov@gmail.com>
AuthorDate: 2020-07-02 21:09:11 +0000
Commit:     Miroslav Šulc <fordfrog@gentoo.org>
CommitDate: 2020-08-23 14:43:51 +0000

    media-libs/codec2: update to 0.9.2
    
    Updated and simplified ebuild.
    Closes: https://bugs.gentoo.org/707668
    Package-Manager: Portage-2.3.99, Repoman-2.3.23
    Signed-off-by: Azamat H. Hackimov <azamat.hackimov@gmail.com>
    Closes: https://github.com/gentoo/gentoo/pull/16551
    Signed-off-by: Miroslav Šulc <fordfrog@gentoo.org>

 media-libs/codec2/Manifest            |  1 +
 media-libs/codec2/codec2-0.9.2.ebuild | 24 ++++++++++++++++++++++++
 media-libs/codec2/metadata.xml        |  3 +++
 3 files changed, 28 insertions(+)