Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 706910 - games-puzzle/freesweep-0.92-r1 : fails to build with -fno-common or gcc-10
Summary: games-puzzle/freesweep-0.92-r1 : fails to build with -fno-common or gcc-10
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Games
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks: -fno-common
  Show dependency tree
 
Reported: 2020-01-28 18:37 UTC by Toralf Förster
Modified: 2020-06-08 21:58 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
emerge-info.txt (emerge-info.txt,15.38 KB, text/plain)
2020-01-28 18:37 UTC, Toralf Förster
Details
emerge-history.txt (emerge-history.txt,54.04 KB, text/plain)
2020-01-28 18:37 UTC, Toralf Förster
Details
environment (environment,45.20 KB, text/plain)
2020-01-28 18:37 UTC, Toralf Förster
Details
etc.portage.tbz2 (etc.portage.tbz2,11.81 KB, application/x-bzip)
2020-01-28 18:37 UTC, Toralf Förster
Details
games-puzzle:freesweep-0.92-r1:20200128-085639.log (games-puzzle:freesweep-0.92-r1:20200128-085639.log,10.29 KB, text/plain)
2020-01-28 18:37 UTC, Toralf Förster
Details
logs.tbz2 (logs.tbz2,4.42 KB, application/x-bzip)
2020-01-28 18:37 UTC, Toralf Förster
Details
temp.tbz2 (temp.tbz2,13.59 KB, application/x-bzip)
2020-01-28 18:37 UTC, Toralf Förster
Details
Patch for sweep.h.in (sweep-h.patch,520 bytes, patch)
2020-02-04 20:21 UTC, Brandon Sakai
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Toralf Förster gentoo-dev 2020-01-28 18:37:03 UTC
x86_64-pc-linux-gnu-gcc -Wall -DVERSION=\"0.92\" -O2 -pipe -march=native -fno-common -c tick.c
x86_64-pc-linux-gnu-gcc -Wall -DVERSION=\"0.92\" -O2 -pipe -march=native -fno-common -c utils.c
x86_64-pc-linux-gnu-gcc -Wall -DVERSION=\"0.92\" -O2 -pipe -march=native -fno-common -c image.c
x86_64-pc-linux-gnu-gcc -Wall -DVERSION=\"0.92\" -O2 -pipe -march=native -fno-common clear.o drawing.o error.o fgui.o files.o game.o gpl.o main.o pbests.o play.o sl.o stats.o tick.o utils.o image.o -Wl,-O1 -Wl,--as-needed -lncurses -ltinfo  -o freesweep
/usr/lib/gcc/x86_64-pc-linux-gnu/9.2.0/../../../../x86_64-pc-linux-gnu/bin/ld: drawing.o:(.bss+0x0): multiple definition of `CharSet'; clear.o:(.bss+0x20): first defined here
/usr/lib/gcc/x86_64-pc-linux-gnu/9.2.0/../../../../x86_64-pc-linux-gnu/bin/ld: error.o:(.bss+0x0): multiple definition of `CharSet'; clear.o:(.bss+0x20): first defined here

  -------------------------------------------------------------------

  This is an unstable amd64 chroot image at a tinderbox (==build bot)
  name: 17.1_desktop_plasma-libressl-20200126-092715

  -------------------------------------------------------------------

  Please see the tracker bug for details.

gcc-config -l:
 [1] x86_64-pc-linux-gnu-9.2.0 *

clang:
clang version 9.0.1 
Target: x86_64-pc-linux-gnu
Thread model: posix
InstalledDir: /usr/lib/llvm/9/bin
llvm:
9.0.1
Available Python interpreters, in order of preference:
  [1]   python3.8
  [2]   python3.7 (uninstalled)
  [3]   python3.6
  [4]   python2.7 (fallback)
Available Ruby profiles:
  [1]   ruby24 (with Rubygems)
  [2]   ruby25 (with Rubygems) *
Available Rust versions:
  [1]   rust-1.40.0 *
java-config:
The following VMs are available for generation-2:
*)	IcedTea JDK 3.14.0 [icedtea-bin-8]
Available Java Virtual Machines:
  [1]   icedtea-bin-8  system-vm

repository:
==> /var/db/repos/gentoo/metadata/timestamp.chk <==
Tue, 28 Jan 2020 08:06:23 +0000

emerge -qpvO games-puzzle/freesweep
[ebuild  N    ] games-puzzle/freesweep-0.92-r1
Comment 1 Toralf Förster gentoo-dev 2020-01-28 18:37:07 UTC
Created attachment 606506 [details]
emerge-info.txt
Comment 2 Toralf Förster gentoo-dev 2020-01-28 18:37:11 UTC
Created attachment 606508 [details]
emerge-history.txt
Comment 3 Toralf Förster gentoo-dev 2020-01-28 18:37:14 UTC
Created attachment 606510 [details]
environment
Comment 4 Toralf Förster gentoo-dev 2020-01-28 18:37:17 UTC
Created attachment 606512 [details]
etc.portage.tbz2
Comment 5 Toralf Förster gentoo-dev 2020-01-28 18:37:20 UTC
Created attachment 606514 [details]
games-puzzle:freesweep-0.92-r1:20200128-085639.log
Comment 6 Toralf Förster gentoo-dev 2020-01-28 18:37:22 UTC
Created attachment 606516 [details]
logs.tbz2
Comment 7 Toralf Förster gentoo-dev 2020-01-28 18:37:25 UTC
Created attachment 606518 [details]
temp.tbz2
Comment 8 Brandon Sakai 2020-02-04 20:21:53 UTC
Created attachment 611730 [details, diff]
Patch for sweep.h.in

Error was for multiple definitions, so now CharSet is defined just once in main.c, a file that almost certainly will never be #include-d elsewhere. In sweep.h.in CharSet is extern-ed so it isn't redefined for every output file.

No upstream PR as the repo hasn't been updated in 4 years
Comment 9 Larry the Git Cow gentoo-dev 2020-06-08 21:58:54 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=604c163d3a85f4de6a35bda75e77518060c3e7c8

commit 604c163d3a85f4de6a35bda75e77518060c3e7c8
Author:     Azamat H. Hackimov <azamat.hackimov@gmail.com>
AuthorDate: 2020-06-08 17:28:32 +0000
Commit:     James Le Cuirot <chewi@gentoo.org>
CommitDate: 2020-06-08 21:54:19 +0000

    games-puzzle/freesweep: update to 1.0.1
    
    Update to new version, fix gcc 10 compilation (#706910, patch taken from
    https://github.com/rwestlund/freesweep/pull/8).
    
    Closes: https://bugs.gentoo.org/706910
    Package-Manager: Portage-2.3.99, Repoman-2.3.22
    Signed-off-by: Azamat H. Hackimov <azamat.hackimov@gmail.com>
    Signed-off-by: James Le Cuirot <chewi@gentoo.org>

 games-puzzle/freesweep/Manifest                    |  1 +
 .../freesweep/files/freesweep-1.0.1-gcc10.patch    | 39 ++++++++++++++++++++++
 games-puzzle/freesweep/freesweep-1.0.1.ebuild      | 31 +++++++++++++++++
 3 files changed, 71 insertions(+)