Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 705282 - =sys-libs/libcxx-9.0.1 uses lexicographical version compare
Summary: =sys-libs/libcxx-9.0.1 uses lexicographical version compare
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Alexis Ballier
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 705240
  Show dependency tree
 
Reported: 2020-01-12 11:54 UTC by Sergei Trofimovich
Modified: 2020-05-05 21:40 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sergei Trofimovich gentoo-dev 2020-01-12 11:54:48 UTC
sys-libs/libcxx uses lexicographical string version compare:

sys-libs/libcxx/libcxx-10.0.0.9999.ebuild:	if tc-is-gcc && [[ $(gcc-version) < 4.7 ]] ; then
sys-libs/libcxx/libcxx-7.1.0.ebuild:	if tc-is-gcc && [[ $(gcc-version) < 4.7 ]] ; then
sys-libs/libcxx/libcxx-8.0.1.ebuild:	if tc-is-gcc && [[ $(gcc-version) < 4.7 ]] ; then
sys-libs/libcxx/libcxx-9.0.1.ebuild:	if tc-is-gcc && [[ $(gcc-version) < 4.7 ]] ; then

The intention is likely to use 'ver_cmp'. See bug #705240 for hints to fix it.
Comment 1 Larry the Git Cow gentoo-dev 2020-05-05 21:40:23 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d564decfa7cff7c90d90b4944417c91fd7c1b048

commit d564decfa7cff7c90d90b4944417c91fd7c1b048
Author:     Sergei Trofimovich <slyfox@gentoo.org>
AuthorDate: 2020-05-05 21:40:03 +0000
Commit:     Sergei Trofimovich <slyfox@gentoo.org>
CommitDate: 2020-05-05 21:40:17 +0000

    sys-libs/libcxx: drop invalid gcc-version check, bug #705282
    
    gcc-4.7 is very old version. The version check uses lexicographical
    compare. It should use version compare to be valid. Let's just drop
    the check.
    
    Closes: https://bugs.gentoo.org/705282
    Package-Manager: Portage-2.3.99, Repoman-2.3.22
    Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>

 sys-libs/libcxx/libcxx-10.0.0.9999.ebuild | 6 ------
 sys-libs/libcxx/libcxx-10.0.0.ebuild      | 6 ------
 sys-libs/libcxx/libcxx-11.0.0.9999.ebuild | 6 ------
 sys-libs/libcxx/libcxx-8.0.1.ebuild       | 8 +-------
 sys-libs/libcxx/libcxx-9.0.1.ebuild       | 6 ------
 5 files changed, 1 insertion(+), 31 deletions(-)