kernel-2.eclass uses lexicographical string version compare: eclass/kernel-2.eclass: if [[ ${K_SYMLINK} > 0 ]]; then eclass/kernel-2.eclass: if [[ ${KV_MAJOR} -ge 3 || ${KV_MAJOR}.${KV_MINOR}.${KV_PATCH} > 2.6.24 ]] ; then eclass/kernel-2.eclass: if [[ ${KV_MAJOR} -ge 3 || ${KV_MAJOR}.${KV_MINOR}.${KV_PATCH} > 2.6.28 ]]; then eclass/kernel-2.eclass: if [[ -n ${KV_MINOR} && ${KV_MAJOR}.${KV_MINOR}.${KV_PATCH} < 2.6.27 ]] ; then The intention is likely to use 'ver_cmp'. See bug #705240 for hints to fix it.
+1 ACK for patch posted on -dev ML. @slyfox, can you attach to this bug, pls?! tia.
Sent https://archives.gentoo.org/gentoo-dev/message/e6eef477d11592e00bead2ad5168d7d5 for review.
++ and Thanks
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=8493b3a1823ea5f24f44ea317ceced513b6722ed commit 8493b3a1823ea5f24f44ea317ceced513b6722ed Author: Sergei Trofimovich <slyfox@gentoo.org> AuthorDate: 2020-05-22 19:10:43 +0000 Commit: Sergei Trofimovich <slyfox@gentoo.org> CommitDate: 2020-05-26 22:00:08 +0000 kernel-2.eclass: avoid lexicographical compare on versions, bug #705246 Originally found in bug #705240 as: ``` if [[ ... || ${KV_MAJOR}.${KV_MINOR}.${KV_PATCH} > 2.6.28 ]]; then ``` '>' are string comparisons. They are benign so far, but will start failing on linux-10 :) Let's be consistent and use version comparison. Closes: https://bugs.gentoo.org/705246 Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org> eclass/kernel-2.eclass | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
Messed up syntax in one of conditionals. Reverted as https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d5abea00d6d178139414ccc845a77d4c3e0e1f29 Well resend once fix up.
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c54b9d619157d9a24e72f04d5698a00ee9a368dd commit c54b9d619157d9a24e72f04d5698a00ee9a368dd Author: Sergei Trofimovich <slyfox@gentoo.org> AuthorDate: 2020-05-22 19:10:43 +0000 Commit: Sergei Trofimovich <slyfox@gentoo.org> CommitDate: 2020-05-27 19:20:57 +0000 kernel-2.eclass: avoid lexicographical compare on versions, bug #705246 Originally found in bug #705240 as: ``` if [[ ... || ${KV_MAJOR}.${KV_MINOR}.${KV_PATCH} > 2.6.28 ]]; then ``` '>' are string comparisons. They are benign so far, but will start failing on linux-10 :) Let's be consistent and use version comparison. Closes: https://bugs.gentoo.org/705246 Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org> eclass/kernel-2.eclass | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
