Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 699758 - app-emulation/libvirt-5.8.0: work without cgroup-hybrid (except libvirt-lxc)
Summary: app-emulation/libvirt-5.8.0: work without cgroup-hybrid (except libvirt-lxc)
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Matthias Maier
URL: https://bugzilla.redhat.com/show_bug....
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-11-10 16:41 UTC by David Heidelberg (okias)
Modified: 2020-12-21 19:20 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description David Heidelberg (okias) 2019-11-10 16:41:03 UTC
No issue running with gnome-boxes. May miss some features, but generally there is no requirement to have systemd with cgroups-hybrid, to run it.

If it's required, please explain why.

    !sys-apps/systemd[-cgroup-hybrid(+)]
Comment 1 Matthias Maier gentoo-dev 2019-11-13 03:00:13 UTC
We need it for older libvirt-5.6.0 and below (that will not start with a cgroupv2 only layout). It seems that libvirt-5.8.0 has been fully ported to virCgroupV2 (with a gigantic patchset hitting the repo in August).
Comment 2 Stefan Schmid 2019-12-03 11:38:55 UTC
> We need it for older libvirt-5.6.0 and below
> (that will not start with a cgroupv2 only layout).
Where did you get this information?
According to the release information this should work since version 4.9.0 (2018-11-04).

https://www.libvirt.org/news.html#v4.9.0
Comment 3 Matthias Maier gentoo-dev 2019-12-03 15:57:18 UTC
(In reply to Stefan Schmid from comment #2)
> > We need it for older libvirt-5.6.0 and below
> > (that will not start with a cgroupv2 only layout).
> Where did you get this information?
> According to the release information this should work since version 4.9.0
> (2018-11-04).
> 
> https://www.libvirt.org/news.html#v4.9.0

Yes, libvirt gained support for v2 back in version 4.9.0. Unfortunately, libvirt-lxc at least for libvirt 5.6.0 did not work properly with v2 only support.

This was handled in more general terms in https://bugs.gentoo.org/691310
Comment 4 Matthias Maier gentoo-dev 2019-12-03 16:20:57 UTC
For reference, I am referring to this upstream bug regarding libvirt-lxc [1]. I will disable the hard dependency on the hybrid layout once we have a upstream patch available that can be applied.

[1] https://bugzilla.redhat.com/show_bug.cgi?id=1770763
Comment 5 Larry the Git Cow gentoo-dev 2019-12-03 18:49:14 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=2ffd9ac32d6019642257ec0b4f5a34fe7a25f388

commit 2ffd9ac32d6019642257ec0b4f5a34fe7a25f388
Author:     Matthias Maier <tamiko@gentoo.org>
AuthorDate: 2019-12-03 18:48:52 +0000
Commit:     Matthias Maier <tamiko@gentoo.org>
CommitDate: 2019-12-03 18:48:52 +0000

    app-emulation/libvirt: Only require USE=cgroup-hybrid for USE=lxc
    
    Reportedly version 5.8.0 should be fine with a cgroup v2 only hierarchy
    (verified that on my own system for qemu). Unfortunately, we still need
    the hybrid layout as a mitigation for a bug in the libvirt-lxc driver.
    
    So restrict the dependency on sys-apps/systemd[cgroup-hybrid] to the
    case of USE=lxc only. This should accomodate everyone who does not need
    libvirt-lxc support and wants to have a v2 only hierarchy.
    
    Upstream Bug: https://bugzilla.redhat.com/show_bug.cgi?id=1770763
    Bug: https://bugs.gentoo.org/699758
    Package-Manager: Portage-2.3.79, Repoman-2.3.18
    Signed-off-by: Matthias Maier <tamiko@gentoo.org>

 app-emulation/libvirt/libvirt-5.8.0.ebuild | 2 +-
 app-emulation/libvirt/libvirt-9999.ebuild  | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
Comment 6 Larry the Git Cow gentoo-dev 2020-04-27 06:42:33 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=5c9044c9265f3ccffa607454be62c358e1bc2352

commit 5c9044c9265f3ccffa607454be62c358e1bc2352
Author:     Matthias Maier <tamiko@gentoo.org>
AuthorDate: 2020-04-27 06:41:46 +0000
Commit:     Matthias Maier <tamiko@gentoo.org>
CommitDate: 2020-04-27 06:42:21 +0000

    app-emulation/libvirt: drop blocker; do not require cgroup-hybrid format
    
    Version 6.2.0 (and probably also 6.0.0 and 6.1.0) now fully support the
    cgroupv2 only layout. Thus, drop the blocker on systemd[cgroup-hybrid]
    
    Bug: https://bugs.gentoo.org/699758
    Package-Manager: Portage-2.3.99, Repoman-2.3.22
    Signed-off-by: Matthias Maier <tamiko@gentoo.org>

 app-emulation/libvirt/libvirt-6.2.0-r2.ebuild | 1 -
 app-emulation/libvirt/libvirt-9999.ebuild     | 1 -
 2 files changed, 2 deletions(-)