Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 699492 - dev-tex/pgf: docinto with incorrect path, dosym with path starting with ${ED}
Summary: dev-tex/pgf: docinto with incorrect path, dosym with path starting with ${ED}
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All All
: Normal normal (vote)
Assignee: TeX project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-11-07 00:27 UTC by Arfrever Frehtes Taifersar Arahesis
Modified: 2019-11-18 17:14 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Arfrever Frehtes Taifersar Arahesis 2019-11-07 00:27:28 UTC
dev-tex/pgf/pgf-3.1.4b-r2.ebuild:               dosym "${ED}/usr/share/doc/${P}/texdoc" "${TEXMF}/doc/latex/${PN}"


Problems with above dosym command:

1. Initial ${D} or ${ED} is unnecessary in first argument (target of symbolic link), and PMS-compliant package managers will issue QA notice.
   PMS (https://projects.gentoo.org/pms/7/pms.html#x1-14800013.4.1):
   """
   13.4.1 Rewriting

   Any absolute symlink whose link starts with D must be rewritten with
   the leading D removed. The package manager should issue a notice when doing this. 
   """

2. Target of symbolic link could be made relative, instead of absolute.

3. Documentation is actually installed in ${ED}/usr/share/doc/${PF}/... instead of ${ED}/usr/share/doc/${P}/... so ${PF} should be used.
   ${P}  == pgf-3.1.4b
   ${PF} == pgf-3.1.4b-r2


Beside this, 'docinto /usr/share/doc/${P}/texdoc' is broken.
It results in installation of documentation into ${ED}/usr/share/doc/pgf-3.1.4b-r2/usr/share/doc/pgf-3.1.4b/texdoc directory.
Note double /usr/share/doc/pgf... in this path.


Solution:

docinto texdoc
...
dosym "../../../doc/${PF}/texdoc" "${TEXMF}/doc/latex/${PN}"
Comment 1 Arfrever Frehtes Taifersar Arahesis 2019-11-18 17:14:20 UTC
https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=709a79e0c4f7636a61fcbd267245952344a74f20

commit 709a79e0c4f7636a61fcbd267245952344a74f20
Author:     Mikle Kolyada <zlogene@gentoo.org>
AuthorDate: 2019-11-16 15:40:58 +0000
Commit:     Mikle Kolyada <zlogene@gentoo.org>
CommitDate: 2019-11-16 15:41:54 +0000

    dev-tex/pgf: fix docinto
    
    Package-Manager: Portage-2.3.76, Repoman-2.3.16
    Signed-off-by: Mikle Kolyada <zlogene@gentoo.org>