Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 69869 - dispatch-conf destroys binary configuration files, because of ._mrg0000_* files
Summary: dispatch-conf destroys binary configuration files, because of ._mrg0000_* files
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Core system (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Portage team
URL:
Whiteboard:
Keywords: InVCS
: 98569 (view as bug list)
Depends on:
Blocks:
 
Reported: 2004-11-02 12:17 UTC by Benjamin Braatz
Modified: 2005-07-14 06:58 UTC (History)
5 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Braatz 2004-11-02 12:17:12 UTC
When I run dispatch-conf, it tries to merge files with binary content, resulting in some ._mrg0000_* file. These files contain "<<<<<<<", "=======" and ">>>>>>>" markers for conflicting sections. So they really make _no_ sense at all for binary files. But it asks me, if I want to "use-new", nevertheless.

For example:
Files /etc/entrance_config.db and /etc/._mrg0000_entrance_config.db differ

>> (3 of 3) -- /etc/entrance_config.db
>> q quit, h help, n next, e edit-new, z zap-new, u use-new
   m merge, t toggle-merge, l look-merge:

Moreover, I then have no choice to use the "real" new file ._cfg0000_*, which is what I would prefer in most cases (this one and things like xkbcomp, rstartd.real, ...), or is that what the "t" option is for?

And, while we're at it: For these ._mrg0000_* files the display of a diff and the choices "u" and "m" do not really make sense. The file already contains the conflicts, and hence the lines from the old and the new file, you don't need to diff or merge ("m") them in again, and you probably don't want to use them unmodified ("u").

Reproducible: Always
Steps to Reproduce:
Comment 1 Petteri Räty (RETIRED) gentoo-dev 2005-04-03 04:43:28 UTC
This bug should have a higher severity. This can break users keyboard configurations, which will lead to major problems for users using foreign keyboard layouts like Finnish. 
Comment 2 Patrick Lauer gentoo-dev 2005-04-10 05:25:07 UTC
This happens on normal config files every now and then too. It's a "fatal" bug that makes dispatch-conf quite useless and should have been fixed a long time ago ...
Comment 3 Martin Allchin 2005-04-15 18:18:56 UTC
I recently started using dispatch-conf again and was dismayed this was still an issue, and got bitten on the 2nd day. Trashing configs is a severe bug, yet this is one of the few references to it I could find.

How come this hasn't gotten a higher priority?

Are only a few of us affected?

I'd love to use dispatch-conf, but this silly bugs needs attention :?
Comment 4 Jason Stubbs (RETIRED) gentoo-dev 2005-04-15 18:27:00 UTC
I fixed this a couple of days ago. The reason it took so long is because the person that wrote dispatch-conf left some time ago and nobody took over maintenance. It'll be fixed in 2.0.51.20 which should be out within the month.
Comment 5 Jakub Moc (RETIRED) gentoo-dev 2005-05-23 10:27:00 UTC
(In reply to comment #2)
> This happens on normal config files every now and then too. It's a "fatal" bug
that makes dispatch-conf quite useless and should have been fixed a long time
ago ...

Happened to me with /etc/conf.d/net just today. The file was basically merged
into itself twice, starting with

<<<<<<< /etc/config-archive/etc/conf.d/net 

and ending with

>>>>>>> 1.4 

I also noticed this problem quite a few times with php.ini. :-/ Will these
errors be fixed as well?
Comment 6 Jason Stubbs (RETIRED) gentoo-dev 2005-05-23 16:29:55 UTC
(In reply to comment #5) 
> (In reply to comment #2) 
> > This happens on normal config files every now and then too. It's a "fatal" 
bug 
> that makes dispatch-conf quite useless and should have been fixed a long 
time 
> ago ... 
>  
> Happened to me with /etc/conf.d/net just today. The file was basically 
merged 
> into itself twice, starting with 
>  
> <<<<<<< /etc/config-archive/etc/conf.d/net  
>  
> and ending with 
>  
> >>>>>>> 1.4  
>  
> I also noticed this problem quite a few times with php.ini. :-/ Will these 
> errors be fixed as well? 
 
You didn't state what portage version you are using. 
Comment 7 Jakub Moc (RETIRED) gentoo-dev 2005-05-23 21:00:59 UTC
(In reply to comment #6)
> You didn't state what portage version you are using. 

Well, I am using 2.0.51.19 as most people here. 
(I had so many issues with unstable portage versions related to sandbox that I
had to downgrade even on a testing box). 

Maybe it would be better if dispatch-conf was a separate ebuild.
Comment 8 Jason Stubbs (RETIRED) gentoo-dev 2005-05-24 06:23:39 UTC
It's not fixed in 2.0.51.19. It is fixed in >2.0.51.19. That's why this bug is 
marked InCVS but not closed yet. Those versions have the fix but are not 
marked stable yet. If you are aware that this bug exists, either watch out for 
it, upgrade to a version that has the fix, backport the fix or don't use 
dispatch-conf. Don't complain that it's not fixed. 
Comment 9 Jakub Moc (RETIRED) gentoo-dev 2005-05-25 17:06:42 UTC
Uhm, I
Comment 10 Jakub Moc (RETIRED) gentoo-dev 2005-05-25 17:06:42 UTC
Uhm, I´m not complaining that it´s not fixed. I just noted that this bug occurs
also without ._mrg0000_* files and asked whether the fix for this bug solves
this problem as well.
Comment 11 Jason Stubbs (RETIRED) gentoo-dev 2005-05-27 08:32:25 UTC
You quoted comment #2 (which was rude enough on it's own - nobody has the  
right to say "should have been fixed a long time ago" without supplying a  
patch) which implies that you share the same sentiment. Was there some other  
reason for quoting it?  
  
The bug occurs due to dispatch-conf not looking at the results of the  
three-way merge. If the merge failed, it was blindly using the resultant file  
(which contains the conflicts you see) rather than doing something more  
intelligent. There's possibly a better fix, but what I chose to do was drop  
the results altogether when a three-way merge fails and drop back to the 
etc-update behaviour of merging the current with the new. 
Comment 12 Jakub Moc (RETIRED) gentoo-dev 2005-07-10 10:43:17 UTC
*** Bug 98569 has been marked as a duplicate of this bug. ***
Comment 13 Jason Stubbs (RETIRED) gentoo-dev 2005-07-14 05:48:16 UTC
Fixed on or before 2.0.51.22-r1 
Comment 14 Jason Stubbs (RETIRED) gentoo-dev 2005-07-14 06:58:54 UTC
Looking through the batch of bugs, I'm not sure that some of these are 
actually fixed in stable. Others, the requirements have possibly changed after 
the initial fix was committed. 
 
If you think this bug has been closed incorrectly, please reopen or ask that 
it be reopened.