Created attachment 593976 [details, diff]
Fix default argument in mkLit() friend declaration
when compiling minisat-2.2.0-r4 I get the error
/var/tmp/portage/sci-mathematics/minisat-2.2.0-r4/work/minisat/core/SolverTypes.h:50:16: error: friend declaration of 'Minisat::Lit mkLit(Minisat::Var, bool)' specifies default arguments and isn't a definition [-fpermissive]
50 | friend Lit mkLit(Var var, bool sign = false);
This has been reported for another (now removed) package which appearently bundled minisat before in <https://bugs.gentoo.org/685802>, however without fixing minisat itself.
The other version in the tree, minisat-2.2.0_p20130925, does not have this problem as the corresponding patch already fixes it, but not for 2.2.0-r4.
Attached is a patch which fixes this particular problem for me.
Created attachment 593978 [details]
Created attachment 593980 [details]