Bug 696924 – www-client/chromium-78.0.3904.34 USE=system-libvpx - ../../third_party/webrtc/modules/video_coding/codecs/vp9/vp9_impl.cc:715:40: error: use of undeclared identifier 'CONSTRAINED_FROM_ABOVE_DROP'; did you mean 'CONSTRAINED_LAYER_DROP'?

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Peter Levine 2019-10-08 01:22:01 UTC]

Building www-client/chromium-78.0.3904.34  with USE=system-libvpx fails with

> ../../third_party/webrtc/modules/video_coding/codecs/vp9/vp9_impl.cc:715:40: error: use of undeclared identifier 'CONSTRAINED_FROM_ABOVE_DROP'; did you mean 'CONSTRAINED_LAYER_DROP'?
>       svc_drop_frame_.framedrop_mode = CONSTRAINED_FROM_ABOVE_DROP;
>                                        ^~~~~~~~~~~~~~~~~~~~~~~~~~~
>                                        CONSTRAINED_LAYER_DROP
> /usr/include/vpx/vp8cx.h:835:3: note: 'CONSTRAINED_LAYER_DROP' declared here
>   CONSTRAINED_LAYER_DROP,
>   ^
> 5 warnings and 1 error generated.
> ninja: build stopped: subcommand failed.

From https://webrtc.googlesource.com/src/+/1af0f908c83f0163f5ec1f2667e5ab5755d8f39f:
> VP9 screenshare: use CONSTRAINED_FROM_ABOVE_DROP mode
> 
> This mode was added by libvpx team specificaly for this usecase: if a
> layer is dropped, all lower layers have to be dropped also.

The commit corresponding to the necessary change in libvpx to fix this would be: https://github.com/webmproject/libvpx/commit/5a0242ba5c8fddbf32766bfa2ffbbd25f3cd6167

Reproducible: Always

[Comment 1 Saul Peebsen 2019-11-01 12:45:18 UTC]

Chromium rebuild was triggered by another package upgrade and all my computers are bitten by this bug. Older working ebuild has been removed from portage. Not happy.

[Comment 2 Stephan Hartmann (RETIRED) 2019-11-01 12:47:58 UTC]

(In reply to Saul Peebsen from comment #1)
> Chromium rebuild was triggered by another package upgrade and all my
> computers are bitten by this bug. Older working ebuild has been removed from
> portage. Not happy.

There is not much that can be done here. Chromium bundles a version of libvpx that is not released yet. You can workaround this problem by emerging chromium without system-vpx (USE=-system-vpx).

[Comment 3 Saul Peebsen 2019-11-02 12:50:30 UTC]

At least for me this bug has been obsoleted by 78.0.3904.87.

[Comment 4 Larry the Git Cow 2020-04-16 19:25:39 UTC]

The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=bca9b36ea529eca9b29863db59a25d3549e6bce4

commit bca9b36ea529eca9b29863db59a25d3549e6bce4
Author:     Stephan Hartmann <[e-mail]>
AuthorDate: 2020-04-16 12:19:06 +0000
Commit:     Mike Gilbert <[e-mail]>
CommitDate: 2020-04-16 19:25:28 +0000

    www-client/chromium: stable channel bumps to 81.0.4044.113
    
    Depend on >=media-libs/libvpx-1.8.2 for USE=system-vpx.
    
    Bug: https://bugs.gentoo.org/717652
    Bug: https://bugs.gentoo.org/696924
    Package-Manager: Portage-2.3.89, Repoman-2.3.20
    Signed-off-by: Stephan Hartmann <[e-mail]>
    Signed-off-by: Mike Gilbert <[e-mail]>
    Closes: https://github.com/gentoo/gentoo/pull/15371

 www-client/chromium/Manifest                      |   1 +
 www-client/chromium/chromium-81.0.4044.113.ebuild | 748 ++++++++++++++++++++++
 2 files changed, 749 insertions(+)

[Comment 5 Larry the Git Cow 2020-04-17 16:11:13 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d77a0d41ee922fb300d499589a551d107cebd0df

commit d77a0d41ee922fb300d499589a551d107cebd0df
Author:     Stephan Hartmann <[e-mail]>
AuthorDate: 2020-04-17 05:53:29 +0000
Commit:     Mike Gilbert <[e-mail]>
CommitDate: 2020-04-17 16:11:04 +0000

    www-client/chromium: beta channel bump to 83.0.4103.14
    
    Depend on >=media-libs/libvpx-1.8.2 for USE=system-vpx.
    Strip debug C{XX}FLAGS for USE="-component-build -custom-cflags",
    because debug info sections overflow.
    
    Closes: https://bugs.gentoo.org/696924
    Package-Manager: Portage-2.3.89, Repoman-2.3.20
    Signed-off-by: Stephan Hartmann <[e-mail]>
    Signed-off-by: Mike Gilbert <[e-mail]>
    Closes: https://github.com/gentoo/gentoo/pull/15386

 www-client/chromium/Manifest                                     | 2 +-
 ...{chromium-83.0.4103.7.ebuild => chromium-83.0.4103.14.ebuild} | 9 ++++++---
 2 files changed, 7 insertions(+), 4 deletions(-)