Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 695418 - dev-libs/aws-c-common-0.4.11 - add USE=static-libs for dev-libs/aws-sdk-cpp USE=static-libs
Summary: dev-libs/aws-c-common-0.4.11 - add USE=static-libs for dev-libs/aws-sdk-cpp U...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Sven Eden
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks: static-libs
  Show dependency tree
 
Reported: 2019-09-22 20:17 UTC by Ulrich
Modified: 2020-09-28 11:34 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ulrich 2019-09-22 20:17:02 UTC
Current ebuild for dev-libs/aws-c-common-0.4.11 does not have use flag for controlling -DBUILD_SHARED_LIBS.

This makes building aws-sdk-cpp-1.7.178 with static-libs option fail.

Resolved issue by adding the missing use flag to aws-c-common-0.4.11 and aws-c-event-stream-0.1.3 ebuilds.
Comment 1 Agostino Sarubbo gentoo-dev 2020-05-28 14:56:10 UTC
See also: https://projects.gentoo.org/qa/policy-guide/installed-files.html#pg0302
Comment 2 Sven Eden 2020-09-01 06:29:03 UTC
I would just have provided a PR for this and a version bump to 0.4.54, but I think https://github.com/gentoo/gentoo/pull/17303 is just fine.
Comment 3 Sven Eden 2020-09-01 07:29:12 UTC
Also added static-libs USE flag to aws-c-event-stream in https://github.com/gentoo/gentoo/pull/17355
Comment 4 Sven Eden 2020-09-14 13:59:56 UTC
Both PRs should be merged before merging https://github.com/gentoo/gentoo/pull/17536 for bug 717578.

They are both trivial, so could we make some progress there, please?
Comment 5 Sven Eden 2020-09-17 17:14:40 UTC
Unfortunately I had to add the bump, too, into a PR for fixing bug 742650.
Comment 6 Larry the Git Cow gentoo-dev 2020-09-28 11:34:24 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f0164a268f6928151ee982bd1237179690d3430c

commit f0164a268f6928151ee982bd1237179690d3430c
Author:     Sven Eden <sven.eden@prydeworx.com>
AuthorDate: 2020-09-17 14:38:59 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2020-09-28 11:25:04 +0000

    dev-libs/aws-c-common: Bump to 0.4.57 and add static-libs USE flag
    
    Bug: https://bugs.gentoo.org/695418
    Bug: https://bugs.gentoo.org/717572
    Closes: https://bugs.gentoo.org/695418
    Closes: https://bugs.gentoo.org/717572
    
    Package-Manager: Portage-3.0.7, Repoman-3.0.1
    Signed-off-by: Sven Eden <sven.eden@prydeworx.com>
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 dev-libs/aws-c-common/Manifest                                   | 2 +-
 .../{aws-c-common-0.4.11.ebuild => aws-c-common-0.4.57.ebuild}   | 3 ++-
 dev-libs/aws-c-common/metadata.xml                               | 9 ++++++++-
 3 files changed, 11 insertions(+), 3 deletions(-)

Additionally, it has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=35c25a81839989fe1124c64aa22f289b93948b44

commit 35c25a81839989fe1124c64aa22f289b93948b44
Author:     Sven Eden <sven.eden@prydeworx.com>
AuthorDate: 2020-09-01 06:48:34 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2020-09-28 11:25:05 +0000

    dev-libs/aws-c-event-stream: Version Bump to 0.1.6 plus two fixes
    
    * added static-libs USE flag.
    * depend on >=dev-libs/aws-c-common-0.4.26
      From this version on, AwsFindPackage.cmake is available, which this
      package build system uses.
    
    Bug: https://bugs.gentoo.org/695418
    Bug: https://bugs.gentoo.org/717574
    Closes: https://bugs.gentoo.org/717574
    
    Package-Manager: Portage-3.0.4, Repoman-3.0.1
    Signed-off-by: Sven Eden <sven.eden@prydeworx.com>
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 dev-libs/aws-c-event-stream/Manifest               |  1 +
 .../aws-c-event-stream-0.1.6.ebuild                | 34 ++++++++++++++++++++++
 dev-libs/aws-c-event-stream/metadata.xml           | 11 +++++--
 3 files changed, 44 insertions(+), 2 deletions(-)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f0164a268f6928151ee982bd1237179690d3430c

commit f0164a268f6928151ee982bd1237179690d3430c
Author:     Sven Eden <sven.eden@prydeworx.com>
AuthorDate: 2020-09-17 14:38:59 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2020-09-28 11:25:04 +0000

    dev-libs/aws-c-common: Bump to 0.4.57 and add static-libs USE flag
    
    Bug: https://bugs.gentoo.org/695418
    Bug: https://bugs.gentoo.org/717572
    Closes: https://bugs.gentoo.org/695418
    Closes: https://bugs.gentoo.org/717572
    
    Package-Manager: Portage-3.0.7, Repoman-3.0.1
    Signed-off-by: Sven Eden <sven.eden@prydeworx.com>
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 dev-libs/aws-c-common/Manifest                                   | 2 +-
 .../{aws-c-common-0.4.11.ebuild => aws-c-common-0.4.57.ebuild}   | 3 ++-
 dev-libs/aws-c-common/metadata.xml                               | 9 ++++++++-
 3 files changed, 11 insertions(+), 3 deletions(-)