Bug 694560 – app-emulation/virtualbox-modules-6.0.12 with kernel 5.3.0 - .../work/vboxdrv/r0drv/linux/mp-r0drv-linux.c:287:18: error: void value not ignored as it ought to be [smp_call_function()]

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Mark Nowiasz 2019-09-16 16:24:17 UTC]

The usual stuff when a new major version of a kernel has been released:

After installing kernel 5.13 and emerge @module_rebuild, virtualbox-modules fails to compile: 

var/tmp/portage/app-emulation/virtualbox-modules-6.0.12/work/vboxdrv/r0drv/linux/mp-r0drv-linux.c: In function ‘VBoxHost_RTMpOnAll’:
/var/tmp/portage/app-emulation/virtualbox-modules-6.0.12/work/vboxdrv/r0drv/linux/mp-r0drv-linux.c:287:18: error: void value not ignored as it ought to be
  287 |         int rc = smp_call_function(rtmpLinuxAllWrapper, &Args, 0 /* wait */);
      |                  ^~~~~~~~~~~~~~~~~
/var/tmp/portage/app-emulation/virtualbox-modules-6.0.12/work/vboxdrv/r0drv/linux/mp-r0drv-linux.c: In function ‘VBoxHost_RTMpOnOthers’:
/var/tmp/portage/app-emulation/virtualbox-modules-6.0.12/work/vboxdrv/r0drv/linux/mp-r0drv-linux.c:341:8: error: void value not ignored as it ought to be
  341 |     rc = smp_call_function(rtmpLinuxWrapper, &Args, 1 /* wait */);
      |        ^


Reproducible: Always




emerge --info app-emulation/virtualbox-modules
Portage 2.3.76 (python 3.7.4-final-0, default/linux/amd64/17.1/desktop/plasma/systemd, gcc-9.2.0, glibc-2.29-r5, 5.2.14-gentoo x86_64)
=================================================================
                         System Settings
=================================================================
System uname: Linux-5.2.14-gentoo-x86_64-Intel-R-_Core-TM-_i5-8250U_CPU_@_1.60GHz-with-gentoo-2.6
KiB Mem:    20426748 total,   7513744 free
KiB Swap:    8388604 total,   8388604 free
Timestamp of repository gentoo: Mon, 16 Sep 2019 14:30:01 +0000
Head commit of repository gentoo: 565ca0c4c90e59463c01fe6921f2af0ac9ce33fc
sh bash 5.0_p11
ld GNU ld (Gentoo 2.32 p2) 2.32.0
app-shells/bash:          5.0_p11::gentoo
dev-java/java-config:     2.2.0-r4::gentoo
dev-lang/perl:            5.30.0::gentoo
dev-lang/python:          2.7.16::gentoo, 3.6.9::gentoo, 3.7.4-r1::gentoo
dev-util/cmake:           3.15.3::gentoo
dev-util/pkgconfig:       0.29.2::gentoo
sys-apps/baselayout:      2.6-r1::gentoo
sys-apps/sandbox:         2.18::gentoo
sys-devel/autoconf:       2.13-r1::gentoo, 2.69-r4::gentoo
sys-devel/automake:       1.11.6-r3::gentoo, 1.16.1-r1::gentoo
sys-devel/binutils:       2.32-r1::gentoo
sys-devel/gcc:            9.2.0::gentoo
sys-devel/gcc-config:     2.1::gentoo
sys-devel/libtool:        2.4.6-r5::gentoo
sys-devel/make:           4.2.1-r4::gentoo
sys-kernel/linux-headers: 5.2::gentoo (virtual/os-headers)
sys-libs/glibc:           2.29-r5::gentoo
Repositories:

gentoo
    location: /usr/portage
    sync-type: rsync
    sync-uri: rsync://rsync.gentoo.org/gentoo-portage
    priority: -1000
    sync-rsync-verify-max-age: 24
    sync-rsync-extra-opts: 
    sync-rsync-verify-jobs: 1
    sync-rsync-verify-metamanifest: yes

matrix
    location: /var/lib/layman/matrix
    masters: gentoo
    priority: 50

ACCEPT_KEYWORDS="amd64 ~amd64"
ACCEPT_LICENSE="* -@EULA"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-march=native -O2 -pipe"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/lib64/libreoffice/program/sofficerc /usr/share/config /usr/share/gnupg/qualified.txt"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c"
CXXFLAGS="-march=native -O2 -pipe"
DISTDIR="/usr/portage/distfiles"
EMERGE_DEFAULT_OPTS="--keep-going=y"
ENV_UNSET="DBUS_SESSION_BUS_ADDRESS DISPLAY GOBIN PERL5LIB PERL5OPT PERLPREFIX PERL_CORE PERL_MB_OPT PERL_MM_OPT XAUTHORITY XDG_CACHE_HOME XDG_CONFIG_HOME XDG_DATA_HOME XDG_RUNTIME_DIR"
FCFLAGS="-O2 -pipe"
FEATURES="assume-digests binpkg-docompress binpkg-dostrip binpkg-logs config-protect-if-modified distlocks ebuild-locks fixlafiles ipc-sandbox merge-sync multilib-strict network-sandbox news parallel-fetch pid-sandbox preserve-libs protect-owned sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr"
FFLAGS="-O2 -pipe"
GENTOO_MIRRORS="http://mirror.eu.oneandone.net/linux/distributions/gentoo/gentoo/ rsync://mirror.eu.oneandone.net/gentoo/ http://mirror.netcologne.de/gentoo/ rsync://mirror.netcologne.de/gentoo/ http://linux.rz.ruhr-uni-bochum.de/download/gentoo-mirror/ http://ftp.halifax.rwth-aachen.de/gentoo/ ftp://ftp.halifax.rwth-aachen.de/gentoo/ rsync://ftp.halifax.rwth-aachen.de/gentoo/ ftp://sunsite.informatik.rwth-aachen.de/pub/Linux/gentoo"
LANG="en_US.utf8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
MAKEOPTS="-j8 -l8"
PKGDIR="/usr/portage/packages"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git"
PORTAGE_TMPDIR="/var/tmp"
USE="X a52 aac acl acpi activities alsa amd64 bash-completion berkdb bluetooth branding bzip2 cairo cdda cdr cli crypt cryptsetup cups cxx dbus declarative dri dts dvd dvdr emboss encode exif fam ffmpeg flac fortran gdbm gif gimp git glamor gles gles2 gpm gtk iconv icu ipv6 jpeg kde kipi kwallet latex lcms ldap libnotify libtirpc mad matroska mmx mng mp3 mp4 mpeg multilib ncurses networkmanager nls nptl ogg opengl openmp pam pango pcre pdf pentax phonon pim plasma png policykit ppds pulseaudio python qml qt5 readline scanner sdl seccomp semantic-desktop smartcard smp spell split-usr sse sse2 sse3 ssl startup-notification subversion svg systemd tcpd tiff touchpad truetype udev udisks unicode upower usb vaapi vim-syntax vorbis wayland widgets wxwidgets x264 xattr xcb xcomposite xml xv xvid zeroconf zlib" ABI_X86="64" ADA_TARGET="gnat_2018" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="karbon sheets words" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" CPU_FLAGS_X86="mmx mmxext sse sse2" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock isync itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf skytraq superstar2 timing tsip tripmate tnt ublox ubx" INPUT_DEVICES="evdev mouse keyboard" KERNEL="linux" L10N="en de" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" NETBEANS_MODULES="apisupport cnd groovy gsf harness ide identity j2ee java mobility nb php profiler soa visualweb webcommon websvccommon xml" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php7-2" POSTGRES_TARGETS="postgres10 postgres11" PYTHON_SINGLE_TARGET="python3_6" PYTHON_TARGETS="python2_7 python3_6 python3_7" RUBY_TARGETS="ruby25" USERLAND="GNU" VIDEO_CARDS="intel i965" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  CC, CPPFLAGS, CTARGET, CXX, INSTALL_MASK, LC_ALL, LINGUAS, PORTAGE_BINHOST, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS

=================================================================
                        Package Settings
=================================================================

app-emulation/virtualbox-modules-6.0.12::gentoo was built with the following:
USE="-pax_kernel" ABI_X86="(64)"

[Comment 1 Mark Nowiasz 2019-09-16 16:25:37 UTC]

Created attachment 590008 [details]
build.log

virtualbox-module's build.log

[Comment 2 Miroslav Šulc 2019-09-16 18:21:32 UTC]

i can confirm this issue.

[Comment 3 tka 2019-09-16 20:23:04 UTC]

There is a patch at https://www.virtualbox.org/ticket/18911.

[Comment 4 Jeroen Roovers (RETIRED) 2019-09-17 01:38:07 UTC]

*** Bug 694584 has been marked as a duplicate of this bug. ***

[Comment 5 Helmut Jarausch 2019-09-17 11:34:19 UTC]

These patches don't apply cleanly to 6.0.12
A patch for 6.0.12 is attached

[Comment 6 Helmut Jarausch 2019-09-17 11:35:13 UTC]

Created attachment 590064 [details, diff]
patch for kernel 5.3.0

[Comment 7 Helmut Jarausch 2019-09-17 11:35:57 UTC]

A similar patch is needed for virtualbox-guest-additions

[Comment 8 Jeroen Roovers (RETIRED) 2019-09-17 12:39:49 UTC]

*** Bug 694614 has been marked as a duplicate of this bug. ***

[Comment 9 Louis Sautier (sbraz) 2019-09-19 00:19:52 UTC]

Created attachment 590348 [details, diff]
archlinux's patch

Arch's patch is a bit different

[Comment 10 Malcolm Lashley 2019-09-22 15:58:19 UTC]

I patched this locally in a rush and only now got back to bugzie - my patch is much like the others - but I think you can use the 'in_dev_for_each_ifa_rcu() macro to replace 'for_ifa' - instead of the explicit for-loop viz.

-        for_ifa(in_dev) {
+        struct in_ifaddr *ifa;
+
+        in_dev_for_each_ifa_rcu(ifa, in_dev) {

I meant to give both variants a run with CONFIG_PROVE_RCU, as I suspect the arch etc. patches may get complaints there - but I don't have cycles right now.

[Comment 11 Ivan 2019-09-23 13:01:56 UTC]

(In reply to Helmut Jarausch from comment #6)
> Created attachment 590064 [details, diff] [details, diff]
> patch for kernel 5.3.0

Just added that to /etc/portage/patches/app-emulation/virtualbox-modules/linux-5.13.patch and successfully rebuilt modules.
Works fine for me with virtualbox-bin. 
Thanks.

[Comment 12 Larry the Git Cow 2019-09-24 19:56:14 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c6d0023b9e4aaab23038adb446310c74df4ebc45

commit c6d0023b9e4aaab23038adb446310c74df4ebc45
Author:     Thomas Deutschmann <[e-mail]>
AuthorDate: 2019-09-24 19:31:13 +0000
Commit:     Thomas Deutschmann <[e-mail]>
CommitDate: 2019-09-24 19:56:02 +0000

    app-emulation/virtualbox-modules: add linux-5.3+ compatibility
    
    Closes: https://bugs.gentoo.org/694560
    Package-Manager: Portage-2.3.76, Repoman-2.3.17
    Signed-off-by: Thomas Deutschmann <[e-mail]>

 ...x-modules-6.0.12-linux-5.3+-compatibility.patch | 76 ++++++++++++++++++++++
 .../virtualbox-modules-6.0.12.ebuild               |  2 +
 2 files changed, 78 insertions(+)

[Comment 13 Jeroen Roovers (RETIRED) 2019-09-28 05:52:36 UTC]

*** Bug 695590 has been marked as a duplicate of this bug. ***