Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 693574 (go-1.13-sandbox) - [tracker] packages that do not build with dev-lang/go-1.13 due to the network-sandbox
Summary: [tracker] packages that do not build with dev-lang/go-1.13 due to the network...
Status: CONFIRMED
Alias: go-1.13-sandbox
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal with 1 vote (vote)
Assignee: William Hubbs
URL:
Whiteboard:
Keywords: Tracker
: 693546 (view as bug list)
Depends on: 693682 693762 693926 693548 693578 693620 693622 693630 693764 693766 693922 693948 693992 693998
Blocks:
  Show dependency tree
 
Reported: 2019-09-05 18:23 UTC by William Hubbs
Modified: 2020-03-29 12:59 UTC (History)
6 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description William Hubbs gentoo-dev 2019-09-05 18:23:18 UTC
As usual, this is a tracker, so no talking.
Comment 1 William Hubbs gentoo-dev 2019-09-05 18:38:33 UTC
*** Bug 693546 has been marked as a duplicate of this bug. ***
Comment 2 Jason A. Donenfeld archtester Gentoo Infrastructure gentoo-dev Security 2019-10-01 09:08:13 UTC
Breaking the talking rule because I think this might apply to everything this depends on.

I've been seeing these fixed by people deleting the go.mod:
https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=98af196037b6d7968f5ffb60bc74997c8f59055a
https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=47e78e715f170ce2cfc48d7568cc83b597663c2d

Actually, though, there's a cleaner way of getting the pre-1.13 behavior to keep these packages building: `export GO111MODULE=off`, which is what I did here:

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=1c659d060363f621c66c816bf41f0bce9be688eb

That trick might allow us to quickly fixup all the broken packages in a less invasive manner.
Comment 3 Alex Efros 2019-10-01 14:54:28 UTC
(In reply to Jason A. Donenfeld from comment #2)
> I've been seeing these fixed by people deleting the go.mod:

Extremely bad idea because it'll result in building package using wrong version of dependencies and this never will be supported by upstream.
Comment 4 Zac Medico gentoo-dev 2019-10-01 19:46:23 UTC
I think that generally the path of least resistance (and forward compatibility) is to use GO111MODULE=on together with GOFLAGS=-mod=vendor, like this:

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=6554a30e6a47756812ab17110bf2a66be55edbe7
Comment 5 William Hubbs gentoo-dev 2019-10-02 18:31:21 UTC
All packages that do not build with go 1.13 and that have go.mod and
go.sum in their root directory should now inherit go-module instead of
golang-*.
Comment 6 bdouxx 2020-03-29 12:59:06 UTC
Hi, 

with the help of :
https://github.com/williamh/get-ego-vendor

can you confirm than my mkcert-1.4.1.ebuild for mkcert is OK? 

https://bugs.gentoo.org/693998


thanks