Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 692930 - >=sys-apps/kexec-tools-2.0.19 partially ignores CFLAGS
Summary: >=sys-apps/kexec-tools-2.0.19 partially ignores CFLAGS
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All All
: Normal normal (vote)
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-08-27 06:55 UTC by Arfrever Frehtes Taifersar Arahesis
Modified: 2020-05-03 19:01 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch (kexec-tools.patch,3.48 KB, patch)
2019-08-27 07:47 UTC, Arfrever Frehtes Taifersar Arahesis
Details | Diff
Patch (kexec-tools.patch,4.11 KB, patch)
2019-08-27 08:05 UTC, Arfrever Frehtes Taifersar Arahesis
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Arfrever Frehtes Taifersar Arahesis 2019-08-27 06:55:12 UTC
>=sys-apps/kexec-tools-2.0.19 ignores user-specified CFLAGS when building purgatory since this commit:
https://git.kernel.org/pub/scm/utils/kernel/kexec/kexec-tools.git/commit/?id=c493af72ac796e8ab3f3f4299205bd402dcee861
Comment 1 Arfrever Frehtes Taifersar Arahesis 2019-08-27 07:47:24 UTC
Created attachment 588250 [details, diff]
Patch
Comment 2 Arfrever Frehtes Taifersar Arahesis 2019-08-27 08:05:22 UTC
Created attachment 588252 [details, diff]
Patch

(Dropped unused inheritance of flag-o-matic.eclass.)
Comment 3 Larry the Git Cow gentoo-dev 2020-05-03 19:01:43 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b4aa565ce155f21bad4f3365268c7e7f3e370f23

commit b4aa565ce155f21bad4f3365268c7e7f3e370f23
Author:     Arfrever Frehtes Taifersar Arahesis <Arfrever@Apache.Org>
AuthorDate: 2020-05-03 19:00:08 +0000
Commit:     Thomas Deutschmann <whissi@gentoo.org>
CommitDate: 2020-05-03 19:01:11 +0000

    sys-apps/kexec-tools: respect CFLAGS for purgatory
    
    Only when building purgatory, replace -mfunction-return=thunk and
    -mindirect-branch=thunk flags with similar -mfunction-return=thunk-inline
    and -mindirect-branch=thunk-inline flags, which are not incompatible
    with flags added by build system.
    
    Closes: https://bugs.gentoo.org/646536
    Closes: https://bugs.gentoo.org/692930
    Signed-off-by: Arfrever Frehtes Taifersar Arahesis <Arfrever@Apache.Org>
    Package-Manager: Portage-2.3.99, Repoman-2.3.22
    Signed-off-by: Thomas Deutschmann <whissi@gentoo.org>

 sys-apps/kexec-tools/kexec-tools-2.0.20-r1.ebuild | 24 +++++++++++++++++--
 sys-apps/kexec-tools/kexec-tools-9999.ebuild      | 28 +++++++++++++++++++----
 2 files changed, 46 insertions(+), 6 deletions(-)