sys-libs/readline # repoman full RepoMan scours the neighborhood... ebuild.minorsyn 8 sys-libs/readline/readline-6.3_p8-r3.ebuild: Ebuild calls deprecated preserve_old_lib on line: 158 sys-libs/readline/readline-6.3_p8-r3.ebuild: Ebuild calls deprecated preserve_old_lib on line: 162 sys-libs/readline/readline-7.0_p5.ebuild: Ebuild calls deprecated preserve_old_lib on line: 169 sys-libs/readline/readline-7.0_p5.ebuild: Ebuild calls deprecated preserve_old_lib on line: 173 sys-libs/readline/readline-8.0.ebuild: Ebuild calls deprecated preserve_old_lib on line: 168 sys-libs/readline/readline-8.0.ebuild: Ebuild calls deprecated preserve_old_lib on line: 172 sys-libs/readline/readline-8.0_p1.ebuild: Ebuild calls deprecated preserve_old_lib on line: 170 sys-libs/readline/readline-8.0_p1.ebuild: Ebuild calls deprecated preserve_old_lib on line: 174 repo.eapi-deprecated 3 sys-libs/readline/readline-4.3_p5.ebuild: 5 sys-libs/readline/readline-5.2_p14.ebuild: 5 sys-libs/readline/readline-6.3_p8-r3.ebuild: 5 Note: use --include-dev (-d) to check dependencies for 'dev' profiles RepoMan sez: "You're only giving me a partial QA payment? I'll take it this time, but I'm not happy." # These warnings about preserve_old_lib are completely incorrect. If calls to preserve_old_lib() were dropped, then for users of other package managers or users of Portage with FEATURES="-preserve-libs", upgrade from e.g. sys-libs/readline-7.* to sys-libs/readline-8.* would break /bin/bash (which is linked against libreadline.so.${version}), making any upgrades/rebuilds (including rebuild of then broken app-shells/bash) impossible. Please either: 1. Drop this check 2. Change message to something like: "Ebuild calls preserve_old_lib reserved for libraries used by system packages" In this case, maybe also detect libraries used (directly or indirectly) by packages in @system set, and skip message for them. app-shells/bash:0 is in @system set, but sys-libs/readline is not.
Re-opened bug 480244, since this "deprecated preserve_old_lib" language is incorrect given that preserve-libs is not covered by PMS: https://gitweb.gentoo.org/proj/portage.git/commit/?id=49cbc17bf7b99be586e158c1bd588cfe91dfe58c
There was resistance to changing the "deprecated" language in bug 480244, so we may need to think this over a bit.
*** This bug has been marked as a duplicate of bug 480244 ***
Created attachment 688398 [details, diff] Patch only changing message
(In reply to Arfrever Frehtes Taifersar Arahesis from comment #4) > Created attachment 688398 [details, diff] [details, diff] > Patch only changing message Requested feedback in bug 480244 comment 17.
Created attachment 688401 [details, diff] Patch only changing message
The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/proj/portage.git/commit/?id=d4bd6045a50c4e662e36c2ad247c6c13d6f3e534 commit d4bd6045a50c4e662e36c2ad247c6c13d6f3e534 Author: Arfrever Frehtes Taifersar Arahesis <Arfrever@Apache.Org> AuthorDate: 2019-08-18 23:23:22 +0000 Commit: Zac Medico <zmedico@gentoo.org> CommitDate: 2021-02-25 23:37:29 +0000 repoman: Change message for preserve_old_lib (bug 692486) Bug: https://bugs.gentoo.org/692486 Signed-off-by: Arfrever Frehtes Taifersar Arahesis <Arfrever@Apache.Org> Signed-off-by: Zac Medico <zmedico@gentoo.org> repoman/cnf/linechecks/linechecks.yaml | 2 +- repoman/lib/repoman/modules/linechecks/deprecated/deprecated.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=6b061f1f7641c028c57f57bbd91997c6cf646b9a commit 6b061f1f7641c028c57f57bbd91997c6cf646b9a Author: Zac Medico <zmedico@gentoo.org> AuthorDate: 2021-03-29 07:55:56 +0000 Commit: Zac Medico <zmedico@gentoo.org> CommitDate: 2021-03-29 07:59:47 +0000 app-portage/repoman: Bump to version 3.0.3 #608664 variable.phase check like pkgcheck VariableScopeChec #692486 Change message for preserve_old_lib Bug: https://bugs.gentoo.org/608664 Bug: https://bugs.gentoo.org/692486 Package-Manager: Portage-3.0.18, Repoman-3.0.3 Signed-off-by: Zac Medico <zmedico@gentoo.org> app-portage/repoman/Manifest | 1 + app-portage/repoman/repoman-3.0.3.ebuild | 64 ++++++++++++++++++++++++++++++++ 2 files changed, 65 insertions(+)
