Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 690424 - app-shells/zsh: prefixify configure.ac
Summary: app-shells/zsh: prefixify configure.ac
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Deadline: 2019-07-29
Assignee: Tim Harder
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: prefix-gx86
  Show dependency tree
 
Reported: 2019-07-22 01:46 UTC by Benda Xu
Modified: 2019-07-24 14:59 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
zsh-prefix.patch (zsh.patch,1.25 KB, patch)
2019-07-22 01:46 UTC, Benda Xu
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Benda Xu gentoo-dev 2019-07-22 01:46:31 UTC
Created attachment 583992 [details, diff]
zsh-prefix.patch

Hi Lars,

Attached is a patch to fix build failures of zsh ebuild in Prefix.  
At present, configure.ac refers to the binaries on the host, causing wrong predictions and consequently wrong macro definitions.

It called autoreconf unconditionally.  If you think it too heavy, I could guard it within a [ -n ${EPREFIX} ] block.


If there is no problem, I intend to commit it in a week.  Thanks!

Benda
Comment 1 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2019-07-22 06:56:05 UTC
Hi Benda,

AFAIK, Tim is the primary maintainer of zsh, so this bug should go to him. But looking at your patch, I don't see why this shouldn't be applied ASAP.

Tim, what do you say?
Comment 2 Tim Harder gentoo-dev 2019-07-22 10:03:43 UTC
(In reply to Lars Wendler (Polynomial-C) from comment #1)
> Tim, what do you say?

Looks fine, go ahead.
Comment 3 Larry the Git Cow gentoo-dev 2019-07-24 08:06:44 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c774dee9dcbc6c868a85d73ff32e937735a98caf

commit c774dee9dcbc6c868a85d73ff32e937735a98caf
Author:     Benda Xu <heroxbd@gentoo.org>
AuthorDate: 2019-07-24 08:05:22 +0000
Commit:     Lars Wendler <polynomial-c@gentoo.org>
CommitDate: 2019-07-24 08:06:38 +0000

    app-shells/zsh: prefixify configure.ac.
    
    Some tests, like /usr/bin/ypbind, captures host features and
    results in build failure.
    
    Closes: https://bugs.gentoo.org/690424
    Package-Manager: Portage-2.3.69, Repoman-2.3.16
    Signed-off-by: Benda Xu <heroxbd@gentoo.org>
    Signed-off-by: Lars Wendler <polynomial-c@gentoo.org>

 app-shells/zsh/zsh-5.7.1.ebuild | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)
Comment 4 Benda Xu gentoo-dev 2019-07-24 14:59:58 UTC
Thanks, Tim and Lars!