Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 689940 - sys-boot/lilo - add nvme SSD support
Summary: sys-boot/lilo - add nvme SSD support
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal with 1 vote (vote)
Assignee: Tony Vroon (RETIRED)
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2019-07-16 01:53 UTC by nuitari
Modified: 2020-07-31 04:09 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch to add nvme support to lilo (mylilo.patch,2.59 KB, patch)
2019-07-16 01:53 UTC, nuitari
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description nuitari 2019-07-16 01:53:58 UTC
Created attachment 582960 [details, diff]
Patch to add nvme support to lilo

I've recently upgraded some disks to nvme to find that lilo is not able to install itself on it.

I found a user patch at
https://www.linuxquestions.org/questions/slackware-installation-40/installing-with-lilo-and-nvme-4175624630/

I've tested it and it works, so I'm attaching the relevant patch.
Comment 1 Tomasz Golinski 2020-05-20 14:58:50 UTC
I just tested it and works fine.
Comment 2 Joshua Kinard gentoo-dev 2020-07-26 19:35:39 UTC
Building a new developer machine, and can confirm the attached patch allows me to boot from a small Intel Optane M.2 drive.
Comment 3 Tony Vroon (RETIRED) gentoo-dev 2020-07-27 08:34:53 UTC
(In reply to Joshua Kinard from comment #2)
> Building a new developer machine, and can confirm the attached patch allows
> me to boot from a small Intel Optane M.2 drive.

Could you commit since you can test please?
All of my NVME-equipped machines are EFI stub.
Comment 4 Joshua Kinard gentoo-dev 2020-07-31 02:18:02 UTC
(In reply to Tony Vroon from comment #3)
> (In reply to Joshua Kinard from comment #2)
> > Building a new developer machine, and can confirm the attached patch allows
> > me to boot from a small Intel Optane M.2 drive.
> 
> Could you commit since you can test please?
> All of my NVME-equipped machines are EFI stub.

The -fno-common thing w/ gcc-10 has me stumped on lilo.  The code is really hard to follow and I suspect there's some nested ifdef mess going on that makes using 'extern' the right way more difficult than it at first appears.

I'll re-install gcc-9 and try again in a bit.
Comment 5 Larry the Git Cow gentoo-dev 2020-07-31 04:09:13 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d5f9c57fe506f3c38fa8b4e939fc1c1a28c621a2

commit d5f9c57fe506f3c38fa8b4e939fc1c1a28c621a2
Author:     Joshua Kinard <kumba@gentoo.org>
AuthorDate: 2020-07-31 04:08:05 +0000
Commit:     Joshua Kinard <kumba@gentoo.org>
CommitDate: 2020-07-31 04:08:45 +0000

    sys-boot/lilo: EAPI 7 and add NVME support
    
    Signed-off-by: Joshua Kinard <kumba@gentoo.org>
    Closes: https://bugs.gentoo.org/689940
    Package-Manager: Portage-3.0.1, Repoman-2.3.23

 .../lilo/files/lilo-24.2-add-nvme-support.patch    | 70 ++++++++++++++++++++++
 sys-boot/lilo/lilo-24.2.ebuild                     | 10 +++-
 2 files changed, 77 insertions(+), 3 deletions(-)