Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 686746 - app-portage/elicense-1.0.1 fails to detect some corner cases.
Summary: app-portage/elicense-1.0.1 fails to detect some corner cases.
Status: CONFIRMED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Thomas Deutschmann
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-05-25 13:43 UTC by Roy Bamford
Modified: 2019-05-27 14:24 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Roy Bamford gentoo-dev 2019-05-25 13:43:00 UTC
Method to reproduce.

emerge  app-portage/elicense
Run elicence
# elicense
# The following package(s) are using licenses which aren't covered by
# ACCEPT_LICENSE="@FREE AdobeFlash-11.x AVASYS fairuse FraunhoferFDK freedist Google-TOS Oracle-BCLA-JavaSE PUEL dlj-1.1 googleearth linux-fw-redistributable teamspeak3" setting nor have entries in the package.license file:
sys-kernel/gentoo-sources linux-firmware
sys-kernel/linux-firmware linux-firmware no-source-code
net-mail/checkpassword all-rights-reserved

Notice sys-kernel/gentoo-sources linux-firmware

Observe that sys-kernel/gentoo-sources-4.20.0 is installed.
Rip it out  emerge -c sys-kernel/gentoo-sources:4.20.0

Rerun elicense
# elicense
# The following package(s) are using licenses which aren't covered by
# ACCEPT_LICENSE="@FREE AdobeFlash-11.x AVASYS fairuse FraunhoferFDK freedist Google-TOS Oracle-BCLA-JavaSE PUEL dlj-1.1 googleearth linux-fw-redistributable teamspeak3" setting nor have entries in the package.license file:
sys-kernel/linux-firmware linux-firmware no-source-code
net-mail/checkpassword all-rights-reserved

Observe that sys-kernel/gentoo-sources linux-firmware has gone.

Look in /boot and in /lib/modules and see that the binaries are still intact, so software is installed where the license is not accepted.

Its a corner case as the kernel is special and this can only happen during the transition from the old ACCEPT_LICENSE default to the new one.
Comment 1 Ulrich Müller gentoo-dev 2019-05-27 14:24:28 UTC
(In reply to Roy Bamford from comment #0)
> Look in /boot and in /lib/modules and see that the binaries are still
> intact, so software is installed where the license is not accepted.

Kernel version 4.20.0 doesn't contain any non-free firmware, therefore you won't find any non-free binaries in /boot or /lib/modules. The problem is that the line "sys-kernel/gentoo-sources linux-firmware" isn't correct, in the first place.

We were late in updating kernel-2.eclass to reflect upstream removal of the firmware tree (which happened in kernel 4.14 already), so gentoo-sources-4.20.0.ebuild was already gone when the eclass was fixed. Which cannot retroactively affect installed packages, of course.

In any case, this is not a bug in the elicense tool.