Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 686406 - sys-apps/portage: ACCEPT_LICENSE="-*" translates to ACCEPT_LICENSE="* -@EULA"
Summary: sys-apps/portage: ACCEPT_LICENSE="-*" translates to ACCEPT_LICENSE="* -@EULA"
Status: RESOLVED FIXED
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Core (show other bugs)
Hardware: All All
: Normal normal (vote)
Assignee: Portage team
URL:
Whiteboard:
Keywords: InVCS
Depends on:
Blocks: 686768
  Show dependency tree
 
Reported: 2019-05-20 18:26 UTC by Zac Medico
Modified: 2019-08-01 19:19 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zac Medico gentoo-dev 2019-05-20 18:26:59 UTC 
Reported earlier in bug 677800, comment 18, this issue renders ACCEPT_LICENSE="-*" ineffective:

> $ env ACCEPT_LICENSE="-*" python -c 'import portage; print(portage.settings["ACCEPT_LICENSE"])'
> * -@EULA
Comment 1 Zac Medico gentoo-dev 2019-05-20 19:56:13 UTC 
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/proj/portage.git/commit/?id=b7c510f76d83ef70738b03a925ffb4a36797750d

commit b7c510f76d83ef70738b03a925ffb4a36797750d
Author:     Zac Medico <zmedico@gentoo.org>
AuthorDate: 2019-05-20 11:45:54 -0700
Commit:     Zac Medico <zmedico@gentoo.org>
CommitDate: 2019-05-20 12:12:58 -0700

    Fix ACCEPT_LICENSE="-*" to behave as intended (bug 686406)
    
    Fix prune_incremental to preserve the last -*, since otherwise an
    empty value would trigger fallback to a default value. This ensures
    that ACCEPT_LICENSE="-*" behaves as intended.
    
    Signed-off-by: Zac Medico <zmedico@gentoo.org>

 lib/portage/package/ebuild/_config/helper.py | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)